Skip to content

Commit 9b6da5f

Browse files
Merge pull request #18655 from MoonE/remove-duplicate-themeImagePath
Remove duplicate themeImagePath variable
2 parents b6a3e8f + a2b5615 commit 9b6da5f

3 files changed

Lines changed: 7 additions & 10 deletions

File tree

js/src/table/gis_visualization.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -80,17 +80,16 @@ function addZoomPanControllers () {
8080
return;
8181
}
8282

83-
var themeImagePath = $('#themeImagePath').val();
8483
$('#placeholder').append(
8584
// pan arrows
86-
'<img class="button" id="left_arrow" src="' + themeImagePath + 'west-mini.png">',
87-
'<img class="button" id="right_arrow" src="' + themeImagePath + 'east-mini.png">',
88-
'<img class="button" id="up_arrow" src="' + themeImagePath + 'north-mini.png">',
89-
'<img class="button" id="down_arrow" src="' + themeImagePath + 'south-mini.png">',
85+
'<img class="button" id="left_arrow" src="' + window.themeImagePath + 'west-mini.png">',
86+
'<img class="button" id="right_arrow" src="' + window.themeImagePath + 'east-mini.png">',
87+
'<img class="button" id="up_arrow" src="' + window.themeImagePath + 'north-mini.png">',
88+
'<img class="button" id="down_arrow" src="' + window.themeImagePath + 'south-mini.png">',
9089
// zoom controls
91-
'<img class="button" id="zoom_in" src="' + themeImagePath + 'zoom-plus-mini.png">',
92-
'<img class="button" id="zoom_world" src="' + themeImagePath + 'zoom-world-mini.png">',
93-
'<img class="button" id="zoom_out" src="' + themeImagePath + 'zoom-minus-mini.png">'
90+
'<img class="button" id="zoom_in" src="' + window.themeImagePath + 'zoom-plus-mini.png">',
91+
'<img class="button" id="zoom_world" src="' + window.themeImagePath + 'zoom-world-mini.png">',
92+
'<img class="button" id="zoom_out" src="' + window.themeImagePath + 'zoom-minus-mini.png">'
9493
);
9594
}
9695

templates/gis_data_editor_form.twig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
<form id="gis_data_editor_form" action="{{ url('/gis-data-editor') }}" method="post">
2-
<input type="hidden" id="themeImagePath" value="{{ image() }}">
32
<div id="gis_data_editor">
43
<h3>{{ 'Value for the column "%s"'|trans|format(field) }}</h3>
54

templates/table/gis_visualization/gis_visualization.twig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@
5555
{{ visualization|raw }}
5656
</div>
5757
<div id="openlayersmap"></div>
58-
<input type="hidden" id="themeImagePath" value="{{ image() }}">
5958
<script>{{ draw_ol|raw }}</script>
6059
</div>
6160
</div>

0 commit comments

Comments
 (0)