Skip to content

Commit 9aaf556

Browse files
committed
Disable fail-fast for Selenium workflow
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
1 parent 5954af9 commit 9aaf556

2 files changed

Lines changed: 5 additions & 9 deletions

File tree

.github/workflows/test-selenium.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ jobs:
5353
--cap-add=NET_RAW
5454
--restart on-failure
5555
strategy:
56+
fail-fast: false
5657
matrix:
5758
test-name:
5859
- "ChangePassword"

test/selenium/ExportTest.php

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
namespace PhpMyAdmin\Tests\Selenium;
66

7-
use Facebook\WebDriver\Exception\ElementClickInterceptedException;
8-
97
use function sleep;
108

119
/**
@@ -168,13 +166,10 @@ private function doExport(string $type, string $plugin): string
168166
}
169167

170168
$this->scrollToBottom();
171-
try {
172-
$this->waitForElement('id', 'buttonGo')->click();
173-
} catch (ElementClickInterceptedException $exception) {
174-
sleep(1);
175-
$this->scrollToBottom();
176-
$this->waitForElement('id', 'buttonGo')->click();
177-
}
169+
sleep(2);
170+
$this->scrollToBottom();
171+
172+
$this->waitForElement('id', 'buttonGo')->click();
178173

179174
$this->waitAjax();
180175

0 commit comments

Comments
 (0)