Merge pull request #19212 from kamil-tekiela/privatize-const

MauricioFauth · web-flow · commit 91ea4bee40b1 · 2024-06-28T15:23:14.000-03:00
Privatize constants
diff --git a/src/Controllers/LintController.php b/src/Controllers/LintController.php
@@ -20,7 +20,7 @@
  */
 final class LintController implements InvocableController
 {
-    public const EDITOR_SQL_PREFIX = [
+    private const EDITOR_SQL_PREFIX = [
         'event' => "DELIMITER $$ CREATE EVENT `a` ON SCHEDULE EVERY MINUTE DO\n",
         'routine' => "DELIMITER $$ CREATE PROCEDURE `a`()\n",
         'trigger' => "DELIMITER $$ CREATE TRIGGER `a` AFTER INSERT ON `b` FOR EACH ROW\n",
diff --git a/src/Display/Results.php b/src/Display/Results.php
@@ -86,10 +86,10 @@
  */
 class Results
 {
-    public const POSITION_LEFT = 'left';
-    public const POSITION_RIGHT = 'right';
-    public const POSITION_BOTH = 'both';
-    public const POSITION_NONE = 'none';
+    private const POSITION_LEFT = 'left';
+    private const POSITION_RIGHT = 'right';
+    private const POSITION_BOTH = 'both';
+    private const POSITION_NONE = 'none';
 
     public const DISPLAY_FULL_TEXT = 'F';
     public const DISPLAY_PARTIAL_TEXT = 'P';
@@ -101,15 +101,14 @@ class Results
     public const GEOMETRY_DISP_WKT = 'WKT';
     public const GEOMETRY_DISP_WKB = 'WKB';
 
-    public const SMART_SORT_ORDER = 'SMART';
-    public const ASCENDING_SORT_DIR = 'ASC';
-    public const DESCENDING_SORT_DIR = 'DESC';
+    private const SMART_SORT_ORDER = 'SMART';
+    private const ASCENDING_SORT_DIR = 'ASC';
+    private const DESCENDING_SORT_DIR = 'DESC';
 
-    public const TABLE_TYPE_INNO_DB = 'InnoDB';
     public const ALL_ROWS = 'all';
 
-    public const ACTION_LINK_CONTENT_ICONS = 'icons';
-    public const ACTION_LINK_CONTENT_TEXT = 'text';
+    private const ACTION_LINK_CONTENT_ICONS = 'icons';
+    private const ACTION_LINK_CONTENT_TEXT = 'text';
 
     /**
      * the total number of rows returned by the SQL query without any appended "LIMIT" clause programmatically

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`*/`
`21`	`21`	`final class LintController implements InvocableController`
`22`	`22`	`{`
`23`		`- public const EDITOR_SQL_PREFIX = [`
	`23`	`+ private const EDITOR_SQL_PREFIX = [`
`24`	`24`	'event' => "DELIMITER $$ CREATE EVENT `a` ON SCHEDULE EVERY MINUTE DO\n",
`25`	`25`	'routine' => "DELIMITER $$ CREATE PROCEDURE `a`()\n",
`26`	`26`	'trigger' => "DELIMITER $$ CREATE TRIGGER `a` AFTER INSERT ON `b` FOR EACH ROW\n",