Merge branch 'QA_5_2'

MauricioFauth · MauricioFauth · commit 905214ae0b43 · 2022-06-11T14:13:30.000-03:00
Signed-off-by: Maurício Meneghini Fauth &lt;mauricio@fauth.dev&gt;
diff --git a/ChangeLog b/ChangeLog
@@ -16,6 +16,7 @@ phpMyAdmin - ChangeLog
 - issue #17366 Fix refresh rate popup on Monitor page
 - issue #17577 Fix monitor charts size on RTL languages
 - issue #17121 Fix password_hash function incorrectly adding single quotes to password before hashing
+- issue #17586 Fix statistics not showing for empty databases
 
 5.2.0 (2022-05-10)
 - issue #16521 Upgrade Bootstrap to version 5
diff --git a/libraries/classes/Controllers/Server/DatabasesController.php b/libraries/classes/Controllers/Server/DatabasesController.php
@@ -257,8 +257,8 @@ private function getDatabases($primaryInfo, $replicaInfo): array
             $statistics = $this->getStatisticsColumns();
             if ($this->hasStatistics) {
                 foreach (array_keys($statistics) as $key) {
-                    $statistics[$key]['raw'] = $database[$key] ?? null;
-                    $totalStatistics[$key]['raw'] += (int) $database[$key] ?? 0;
+                    $statistics[$key]['raw'] = (int) ($database[$key] ?? 0);
+                    $totalStatistics[$key]['raw'] += (int) ($database[$key] ?? 0);
                 }
             }
 
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -1255,11 +1255,6 @@ parameters:
 			count: 1
 			path: libraries/classes/Controllers/Server/BinlogController.php
 
-		-
-			message: "#^Expression on left side of \\?\\? is not nullable\\.$#"
-			count: 1
-			path: libraries/classes/Controllers/Server/DatabasesController.php
-
 		-
 			message: "#^Method PhpMyAdmin\\\\Controllers\\\\Server\\\\DatabasesController\\:\\:getDatabases\\(\\) has parameter \\$primaryInfo with no value type specified in iterable type array\\.$#"
 			count: 1
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -2656,7 +2656,8 @@
     <MixedArgumentTypeCoercion occurrences="1">
       <code>['db' =&gt; $database['SCHEMA_NAME']]</code>
     </MixedArgumentTypeCoercion>
-    <MixedArrayAccess occurrences="13">
+    <MixedArrayAccess occurrences="14">
+      <code>$database[$key]</code>
       <code>$database[$key]</code>
       <code>$database['DEFAULT_COLLATION_NAME']</code>
       <code>$database['SCHEMA_NAME']</code>
@@ -2679,15 +2680,14 @@
       <code>$databases[$database['SCHEMA_NAME']]</code>
       <code>$databases[$database['SCHEMA_NAME']]</code>
     </MixedArrayOffset>
-    <MixedAssignment occurrences="9">
+    <MixedAssignment occurrences="8">
       <code>$GLOBALS['db_to_create']</code>
       <code>$GLOBALS['errorUrl']</code>
       <code>$database</code>
       <code>$key</code>
       <code>$key</code>
       <code>$key</code>
       <code>$key</code>
-      <code>$statistics[$key]['raw']</code>
       <code>$totalStatistics[$key]['raw']</code>
     </MixedAssignment>
     <MixedOperand occurrences="1">
@@ -2705,12 +2705,6 @@
       <code>$sortBy</code>
       <code>$sortOrder</code>
     </PropertyNotSetInConstructor>
-    <RedundantCondition occurrences="1">
-      <code>(int) $database[$key]</code>
-    </RedundantCondition>
-    <TypeDoesNotContainNull occurrences="1">
-      <code>0</code>
-    </TypeDoesNotContainNull>
   </file>
   <file src="libraries/classes/Controllers/Server/ExportController.php">
     <MixedArgument occurrences="3">

Original file line number	Diff line number	Diff line change
`@@ -257,8 +257,8 @@ private function getDatabases($primaryInfo, $replicaInfo): array`
`257`	`257`	`$statistics = $this->getStatisticsColumns();`
`258`	`258`	`if ($this->hasStatistics) {`
`259`	`259`	`foreach (array_keys($statistics) as $key) {`
`260`		`- $statistics[$key]['raw'] = $database[$key] ?? null;`
`261`		`- $totalStatistics[$key]['raw'] += (int) $database[$key] ?? 0;`
	`260`	`+ $statistics[$key]['raw'] = (int) ($database[$key] ?? 0);`
	`261`	`+ $totalStatistics[$key]['raw'] += (int) ($database[$key] ?? 0);`
`262`	`262`	`}`
`263`	`263`	`}`
`264`	`264`