Skip to content

Commit 8d982e3

Browse files
MauricioFauthMauricioFauth
authored
Merge pull request #18781 from MauricioFauth/shellcheck-action
Add ShellCheck to CI
2 parents 98b7f38 + cd883c6 commit 8d982e3

11 files changed

Lines changed: 179 additions & 173 deletions

‎.github/workflows/shellcheck.yml‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
name: ShellCheck
2+
3+
on:
4+
push:
5+
paths:
6+
- 'scripts/**'
7+
pull_request:
8+
paths:
9+
- 'scripts/**'
10+
11+
permissions:
12+
contents: read
13+
14+
jobs:
15+
shellcheck:
16+
name: ShellCheck
17+
runs-on: ubuntu-latest
18+
steps:
19+
- name: Checkout
20+
uses: actions/checkout@v4
21+
22+
- name: Run ShellCheck
23+
uses: reviewdog/action-shellcheck@v1
24+
with:
25+
path: scripts
26+
check_all_files_with_shebangs: true
27+
fail_on_error: true

‎scripts/check-release-excludes.sh‎

Lines changed: 29 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -37,34 +37,28 @@ validateExtension() {
3737

3838
case $pathWithoutFirst in
3939
doc/*)
40-
if [ \
41-
"${extension}" != "png" -a "${extension}" != "txt" \
42-
-a "${extension}" != "html" -a "${extension}" != "js" \
43-
-a "${extension}" != "css" -a "${extension}" != "gif" \
44-
]; then
40+
if [ "${extension}" != "png" ] && [ "${extension}" != "txt" ] &&
41+
[ "${extension}" != "html" ] && [ "${extension}" != "js" ] &&
42+
[ "${extension}" != "css" ] && [ "${extension}" != "gif" ]; then
4543
foundFileExt
4644
fi
4745
;;
4846
resources/js/global.d.ts)
4947
;;
5048
public/js/vendor/*)
51-
if [ \
52-
"${extension}" != "js" -a "${extension}" != "map" \
53-
-a "${extension}" != "css" -a "${filename}" != "LICENSE" \
54-
-a "${extension}" != "txt" \
55-
]; then
49+
if [ "${extension}" != "js" ] && [ "${extension}" != "map" ] &&
50+
[ "${extension}" != "css" ] && [ "${filename}" != "LICENSE" ] &&
51+
[ "${extension}" != "txt" ]; then
5652
foundFileExt
5753
fi
5854
;;
5955
public/js/dist/*)
60-
if [ "${extension}" != "js" -a "${extension}" != "map" ];then
56+
if [ "${extension}" != "js" ] && [ "${extension}" != "map" ]; then
6157
foundFileExt
6258
fi
6359
;;
6460
resources/js/src/*)
65-
if [ \
66-
"${extension}" != "ts" -a "${extension}" != "mjs" \
67-
]; then
61+
if [ "${extension}" != "ts" ] && [ "${extension}" != "mjs" ]; then
6862
foundFileExt
6963
fi
7064
;;
@@ -84,11 +78,9 @@ validateExtension() {
8478
fi
8579
;;
8680
public/setup/*)
87-
if [ \
88-
"${extension}" != "php" -a "${extension}" != "twig" \
89-
-a "${extension}" != "css" \
90-
-a "${extension}" != "scss" -a "${extension}" != "gif" -a "${extension}" != "map" \
91-
]; then
81+
if [ "${extension}" != "php" ] && [ "${extension}" != "twig" ] &&
82+
[ "${extension}" != "css" ] && [ "${extension}" != "scss" ] &&
83+
[ "${extension}" != "gif" ] && [ "${extension}" != "map" ]; then
9284
foundFileExt
9385
fi
9486
;;
@@ -103,21 +95,17 @@ validateExtension() {
10395
fi
10496
;;
10597
src/*)
106-
if [ \
107-
"${extension}" != "php" -a "${extension}" != "md" \
108-
-a "${filename}" != "README" \
109-
-a "${filename}" != "TEMPLATE" -a "${filename}" != "TEMPLATE_ABSTRACT" \
110-
]; then
98+
if [ "${extension}" != "php" ] && [ "${extension}" != "md" ] &&
99+
[ "${filename}" != "README" ] && [ "${filename}" != "TEMPLATE" ] &&
100+
[ "${filename}" != "TEMPLATE_ABSTRACT" ]; then
111101
foundFileExt
112102
fi
113103
;;
114104
public/themes/*)
115-
if [ \
116-
"${extension}" != "css" -a "${extension}" != "png" \
117-
-a "${extension}" != "scss" -a "${extension}" != "map" \
118-
-a "${extension}" != "svg" -a "${extension}" != "ico" \
119-
-a "${extension}" != "gif" -a "${extension}" != "json" \
120-
]; then
105+
if [ "${extension}" != "css" ] && [ "${extension}" != "png" ] &&
106+
[ "${extension}" != "scss" ] && [ "${extension}" != "map" ] &&
107+
[ "${extension}" != "svg" ] && [ "${extension}" != "ico" ] &&
108+
[ "${extension}" != "gif" ] && [ "${extension}" != "json" ]; then
121109
foundFileExt
122110
fi
123111
;;
@@ -135,25 +123,21 @@ validateExtension() {
135123
vendor/composer/installed.json)
136124
;;
137125
vendor/tecnickcom/tcpdf/*)
138-
if [ \
139-
"${extension}" != "php" -a "${filename}" != "LICENSE.TXT" \
140-
-a "${filename}" != "README.md" -a "${filename}" != "CHANGELOG.TXT" \
141-
-a "${filename}" != "VERSION" -a "${filename}" != "composer.json" \
142-
-a "${extension}" != "z" \
143-
]; then
126+
if [ "${extension}" != "php" ] && [ "${filename}" != "LICENSE.TXT" ] &&
127+
[ "${filename}" != "README.md" ] && [ "${filename}" != "CHANGELOG.TXT" ] &&
128+
[ "${filename}" != "VERSION" ] && [ "${filename}" != "composer.json" ] &&
129+
[ "${extension}" != "z" ]; then
144130
foundFileExt
145131
fi
146132
;;
147133
vendor/*)
148-
if [ \
149-
"${extension}" != "php" -a "${filename}" != "LICENSE" \
150-
-a "${filename}" != "README" -a "${filename}" != "CHANGELOG" \
151-
-a "${filename}" != "composer.json" -a "${filename}" != "CHANGELOG.md" \
152-
-a "${filename}" != "README.md" -a "${filename}" != "BACKERS.md" \
153-
-a "${filename}" != "LICENSE.md" -a "${filename}" != "ARCHITECTURE.md" \
154-
-a "${filename}" != "LICENSE.txt" -a "${filename}" != "AUTHORS" \
155-
-a "${filename}" != "LICENCE.md" -a "${filename}" != "LICENCE" \
156-
]; then
134+
if [ "${extension}" != "php" ] && [ "${filename}" != "LICENSE" ] &&
135+
[ "${filename}" != "README" ] && [ "${filename}" != "CHANGELOG" ] &&
136+
[ "${filename}" != "composer.json" ] && [ "${filename}" != "CHANGELOG.md" ] &&
137+
[ "${filename}" != "README.md" ] && [ "${filename}" != "BACKERS.md" ] &&
138+
[ "${filename}" != "LICENSE.md" ] && [ "${filename}" != "ARCHITECTURE.md" ] &&
139+
[ "${filename}" != "LICENSE.txt" ] && [ "${filename}" != "AUTHORS" ] &&
140+
[ "${filename}" != "LICENCE.md" ] && [ "${filename}" != "LICENCE" ]; then
157141
foundFileExt
158142
fi
159143
;;
@@ -239,10 +223,6 @@ for filePath in ${FILE_LIST}; do
239223
foundFile;;
240224
*/.php_cs.cache)
241225
foundFile;;
242-
*/psalm.xml)
243-
foundFile;;
244-
*/phpstan.neon)
245-
foundFile;;
246226
*/phpstan.neon)
247227
foundFile;;
248228
*/phpcs.xml.dist)
@@ -267,8 +247,6 @@ for filePath in ${FILE_LIST}; do
267247
foundFile;;
268248
*/makefile)
269249
foundFile;;
270-
*/Makefile)
271-
foundFile;;
272250
*/.phpunit.result.cache)
273251
foundFile;;
274252
*/phpstan.neon.dist)

0 commit comments

Comments
 (0)