Merge pull request #18464 from kamil-tekiela/Refactor-parsePath

MauricioFauth · web-flow · commit 8bb312514e13 · 2023-05-29T23:20:36.000-03:00
More specific return type
diff --git a/libraries/classes/Navigation/NavigationTree.php b/libraries/classes/Navigation/NavigationTree.php
@@ -40,6 +40,7 @@
 use function array_intersect_key;
 use function array_key_exists;
 use function array_keys;
+use function array_map;
 use function array_merge;
 use function array_shift;
 use function base64_decode;
@@ -289,16 +290,11 @@ private function getNavigationDbPos(): int
      *
      * @param string $string The path to parse
      *
-     * @return mixed[]
+     * @return non-empty-list<string>
      */
     private function parsePath(string $string): array
     {
-        $path = explode('.', $string);
-        foreach ($path as $key => $value) {
-            $path[$key] = base64_decode($value);
-        }
-
-        return $path;
+        return array_map(base64_decode(...), explode('.', $string));
     }
 
     /**
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -4640,6 +4640,11 @@ parameters:
 			count: 1
 			path: libraries/classes/Navigation/NavigationTree.php
 
+		-
+			message: "#^Method PhpMyAdmin\\\\Navigation\\\\NavigationTree\\:\\:parsePath\\(\\) should return non\\-empty\\-array\\<int, string\\> but returns non\\-empty\\-array\\<int, string\\|false\\>\\.$#"
+			count: 1
+			path: libraries/classes/Navigation/NavigationTree.php
+
 		-
 			message: "#^Only numeric types are allowed in \\+, int\\|false given on the left side\\.$#"
 			count: 1
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -7657,6 +7657,12 @@
       <code><![CDATA[$this->pos3Name]]></code>
       <code><![CDATA[$this->pos3Name]]></code>
     </InvalidPropertyAssignmentValue>
+    <InvalidReturnStatement>
+      <code><![CDATA[array_map(base64_decode(...), explode('.', $string))]]></code>
+    </InvalidReturnStatement>
+    <InvalidReturnType>
+      <code><![CDATA[non-empty-list<string>]]></code>
+    </InvalidReturnType>
     <MixedArgument>
       <code>$db</code>
       <code>$item</code>
