Deprecate the db and table properties from controllers

MauricioFauth · MauricioFauth · commit 87f8ece01d72 · 2022-01-28T20:51:03.000-03:00
The database and table parameters should be got from the server request
or from the respective globals.

Signed-off-by: Maurício Meneghini Fauth &lt;mauricio@fauth.dev&gt;
diff --git a/libraries/classes/Controllers/Database/AbstractController.php b/libraries/classes/Controllers/Database/AbstractController.php
@@ -10,7 +10,11 @@
 
 abstract class AbstractController extends Controller
 {
-    /** @var string */
+    /**
+     * @deprecated Get the value from $GLOBALS['db'] or from the {@see \PhpMyAdmin\Http\ServerRequest} instance.
+     *
+     * @var string
+     */
     protected $db;
 
     public function __construct(ResponseRenderer $response, Template $template, string $db)
diff --git a/libraries/classes/Controllers/Table/AbstractController.php b/libraries/classes/Controllers/Table/AbstractController.php
@@ -10,10 +10,18 @@
 
 abstract class AbstractController extends Controller
 {
-    /** @var string */
+    /**
+     * @deprecated Get the value from $GLOBALS['db'] or from the {@see \PhpMyAdmin\Http\ServerRequest} instance.
+     *
+     * @var string
+     */
     protected $db;
 
-    /** @var string */
+    /**
+     * @deprecated Get the value from $GLOBALS['table'] or from the {@see \PhpMyAdmin\Http\ServerRequest} instance.
+     *
+     * @var string
+     */
     protected $table;
 
     public function __construct(ResponseRenderer $response, Template $template, string $db, string $table)
diff --git a/libraries/classes/Error.php b/libraries/classes/Error.php
@@ -479,7 +479,7 @@ public function getDisplay(): string
 
         $template = new Template();
 
-        return $template->render('error/get_display',[
+        return $template->render('error/get_display', [
             'context' => $context,
             'isUserError' => $this->isUserError(),
             'type' => $this->getType(),
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
