Merge branch 'QA_5_2'

MauricioFauth · MauricioFauth · commit 86eea3a730f9 · 2022-02-11T15:22:51.000-03:00
diff --git a/libraries/classes/Tracker.php b/libraries/classes/Tracker.php
@@ -950,7 +950,7 @@ public static function handleQuery($query): void
         " AND `db_name` = '" . $dbi->escapeString($dbname ?? '') . "' " .
         " AND `table_name` = '"
         . $dbi->escapeString($result['tablename']) . "' " .
-        " AND `version` = '" . $dbi->escapeString($version ?? '') . "' ";
+        " AND `version` = '" . $dbi->escapeString((string) $version) . "' ";
 
         $dbi->queryAsControlUser($sqlQuery);
     }
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -8370,11 +8370,6 @@ parameters:
 			count: 1
 			path: libraries/classes/Tracker.php
 
-		-
-			message: "#^Variable \\$version on left side of \\?\\? always exists and is not nullable\\.$#"
-			count: 1
-			path: libraries/classes/Tracker.php
-
 		-
 			message: "#^Cannot access offset 'COLUMNS' on mixed\\.$#"
 			count: 1
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -13412,8 +13412,7 @@
     </UnevaluatedCode>
   </file>
   <file src="libraries/classes/Tracker.php">
-    <DocblockTypeContradiction occurrences="4">
-      <code>''</code>
+    <DocblockTypeContradiction occurrences="3">
       <code>null</code>
       <code>null</code>
       <code>null</code>
@@ -13463,9 +13462,6 @@
       <code>mb_strpos($logEntry, "\n")</code>
       <code>mb_strpos($logEntry, "\n")</code>
     </PossiblyFalseOperand>
-    <PossiblyInvalidArgument occurrences="1">
-      <code>$version ?? ''</code>
-    </PossiblyInvalidArgument>
     <PossiblyInvalidPropertyFetch occurrences="4">
       <code>$statement-&gt;body[2]-&gt;value</code>
       <code>$statement-&gt;body[3]-&gt;value</code>
@@ -13481,10 +13477,9 @@
     <RedundantCondition occurrences="1">
       <code>$dbname</code>
     </RedundantCondition>
-    <RedundantConditionGivenDocblockType occurrences="4">
+    <RedundantConditionGivenDocblockType occurrences="3">
       <code>$statement-&gt;name !== null</code>
       <code>$statement-&gt;name !== null</code>
-      <code>$version</code>
       <code>isset($statement-&gt;options)</code>
     </RedundantConditionGivenDocblockType>
     <TypeDoesNotContainNull occurrences="1">
diff --git a/test/selenium/Table/CreateTest.php b/test/selenium/Table/CreateTest.php
@@ -65,7 +65,7 @@ public function testCreateTable(): void
         $column_dropdown_details = [
             'field_0_6' => 'UNSIGNED',
             'field_1_2' => 'VARCHAR',
-            'field_1_5' => 'utf8_general_ci',
+            'field_1_5' => 'utf8mb4_general_ci',
             'field_1_4' => 'As defined:',
         ];
 
@@ -83,7 +83,7 @@ public function testCreateTable(): void
         $this->moveto($ele);
         // post
         $ele->click();
-        $this->waitForElement('cssSelector', 'li.last.table');
+        $this->waitForElement('cssSelector', 'li.last.nav_node_table');
 
         $this->waitAjax();
 
@@ -162,7 +162,7 @@ private function tableStructureAssertions(): void
         );
 
         $this->assertEquals(
-            'utf8_general_ci',
+            'utf8mb4_general_ci',
             $this->getCellByTableId('tablestructure', 2, 5)
         );
 

Original file line number	Diff line number	Diff line change
`@@ -950,7 +950,7 @@ public static function handleQuery($query): void`
`950`	`950`	" AND `db_name` = '" . $dbi->escapeString($dbname ?? '') . "' " .
`951`	`951`	" AND `table_name` = '"
`952`	`952`	`. $dbi->escapeString($result['tablename']) . "' " .`
`953`		- " AND `version` = '" . $dbi->escapeString($version ?? '') . "' ";
	`953`	+ " AND `version` = '" . $dbi->escapeString((string) $version) . "' ";
`954`	`954`
`955`	`955`	`$dbi->queryAsControlUser($sqlQuery);`
`956`	`956`	`}`