Merge pull request #18668 from kamil-tekiela/Add-number-formatting-to-Total-on-Browse

MauricioFauth · web-flow · commit 80b17822de34 · 2023-08-29T19:30:37.000-03:00
Add number formatting to Total on Browse
diff --git a/libraries/classes/Display/Results.php b/libraries/classes/Display/Results.php
@@ -3709,13 +3709,13 @@ private function setMessageInformation(
         if ($messageViewWarning === false) {
             if ($unlimNumRows != $total) {
                 $messageTotal = Message::notice(
-                    $preCount . __('%1$d total, %2$d in query'),
+                    $preCount . __('%1$s total, %2$s in query'),
                 );
-                $messageTotal->addParam($total);
-                $messageTotal->addParam($unlimNumRows);
+                $messageTotal->addParam(Util::formatNumber($total, 0));
+                $messageTotal->addParam(Util::formatNumber($unlimNumRows, 0));
             } else {
-                $messageTotal = Message::notice($preCount . __('%d total'));
-                $messageTotal->addParam($total);
+                $messageTotal = Message::notice($preCount . __('%s total'));
+                $messageTotal->addParam(Util::formatNumber($total, 0));
             }
 
             if ($afterCount !== '') {
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -10055,6 +10055,11 @@ parameters:
 			count: 5
 			path: libraries/classes/Display/Results.php
 
+		-
+			message: "#^Parameter \\#1 \\$value of static method PhpMyAdmin\\\\Util\\:\\:formatNumber\\(\\) expects float\\|int\\|string, int\\|string\\|false given\\.$#"
+			count: 1
+			path: libraries/classes/Display/Results.php
+
 		-
 			message: "#^Parameter \\#2 \\$columnValue of method PhpMyAdmin\\\\Display\\\\Results\\:\\:getSpecialLinkUrl\\(\\) expects string, mixed given\\.$#"
 			count: 1
