Merge #18516 - Fix #18392 - Format query not working inside view modal

williamdes · williamdes · commit 7d10e2f87d95 · 2023-06-29T12:50:38.000+02:00
Fixes: #18392 Pull-request: #18516 Signed-off-by: William Desportes <williamdes@wdes.fr>
diff --git a/libraries/classes/Sql.php b/libraries/classes/Sql.php
@@ -995,6 +995,9 @@ private function getQueryResponseForNoResultsReturned(
 
         $response = ResponseRenderer::getInstance();
         $response->addJSON($extraData ?? []);
+        $header = $response->getHeader();
+        $scripts = $header->getScripts();
+        $scripts->addFile('sql.js');
 
         if (! $statementInfo->isSelect || isset($extraData['error'])) {
             return $queryMessage;
@@ -1024,10 +1027,6 @@ private function getQueryResponseForNoResultsReturned(
 
         $profilingChart = '';
         if ($profilingResults !== []) {
-            $header = $response->getHeader();
-            $scripts = $header->getScripts();
-            $scripts->addFile('sql.js');
-
             $profiling = $this->getDetailedProfilingStats($profilingResults);
             if ($profiling !== []) {
                 $profilingChart = $this->template->render('sql/profiling_chart', ['profiling' => $profiling]);
