Remove the AbstractTestCase::assertAllSelectsConsumed method

MauricioFauth · MauricioFauth · commit 72a69471e853 · 2022-07-11T16:38:37.000-03:00
Uses the DummyDbi method instead.

Signed-off-by: Maurício Meneghini Fauth &lt;mauricio@fauth.dev&gt;
diff --git a/test/classes/AbstractTestCase.php b/test/classes/AbstractTestCase.php
@@ -102,16 +102,6 @@ protected function setUp(): void
         Cache::purge();
     }
 
-    protected function assertAllSelectsConsumed(): void
-    {
-        $unUsedSelects = $this->dummyDbi->getUnUsedDatabaseSelects();
-        $this->assertSame(
-            [],
-            $unUsedSelects,
-            'Some database selects where not used !'
-        );
-    }
-
     protected function loadContainerBuilder(): void
     {
         $GLOBALS['containerBuilder'] = Core::getContainerBuilder();
diff --git a/test/classes/BookmarkTest.php b/test/classes/BookmarkTest.php
@@ -47,7 +47,7 @@ public function testGetList(): void
             'sakila'
         );
         $this->assertContainsOnlyInstancesOf(Bookmark::class, $actual);
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
     }
 
     /**
@@ -64,7 +64,7 @@ public function testGet(): void
                 '1'
             )
         );
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
     }
 
     /**
@@ -83,6 +83,6 @@ public function testSave(): void
         $this->assertNotFalse($bookmark);
         $this->dummyDbi->addSelectDb('phpmyadmin');
         $this->assertFalse($bookmark->save());
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
     }
 }
diff --git a/test/classes/Controllers/Import/ImportControllerTest.php b/test/classes/Controllers/Import/ImportControllerTest.php
@@ -58,7 +58,7 @@ public function testIndexParametrized(): void
         $this->dummyDbi->addSelectDb('pma_test');
         $this->dummyDbi->addSelectDb('pma_test');
         $importController();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $this->assertResponseWasSuccessfull();
 
         $this->assertStringContainsString(
diff --git a/test/classes/Controllers/NormalizationControllerTest.php b/test/classes/Controllers/NormalizationControllerTest.php
@@ -141,7 +141,7 @@ public function testCreateNewTables2NF(): void
         $normalizationController = $GLOBALS['containerBuilder']->get(NormalizationController::class);
         $this->dummyDbi->addSelectDb('my_db');
         $normalizationController();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
 
         $this->assertResponseWasSuccessfull();
 
@@ -179,7 +179,7 @@ public function testCreateNewTables3NF(): void
         $normalizationController = $GLOBALS['containerBuilder']->get(NormalizationController::class);
         $this->dummyDbi->addSelectDb('my_db');
         $normalizationController();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
 
         $this->assertResponseWasSuccessfull();
 
diff --git a/test/classes/Controllers/Server/BinlogControllerTest.php b/test/classes/Controllers/Server/BinlogControllerTest.php
@@ -48,7 +48,7 @@ public function testIndex(): void
         $_POST['pos'] = '3';
         $this->dummyDbi->addSelectDb('mysql');
         $controller();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $actual = $response->getHTMLResult();
 
         $this->assertStringContainsString('Select binary log to view', $actual);
diff --git a/test/classes/Controllers/Server/CollationsControllerTest.php b/test/classes/Controllers/Server/CollationsControllerTest.php
@@ -39,7 +39,7 @@ public function testIndexAction(): void
 
         $this->dummyDbi->addSelectDb('mysql');
         $controller();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $actual = $response->getHTMLResult();
 
         $this->assertStringContainsString('<div><strong>latin1</strong></div>', $actual);
diff --git a/test/classes/Controllers/Server/DatabasesControllerTest.php b/test/classes/Controllers/Server/DatabasesControllerTest.php
@@ -61,7 +61,7 @@ public function testIndexAction(): void
 
         $this->dummyDbi->addSelectDb('mysql');
         $controller();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $actual = $response->getHTMLResult();
 
         $this->assertStringContainsString('data-filter-row="SAKILA"', $actual);
@@ -98,7 +98,7 @@ public function testIndexAction(): void
 
         $this->dummyDbi->addSelectDb('mysql');
         $controller();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $actual = $response->getHTMLResult();
 
         $this->assertStringNotContainsString(__('Enable statistics'), $actual);
diff --git a/test/classes/Controllers/Server/EnginesControllerTest.php b/test/classes/Controllers/Server/EnginesControllerTest.php
@@ -39,7 +39,7 @@ public function testIndex(): void
 
         $this->dummyDbi->addSelectDb('mysql');
         $controller->__invoke();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
 
         $actual = $response->getHTMLResult();
 
diff --git a/test/classes/Controllers/Server/PluginsControllerTest.php b/test/classes/Controllers/Server/PluginsControllerTest.php
@@ -69,7 +69,7 @@ public function testIndex(): void
         $controller = new PluginsController($response, new Template(), new Plugins($dbi), $GLOBALS['dbi']);
         $this->dummyDbi->addSelectDb('mysql');
         $controller();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $actual = $response->getHTMLResult();
 
         //validate 1:Items
diff --git a/test/classes/Controllers/Server/ShowEngineControllerTest.php b/test/classes/Controllers/Server/ShowEngineControllerTest.php
@@ -42,7 +42,7 @@ public function testShowEngine(): void
             'page' => 'page',
         ]);
 
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $actual = $response->getHTMLResult();
 
         $enginePlugin = StorageEngine::getEngine('Pbxt');
diff --git a/test/classes/Controllers/Server/Status/Monitor/GeneralLogControllerTest.php b/test/classes/Controllers/Server/Status/Monitor/GeneralLogControllerTest.php
@@ -67,7 +67,7 @@ public function testGeneralLog(): void
 
         $this->dummyDbi->addSelectDb('mysql');
         $controller();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $ret = $response->getJSONResult();
 
         $resultRows = [
diff --git a/test/classes/Controllers/Server/Status/Monitor/LogVarsControllerTest.php b/test/classes/Controllers/Server/Status/Monitor/LogVarsControllerTest.php
@@ -60,7 +60,7 @@ public function testLogVars(): void
 
         $this->dummyDbi->addSelectDb('mysql');
         $controller();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $ret = $response->getJSONResult();
 
         $this->assertEquals($value, $ret['message']);
diff --git a/test/classes/Controllers/Server/Status/Monitor/SlowLogControllerTest.php b/test/classes/Controllers/Server/Status/Monitor/SlowLogControllerTest.php
@@ -54,7 +54,7 @@ public function testSlowLog(): void
 
         $this->dummyDbi->addSelectDb('mysql');
         $controller();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $ret = $response->getJSONResult();
 
         $resultRows = [
diff --git a/test/classes/Controllers/Server/Status/MonitorControllerTest.php b/test/classes/Controllers/Server/Status/MonitorControllerTest.php
@@ -50,7 +50,7 @@ public function testIndex(): void
 
         $this->dummyDbi->addSelectDb('mysql');
         $controller();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $html = $response->getHTMLResult();
 
         $this->assertStringContainsString('<div class="tabLinks row">', $html);
diff --git a/test/classes/Controllers/Server/Status/ProcessesControllerTest.php b/test/classes/Controllers/Server/Status/ProcessesControllerTest.php
@@ -50,7 +50,7 @@ public function testIndex(): void
 
         $this->dummyDbi->addSelectDb('mysql');
         $controller();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $html = $response->getHTMLResult();
 
         $this->assertStringContainsString(
@@ -82,7 +82,7 @@ public function testIndex(): void
 
         $this->dummyDbi->addSelectDb('mysql');
         $controller();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $html = $response->getHTMLResult();
 
         $this->assertStringContainsString('Truncate shown queries', $html);
@@ -95,7 +95,7 @@ public function testIndex(): void
 
         $this->dummyDbi->addSelectDb('mysql');
         $controller();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $html = $response->getHTMLResult();
 
         $this->assertStringContainsString('Host', $html);
diff --git a/test/classes/Controllers/Server/Status/QueriesControllerTest.php b/test/classes/Controllers/Server/Status/QueriesControllerTest.php
@@ -57,7 +57,7 @@ public function testIndex(): void
 
         $this->dummyDbi->addSelectDb('mysql');
         $controller();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $html = $response->getHTMLResult();
 
         $hourFactor = 3600 / $this->data->status['Uptime'];
diff --git a/test/classes/Controllers/Server/Status/StatusControllerTest.php b/test/classes/Controllers/Server/Status/StatusControllerTest.php
@@ -65,7 +65,7 @@ public function testIndex(): void
 
         $this->dummyDbi->addSelectDb('mysql');
         $controller();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $html = $response->getHTMLResult();
 
         $traffic = $bytesReceived + $bytesSent;
diff --git a/test/classes/Controllers/Server/Status/VariablesControllerTest.php b/test/classes/Controllers/Server/Status/VariablesControllerTest.php
@@ -43,7 +43,7 @@ public function testIndex(): void
 
         $this->dummyDbi->addSelectDb('mysql');
         $controller();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $html = $response->getHTMLResult();
 
         $this->assertStringContainsString('<div class="card mb-3" id="tableFilter">', $html);
diff --git a/test/classes/Controllers/Table/ReplaceControllerTest.php b/test/classes/Controllers/Table/ReplaceControllerTest.php
@@ -133,7 +133,7 @@ public function testReplace(): void
         $dummyDbi->addSelectDb('my_db');
         $replaceController($request);
         $output = $response->getHTMLResult();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $this->assertStringContainsString(
             'class="icon ic_s_success"> Showing rows 0 -  1 (2 total, Query took',
             $output
@@ -181,7 +181,7 @@ public function testIsInsertRow(): void
 
         $replaceController($request);
         $output = $response->getHTMLResult();
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $this->assertEquals(5, $GLOBALS['cfg']['InsertRows']);
         $this->assertStringContainsString(
             '<form id="continueForm" method="post" '
diff --git a/test/classes/Import/SimulateDmlTest.php b/test/classes/Import/SimulateDmlTest.php
@@ -37,7 +37,7 @@ public function testGetMatchedRows(string $sqlQuery, string $simulatedQuery): vo
             'sql_signature' => Core::signSqlQuery($simulatedQuery),
         ]);
 
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $this->assertEquals([
             'sql_query' => Generator::formatSql($sqlQuery),
             'matched_rows' => 2,
diff --git a/test/classes/Plugins/Export/ExportHtmlwordTest.php b/test/classes/Plugins/Export/ExportHtmlwordTest.php
@@ -633,7 +633,7 @@ public function testExportStructure(): void
                 'test'
             )
         );
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $result = ob_get_clean();
 
         $this->assertEquals(
@@ -685,7 +685,7 @@ public function testExportStructure(): void
                 'test'
             )
         );
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $result = ob_get_clean();
 
         $this->assertEquals(
diff --git a/test/classes/Plugins/Export/ExportOdtTest.php b/test/classes/Plugins/Export/ExportOdtTest.php
@@ -542,7 +542,7 @@ public function testGetTableDefStandIn(): void
             $this->object->getTableDefStandIn('test_db', 'test_table', "\n"),
             ''
         );
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
 
         $this->assertEquals(
             '<table:table table:name="test_table_data">'
@@ -796,7 +796,7 @@ public function testExportStructure(): void
                 'test'
             )
         );
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
 
         $this->assertEquals(
             '<text:h text:outline-level="2" text:style-name="Heading_2" text:is-list-header="true">'
@@ -870,7 +870,7 @@ public function testExportStructure(): void
                 'test'
             )
         );
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
 
         $this->assertEquals(
             '<text:h text:outline-level="2" text:style-name="Heading_2" text:is-list-header="true">'
@@ -912,7 +912,7 @@ public function testExportStructure(): void
                 'test'
             )
         );
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
 
         $this->assertEquals(
             '<text:h text:outline-level="2" text:style-name="Heading_2" text:is-list-header="true">'
diff --git a/test/classes/Plugins/Export/ExportTexytextTest.php b/test/classes/Plugins/Export/ExportTexytextTest.php
@@ -228,7 +228,7 @@ public function testGetTableDefStandIn(): void
     {
         $this->dummyDbi->addSelectDb('test_db');
         $result = $this->object->getTableDefStandIn('test_db', 'test_table', "\n");
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
 
         $this->assertEquals(
             '|------' . "\n"
@@ -373,7 +373,7 @@ public function testExportStructure(): void
                 'test'
             )
         );
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $result = ob_get_clean();
 
         $this->assertIsString($result);
@@ -424,7 +424,7 @@ public function testExportStructure(): void
                 'test'
             )
         );
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $result = ob_get_clean();
 
         $this->assertEquals(
@@ -451,7 +451,7 @@ public function testExportStructure(): void
                 'test'
             )
         );
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $result = ob_get_clean();
 
         $this->assertEquals(
diff --git a/test/classes/StorageEngineTest.php b/test/classes/StorageEngineTest.php
@@ -703,7 +703,7 @@ public function testGetMroongaLengths(): void
 
         $this->dummyDbi->addSelectDb('my_db');
         $lengths = StorageEngine::getMroongaLengths('my_db', 'idx_correo');
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
         $this->assertSame([4521984, 578126], $lengths);
 
         $this->dummyDbi->assertAllQueriesConsumed();
diff --git a/test/classes/TwoFactorTest.php b/test/classes/TwoFactorTest.php
@@ -40,7 +40,7 @@ protected function setUp(): void
 
     protected function tearDown(): void
     {
-        $this->assertAllSelectsConsumed();
+        $this->dummyDbi->assertAllSelectsConsumed();
     }
 
     private function initStorageConfigAndData(): void

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public function testGetList(): void`
`47`	`47`	`'sakila'`
`48`	`48`	`);`
`49`	`49`	`$this->assertContainsOnlyInstancesOf(Bookmark::class, $actual);`
`50`		`- $this->assertAllSelectsConsumed();`
	`50`	`+ $this->dummyDbi->assertAllSelectsConsumed();`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`/**`
`@@ -64,7 +64,7 @@ public function testGet(): void`
`64`	`64`	`'1'`
`65`	`65`	`)`
`66`	`66`	`);`
`67`		`- $this->assertAllSelectsConsumed();`
	`67`	`+ $this->dummyDbi->assertAllSelectsConsumed();`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`/**`
`@@ -83,6 +83,6 @@ public function testSave(): void`
`83`	`83`	`$this->assertNotFalse($bookmark);`
`84`	`84`	`$this->dummyDbi->addSelectDb('phpmyadmin');`
`85`	`85`	`$this->assertFalse($bookmark->save());`
`86`		`- $this->assertAllSelectsConsumed();`
	`86`	`+ $this->dummyDbi->assertAllSelectsConsumed();`
`87`	`87`	`}`
`88`	`88`	`}`