Merge pull request #19049 from kamil-tekiela/Fix-impossible-condition-from-#18630

MauricioFauth · web-flow · commit 6eb5253ef6aa · 2024-03-13T18:33:40.000-03:00
Fix impossible condition from #18630
diff --git a/src/Table/Search.php b/src/Table/Search.php
@@ -81,14 +81,12 @@ private function generateWhereClause(): string
             return ' WHERE ' . $_POST['customWhereClause'];
         }
 
-        // If there are no search criteria set or no unary criteria operators,
-        // return
         if (
-            ! isset($_POST['criteriaColumnOperators'])
-            || (
-                ! isset($_POST['criteriaValues'])
-                && ! isset($_POST['criteriaColumnOperators'])
-                && ! isset($_POST['geom_func'])
+            ! isset(
+                $_POST['criteriaColumnOperators'],
+                $_POST['criteriaValues'],
+                $_POST['criteriaColumnNames'],
+                $_POST['criteriaColumnTypes'],
             )
         ) {
             return '';
