Merge pull request #18040 from kamil-tekiela/Remove-old-!==-null-check

MauricioFauth · web-flow · commit 655ce1d59b29 · 2023-01-26T22:42:05.000-03:00
Remove old !== null check
diff --git a/libraries/classes/Util.php b/libraries/classes/Util.php
@@ -1581,21 +1581,16 @@ public static function expandUserString(
         if (str_contains($string, '@COLUMNS@')) {
             $columnsList = $GLOBALS['dbi']->getColumns($GLOBALS['db'], $GLOBALS['table']);
 
-            // sometimes the table no longer exists at this point
-            if ($columnsList !== null) {
-                $columnNames = [];
-                foreach ($columnsList as $column) {
-                    if ($escape !== null) {
-                        $columnNames[] = self::$escape($column['Field']);
-                    } else {
-                        $columnNames[] = $column['Field'];
-                    }
+            $columnNames = [];
+            foreach ($columnsList as $column) {
+                if ($escape !== null) {
+                    $columnNames[] = self::$escape($column['Field']);
+                } else {
+                    $columnNames[] = $column['Field'];
                 }
-
-                $replace['@COLUMNS@'] = implode(',', $columnNames);
-            } else {
-                $replace['@COLUMNS@'] = '*';
             }
+
+            $replace['@COLUMNS@'] = implode(',', $columnNames);
         }
 
         /* Do the replacement */
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -13895,9 +13895,6 @@
       <code>(int) $timestamp</code>
       <code>(int) $timestamp</code>
     </RedundantCastGivenDocblockType>
-    <RedundantCondition occurrences="1">
-      <code>$columnsList !== null</code>
-    </RedundantCondition>
   </file>
   <file src="libraries/classes/Utils/ForeignKey.php">
     <RedundantCastGivenDocblockType occurrences="1">
