Add missing native parameter type declarations

MauricioFauth · MauricioFauth · commit 646ba277945b · 2023-04-01T17:51:29.000-03:00
Signed-off-by: Maurício Meneghini Fauth &lt;mauricio@fauth.dev&gt;
diff --git a/examples/openid.php b/examples/openid.php
@@ -33,7 +33,7 @@
  *
  * @param string $contents Content to include in page
  */
-function Show_page($contents): void
+function Show_page(string $contents): void
 {
     header('Content-Type: text/html; charset=utf-8');
 
@@ -62,7 +62,7 @@ function Show_page($contents): void
  *
  * @param Exception $e Exception object
  */
-function Die_error($e): void
+function Die_error(Throwable $e): void
 {
     $contents = "<div class='relyingparty_results'>\n";
     $contents .= '<pre>' . htmlspecialchars($e->getMessage()) . "</pre>\n";
diff --git a/examples/signon-script.php b/examples/signon-script.php
@@ -20,7 +20,7 @@
  *
  * @return array<int,string>
  */
-function get_login_credentials($user): array
+function get_login_credentials(string $user): array
 {
     /* Optionally we can use passed username */
     if (! empty($user)) {
diff --git a/libraries/classes/Pdf.php b/libraries/classes/Pdf.php
@@ -130,7 +130,7 @@ public function _putpages(): void
      * @param string $errorMessage the error message
      */
     // phpcs:ignore PSR1.Methods.CamelCapsMethodName.NotCamelCaps
-    public function Error($errorMessage = ''): void
+    public function Error(mixed $errorMessage = ''): void
     {
         echo Message::error(
             __('Error while creating PDF:') . ' ' . $errorMessage,
diff --git a/libraries/classes/Plugins/Export/Helpers/Pdf.php b/libraries/classes/Plugins/Export/Helpers/Pdf.php
@@ -103,7 +103,7 @@ public function __construct(
      * @param bool      $addpage if true add a page, otherwise only return
      *                           the true/false state
      */
-    public function checkPageBreak($h = 0, $y = '', $addpage = true): bool
+    public function checkPageBreak(mixed $h = 0, mixed $y = '', mixed $addpage = true): bool
     {
         if (TCPDF_STATIC::empty_string($y)) {
             $y = $this->y;
@@ -296,7 +296,7 @@ public function morepagestable(int $lineheight = 8): void
      *
      * @param float $topMargin the margin
      */
-    public function setTopMargin($topMargin): void
+    public function setTopMargin(mixed $topMargin): void
     {
         $this->tMargin = $topMargin;
     }
diff --git a/phpcs.xml.dist b/phpcs.xml.dist
@@ -42,9 +42,6 @@
     <rule ref="SlevomatCodingStandard.Operators.DisallowEqualOperators">
         <severity>4</severity>
     </rule>
-    <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingNativeTypeHint">
-        <severity>4</severity>
-    </rule>
     <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingTraversableTypeHintSpecification">
         <severity>4</severity>
     </rule>

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@`
`33`	`33`	`*`
`34`	`34`	`* @param string $contents Content to include in page`
`35`	`35`	`*/`
`36`		`-function Show_page($contents): void`
	`36`	`+function Show_page(string $contents): void`
`37`	`37`	`{`
`38`	`38`	`header('Content-Type: text/html; charset=utf-8');`
`39`	`39`
`@@ -62,7 +62,7 @@ function Show_page($contents): void`
`62`	`62`	`*`
`63`	`63`	`* @param Exception $e Exception object`
`64`	`64`	`*/`
`65`		`-function Die_error($e): void`
	`65`	`+function Die_error(Throwable $e): void`
`66`	`66`	`{`
`67`	`67`	`$contents = "<div class='relyingparty_results'>\n";`
`68`	`68`	`$contents .= '<pre>' . htmlspecialchars($e->getMessage()) . "</pre>\n";`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`*`
`21`	`21`	`* @return array<int,string>`
`22`	`22`	`*/`
`23`		`-function get_login_credentials($user): array`
	`23`	`+function get_login_credentials(string $user): array`
`24`	`24`	`{`
`25`	`25`	`/* Optionally we can use passed username */`
`26`	`26`	`if (! empty($user)) {`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ public function _putpages(): void`
`130`	`130`	`* @param string $errorMessage the error message`
`131`	`131`	`*/`
`132`	`132`	`// phpcs:ignore PSR1.Methods.CamelCapsMethodName.NotCamelCaps`
`133`		`- public function Error($errorMessage = ''): void`
	`133`	`+ public function Error(mixed $errorMessage = ''): void`
`134`	`134`	`{`
`135`	`135`	`echo Message::error(`
`136`	`136`	`__('Error while creating PDF:') . ' ' . $errorMessage,`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ public function __construct(`
`103`	`103`	`* @param bool $addpage if true add a page, otherwise only return`
`104`	`104`	`* the true/false state`
`105`	`105`	`*/`
`106`		`- public function checkPageBreak($h = 0, $y = '', $addpage = true): bool`
	`106`	`+ public function checkPageBreak(mixed $h = 0, mixed $y = '', mixed $addpage = true): bool`
`107`	`107`	`{`
`108`	`108`	`if (TCPDF_STATIC::empty_string($y)) {`
`109`	`109`	`$y = $this->y;`
`@@ -296,7 +296,7 @@ public function morepagestable(int $lineheight = 8): void`
`296`	`296`	`*`
`297`	`297`	`* @param float $topMargin the margin`
`298`	`298`	`*/`
`299`		`- public function setTopMargin($topMargin): void`
	`299`	`+ public function setTopMargin(mixed $topMargin): void`
`300`	`300`	`{`
`301`	`301`	`$this->tMargin = $topMargin;`
`302`	`302`	`}`