Merge pull request #17759 from kamil-tekiela/FieldMetadata-test

MauricioFauth · web-flow · commit 599ba97c79c8 · 2022-10-10T04:53:25.000-03:00
Remove redundant tests
diff --git a/test/classes/FieldMetadataTest.php b/test/classes/FieldMetadataTest.php
@@ -35,7 +35,7 @@ public function testEmptyConstruct(): void
         $this->assertFalse($fm->isBlob());
     }
 
-    public function testIsBinaryStdClassAsObject(): void
+    public function testIsBinary(): void
     {
         $obj = new stdClass();
         $obj->charsetnr = 63;
@@ -53,41 +53,6 @@ public function testIsBinaryStdClassAsObject(): void
         $this->assertFalse($fm->isBlob());
     }
 
-    public function testIsBinaryCustomClassAsObject(): void
-    {
-        $obj = new stdClass();
-        $obj->charsetnr = 63;
-        $objmd = new FieldMetadata(MYSQLI_TYPE_STRING, 0, $obj);
-        $fm = new FieldMetadata(MYSQLI_TYPE_STRING, 0, $objmd);
-        $this->assertTrue($fm->isBinary());
-        $this->assertFalse($fm->isEnum());
-        $this->assertFalse($fm->isUniqueKey());
-        $this->assertFalse($fm->isUnsigned());
-        $this->assertFalse($fm->isZerofill());
-        $this->assertFalse($fm->isSet());
-        $this->assertFalse($fm->isNotNull());
-        $this->assertFalse($fm->isPrimaryKey());
-        $this->assertFalse($fm->isMultipleKey());
-        $this->assertFalse($fm->isNumeric());
-        $this->assertFalse($fm->isBlob());
-    }
-
-    public function testIsBinary(): void
-    {
-        $fm = new FieldMetadata(MYSQLI_TYPE_STRING, 0, (object) ['charsetnr' => 63]);
-        $this->assertTrue($fm->isBinary());
-        $this->assertFalse($fm->isEnum());
-        $this->assertFalse($fm->isUniqueKey());
-        $this->assertFalse($fm->isUnsigned());
-        $this->assertFalse($fm->isZerofill());
-        $this->assertFalse($fm->isSet());
-        $this->assertFalse($fm->isNotNull());
-        $this->assertFalse($fm->isPrimaryKey());
-        $this->assertFalse($fm->isMultipleKey());
-        $this->assertFalse($fm->isNumeric());
-        $this->assertFalse($fm->isBlob());
-    }
-
     public function testIsNumeric(): void
     {
         $fm = new FieldMetadata(MYSQLI_TYPE_INT24, MYSQLI_NUM_FLAG, (object) []);
