Merge branch 'QA_5_2'

williamdes · williamdes · commit 57a5df9ee5a8 · 2022-06-11T14:38:48.000+02:00
Also merges pull-request: #17591 Pull-request: #17591 Signed-off-by: William Desportes <williamdes@wdes.fr>
diff --git a/.github/workflows/daily-snapshots.yml b/.github/workflows/daily-snapshots.yml
@@ -9,6 +9,9 @@ on:
   schedule:
     - cron: '0 0 * * *'
 
+permissions:
+  contents: read
+
 jobs:
   generate-snapshots:
     name: Generate ${{ matrix.version }} snapshots
diff --git a/.github/workflows/lint-and-analyse-php.yml b/.github/workflows/lint-and-analyse-php.yml
@@ -8,6 +8,9 @@ on:
       - master
       - QA_**
 
+permissions:
+  contents: read
+
 jobs:
   lint-node:
     runs-on: ubuntu-latest
diff --git a/.github/workflows/lint-docs.yml b/.github/workflows/lint-docs.yml
@@ -8,6 +8,9 @@ on:
       - master
       - QA_**
 
+permissions:
+  contents: read
+
 jobs:
   lint-docs:
     runs-on: ubuntu-latest
diff --git a/.github/workflows/lock.yml b/.github/workflows/lock.yml
@@ -4,8 +4,13 @@ on:
   schedule:
     - cron: '0 0 * * *'
 
+permissions:
+  contents: read
+
 jobs:
   lock:
+    permissions:
+      issues: write  # for dessant/lock-threads to lock issues
     runs-on: ubuntu-latest
     steps:
       - uses: dessant/lock-threads@v2
diff --git a/.github/workflows/mutation-tests.yml b/.github/workflows/mutation-tests.yml
@@ -6,6 +6,9 @@ on:
   pull_request:
     branches: [master]
 
+permissions:
+  contents: read
+
 jobs:
   tests:
     name: Mutation tests with PHP ${{ matrix.php-version }}
diff --git a/.github/workflows/other-tools.yml b/.github/workflows/other-tools.yml
@@ -8,6 +8,9 @@ on:
       - master
       - QA_**
 
+permissions:
+  contents: read
+
 jobs:
   build-documentation:
     runs-on: ubuntu-latest
diff --git a/.github/workflows/test-selenium.yml b/.github/workflows/test-selenium.yml
@@ -8,6 +8,9 @@ on:
       - master
       - QA_**
 
+permissions:
+  contents: read
+
 env:
   php-version: "8.1"
 
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -8,6 +8,9 @@ on:
       - master
       - QA_**
 
+permissions:
+  contents: read
+
 jobs:
   multi-arch-tests-php:
     name: Test on PHP ${{ matrix.php-version }} (${{ matrix.arch }})
diff --git a/.github/workflows/update-po.yml b/.github/workflows/update-po.yml
@@ -5,8 +5,13 @@ on:
   schedule:
     - cron: '0 0 * * 0'
 
+permissions:
+  contents: read
+
 jobs:
   update-po:
+    permissions:
+      contents: write  # for Git to git push
     name: Update po files
     runs-on: ubuntu-latest
     # Source: https://github.community/t/do-not-run-cron-workflows-in-forks/17636/2?u=williamdes
diff --git a/test/classes/Utils/SessionCacheTest.php b/test/classes/Utils/SessionCacheTest.php
@@ -62,9 +62,13 @@ public function testHas(): void
 
         SessionCache::set('test_data', 5);
         SessionCache::set('test_data_2', 5);
+        SessionCache::set('test_data_3', false);
+        SessionCache::set('test_data_4', true);
 
         $this->assertTrue(SessionCache::has('test_data'));
         $this->assertTrue(SessionCache::has('test_data_2'));
+        $this->assertTrue(SessionCache::has('test_data_3'));
+        $this->assertTrue(SessionCache::has('test_data_4'));
         $this->assertFalse(SessionCache::has('fake_data_2'));
     }
 
