Merge pull request #19491 from kamil-tekiela/ThemeManager-small-changes

MauricioFauth · web-flow · commit 47652b11f454 · 2025-01-02T17:39:42.000-03:00
ThemeManager small changes
diff --git a/src/Theme/ThemeManager.php b/src/Theme/ThemeManager.php
@@ -116,9 +116,6 @@ public function setActiveTheme(string|null $theme): bool
         $this->activeTheme = $theme;
         $this->theme = $this->themes[$theme];
 
-        // need to set later
-        //$this->setThemeCookie();
-
         return true;
     }
 
@@ -230,7 +227,14 @@ public function checkTheme(string|null $theme): bool
         return array_key_exists($theme ?? '', $this->themes);
     }
 
-    /** @return mixed[] */
+    /** @return array{
+     *   id: string,
+     *   name: string,
+     *   version: string,
+     *   is_active: bool,
+     *   color_mode: string,
+     *   color_modes: array<string|int, string>
+     * }[] $themes */
     public function getThemesArray(): array
     {
         $themes = [];
diff --git a/tests/unit/Theme/ThemeManagerTest.php b/tests/unit/Theme/ThemeManagerTest.php
@@ -54,11 +54,6 @@ public function testGetThemesArray(): void
         $tm->initializeTheme();
         $themes = $tm->getThemesArray();
         self::assertArrayHasKey(0, $themes);
-        self::assertIsArray($themes[0]);
-        self::assertArrayHasKey('id', $themes[0]);
-        self::assertArrayHasKey('name', $themes[0]);
-        self::assertArrayHasKey('version', $themes[0]);
-        self::assertArrayHasKey('is_active', $themes[0]);
     }
 
     /**
