Merge #19978 - Convert false links into buttons

williamdes · williamdes · commit 3e20f101f705 · 2025-12-07T22:55:23.000+01:00
Pull-request: #19978 Signed-off-by: William Desportes <williamdes@wdes.fr>
diff --git a/resources/js/table/find_replace.ts b/resources/js/table/find_replace.ts
@@ -15,7 +15,7 @@ AJAX.registerTeardown('table/find_replace.js', function () {
  * Bind events
  */
 AJAX.registerOnload('table/find_replace.js', function () {
-    $('<div id="toggle_find_div"><a id="toggle_find"></a></div>')
+    $('<div id="toggle_find_div"><button class="btn btn-sm btn-secondary" type="button" id="toggle_find"></button></div>')
         .insertAfter('#find_replace_form')
         .hide();
 
diff --git a/resources/js/table/select.ts b/resources/js/table/select.ts
@@ -68,7 +68,7 @@ AJAX.registerOnload('table/select.js', function () {
      * Prepare a div containing a link, otherwise it's incorrectly displayed
      * after a couple of clicks
      */
-    $('<div id="togglesearchformdiv"><a id="togglesearchformlink"></a></div>')
+    $('<div id="togglesearchformdiv"><button class="btn btn-sm btn-secondary" type="button" id="togglesearchformlink"></button></div>')
         .insertAfter('#tbl_search_form')
         // don't show it until we have results on-screen
         .hide();
diff --git a/resources/js/table/zoom_search.ts b/resources/js/table/zoom_search.ts
@@ -263,7 +263,7 @@ AJAX.registerOnload('table/zoom_search.js', function () {
      ** Prepare a div containing a link, otherwise it's incorrectly displayed
      ** after a couple of clicks
      **/
-    $('<div id="togglesearchformdiv"><a id="togglesearchformlink"></a></div>')
+    $('<div id="togglesearchformdiv"><button class="btn btn-sm btn-secondary" type="button" id="togglesearchformlink"></button></div>')
         .insertAfter('#zoom_search_form')
         // don't show it until we have results on-screen
         .hide();
