Skip to content

Commit 3b4b4e2

Browse files
committed
Fix tests workflow for PSR7 libraries
Ref: 37bd7d9 Signed-off-by: William Desportes <williamdes@wdes.fr>
1 parent 37bd7d9 commit 3b4b4e2

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

.github/workflows/tests.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -191,15 +191,19 @@ jobs:
191191
coverage-reports: build/logs/clover.xml
192192

193193
test-php-psr7-implementations:
194-
name: Test on PHP (+ psr7-${{ matrix.psr-7-library }}) ${{ matrix.php-version }} and ${{ matrix.os }}
194+
name: Test on PHP ${{ matrix.php-version }} (+ psr7-${{ matrix.psr-7-library }})
195195
runs-on: ${{ matrix.os }}
196196
strategy:
197197
fail-fast: false
198198
matrix:
199-
php-version: ['7.3']
199+
php-version: ['7.2']
200200
os: [ubuntu-latest]
201201
php-extensions: ['mbstring, iconv, mysqli, zip, bz2']
202-
psr-7-library: ['guzzlehttp/psr7', 'nyholm/psr7', 'laminas/laminas-diactoros']
202+
psr-7-library: ['guzzlehttp/psr7']
203+
include:
204+
- {psr-7-library: 'laminas/laminas-diactoros', php-version: '7.4'}
205+
# https://github.com/slimphp/Slim-Psr7/issues/284
206+
- {psr-7-library: 'slim/psr7', php-version: '7.3'}
203207
steps:
204208
- name: Checkout code
205209
uses: actions/checkout@v3
@@ -226,7 +230,7 @@ jobs:
226230
dependency-versions: highest
227231

228232
- name: Remove default PSR-7 implementation
229-
run: composer remove slim/psr7
233+
run: composer remove nyholm/psr7
230234

231235
- name: Add PSR-7 implementation
232236
run: composer require ${{ matrix.psr-7-library }}

0 commit comments

Comments
 (0)