Skip to content

Commit 38f42da

Browse files
Merge pull request #19470 from kamil-tekiela/getColumnsFull
Remove DatabaseInterface::getColumnsFull()
2 parents 75e0042 + 821bb81 commit 38f42da

12 files changed

Lines changed: 28 additions & 507 deletions

File tree

phpstan-baseline.neon

Lines changed: 3 additions & 243 deletions
Original file line numberDiff line numberDiff line change
@@ -1614,18 +1614,6 @@ parameters:
16141614
count: 1
16151615
path: src/ConfigStorage/Relation.php
16161616

1617-
-
1618-
message: '#^Cannot access offset ''COLUMN_NAME'' on mixed\.$#'
1619-
identifier: offsetAccess.nonOffsetAccessible
1620-
count: 1
1621-
path: src/ConfigStorage/Relation.php
1622-
1623-
-
1624-
message: '#^Cannot access offset ''DATA_TYPE'' on mixed\.$#'
1625-
identifier: offsetAccess.nonOffsetAccessible
1626-
count: 1
1627-
path: src/ConfigStorage/Relation.php
1628-
16291617
-
16301618
message: '#^Cannot cast mixed to string\.$#'
16311619
identifier: cast.string
@@ -1662,12 +1650,6 @@ parameters:
16621650
count: 1
16631651
path: src/ConfigStorage/Relation.php
16641652

1665-
-
1666-
message: '#^Method PhpMyAdmin\\ConfigStorage\\Relation\:\:getDisplayField\(\) should return string but returns mixed\.$#'
1667-
identifier: return.type
1668-
count: 1
1669-
path: src/ConfigStorage/Relation.php
1670-
16711653
-
16721654
message: '#^Method PhpMyAdmin\\ConfigStorage\\Relation\:\:getTableReplacementNames\(\) should return array\<string, string\> but returns array\<string, array\<array\<string\>\|bool\|int\|string\>\|int\<1, max\>\|string\|true\>\.$#'
16731655
identifier: return.type
@@ -1873,7 +1855,7 @@ parameters:
18731855
path: src/ConfigStorage/Relation.php
18741856

18751857
-
1876-
message: '#^Parameter \#1 \$type of method PhpMyAdmin\\Types\:\:getTypeClass\(\) expects string, mixed given\.$#'
1858+
message: '#^Parameter \#1 \$type of method PhpMyAdmin\\Types\:\:getTypeClass\(\) expects string, string\|null given\.$#'
18771859
identifier: argument.type
18781860
count: 1
18791861
path: src/ConfigStorage/Relation.php
@@ -6681,18 +6663,6 @@ parameters:
66816663
count: 1
66826664
path: src/Dbal/DatabaseInterface.php
66836665

6684-
-
6685-
message: '#^Foreach overwrites \$database with its value variable\.$#'
6686-
identifier: foreach.valueOverwrite
6687-
count: 1
6688-
path: src/Dbal/DatabaseInterface.php
6689-
6690-
-
6691-
message: '#^Foreach overwrites \$table with its value variable\.$#'
6692-
identifier: foreach.valueOverwrite
6693-
count: 1
6694-
path: src/Dbal/DatabaseInterface.php
6695-
66966666
-
66976667
message: '#^Loose comparison via "\=\=" is not allowed\.$#'
66986668
identifier: equal.notAllowed
@@ -6705,12 +6675,6 @@ parameters:
67056675
count: 1
67066676
path: src/Dbal/DatabaseInterface.php
67076677

6708-
-
6709-
message: '#^Method PhpMyAdmin\\Dbal\\DatabaseInterface\:\:getColumnsFull\(\) should return array\<mixed\> but returns mixed\.$#'
6710-
identifier: return.type
6711-
count: 1
6712-
path: src/Dbal/DatabaseInterface.php
6713-
67146678
-
67156679
message: '#^Method PhpMyAdmin\\Dbal\\DatabaseInterface\:\:getCurrentRoles\(\) should return list\<string\> but returns mixed\.$#'
67166680
identifier: return.type
@@ -12093,12 +12057,6 @@ parameters:
1209312057
count: 1
1209412058
path: src/Plugins/Export/ExportSql.php
1209512059

12096-
-
12097-
message: '#^Binary operation "\." between non\-falsy\-string and mixed results in an error\.$#'
12098-
identifier: binaryOp.invalid
12099-
count: 1
12100-
path: src/Plugins/Export/ExportSql.php
12101-
1210212060
-
1210312061
message: '''
1210412062
#^Call to deprecated method getInstance\(\) of class PhpMyAdmin\\Config\:
@@ -12123,12 +12081,6 @@ parameters:
1212312081
count: 2
1212412082
path: src/Plugins/Export/ExportSql.php
1212512083

12126-
-
12127-
message: '#^Cannot access offset ''Type'' on mixed\.$#'
12128-
identifier: offsetAccess.nonOffsetAccessible
12129-
count: 1
12130-
path: src/Plugins/Export/ExportSql.php
12131-
1213212084
-
1213312085
message: '#^Cannot access offset ''alias'' on mixed\.$#'
1213412086
identifier: offsetAccess.nonOffsetAccessible
@@ -12150,7 +12102,7 @@ parameters:
1215012102
-
1215112103
message: '#^Cannot access offset \(int\|string\) on mixed\.$#'
1215212104
identifier: offsetAccess.nonOffsetAccessible
12153-
count: 2
12105+
count: 1
1215412106
path: src/Plugins/Export/ExportSql.php
1215512107

1215612108
-
@@ -12162,7 +12114,7 @@ parameters:
1216212114
-
1216312115
message: '#^Cannot access offset string on mixed\.$#'
1216412116
identifier: offsetAccess.nonOffsetAccessible
12165-
count: 10
12117+
count: 11
1216612118
path: src/Plugins/Export/ExportSql.php
1216712119

1216812120
-
@@ -14568,174 +14520,6 @@ parameters:
1456814520
count: 1
1456914521
path: src/Properties/Options/OptionsPropertyGroup.php
1457014522

14571-
-
14572-
message: '#^Cannot access offset ''CHARACTER_MAXIMUM_LENGTH'' on mixed\.$#'
14573-
identifier: offsetAccess.nonOffsetAccessible
14574-
count: 1
14575-
path: src/Query/Compatibility.php
14576-
14577-
-
14578-
message: '#^Cannot access offset ''CHARACTER_OCTET_LENGTH'' on mixed\.$#'
14579-
identifier: offsetAccess.nonOffsetAccessible
14580-
count: 1
14581-
path: src/Query/Compatibility.php
14582-
14583-
-
14584-
message: '#^Cannot access offset ''CHARACTER_SET_NAME'' on mixed\.$#'
14585-
identifier: offsetAccess.nonOffsetAccessible
14586-
count: 1
14587-
path: src/Query/Compatibility.php
14588-
14589-
-
14590-
message: '#^Cannot access offset ''COLLATION_NAME'' on mixed\.$#'
14591-
identifier: offsetAccess.nonOffsetAccessible
14592-
count: 2
14593-
path: src/Query/Compatibility.php
14594-
14595-
-
14596-
message: '#^Cannot access offset ''COLUMN_COMMENT'' on mixed\.$#'
14597-
identifier: offsetAccess.nonOffsetAccessible
14598-
count: 1
14599-
path: src/Query/Compatibility.php
14600-
14601-
-
14602-
message: '#^Cannot access offset ''COLUMN_DEFAULT'' on mixed\.$#'
14603-
identifier: offsetAccess.nonOffsetAccessible
14604-
count: 1
14605-
path: src/Query/Compatibility.php
14606-
14607-
-
14608-
message: '#^Cannot access offset ''COLUMN_KEY'' on mixed\.$#'
14609-
identifier: offsetAccess.nonOffsetAccessible
14610-
count: 1
14611-
path: src/Query/Compatibility.php
14612-
14613-
-
14614-
message: '#^Cannot access offset ''COLUMN_NAME'' on mixed\.$#'
14615-
identifier: offsetAccess.nonOffsetAccessible
14616-
count: 1
14617-
path: src/Query/Compatibility.php
14618-
14619-
-
14620-
message: '#^Cannot access offset ''COLUMN_TYPE'' on mixed\.$#'
14621-
identifier: offsetAccess.nonOffsetAccessible
14622-
count: 2
14623-
path: src/Query/Compatibility.php
14624-
14625-
-
14626-
message: '#^Cannot access offset ''Collation'' on mixed\.$#'
14627-
identifier: offsetAccess.nonOffsetAccessible
14628-
count: 1
14629-
path: src/Query/Compatibility.php
14630-
14631-
-
14632-
message: '#^Cannot access offset ''Comment'' on mixed\.$#'
14633-
identifier: offsetAccess.nonOffsetAccessible
14634-
count: 1
14635-
path: src/Query/Compatibility.php
14636-
14637-
-
14638-
message: '#^Cannot access offset ''DATA_TYPE'' on mixed\.$#'
14639-
identifier: offsetAccess.nonOffsetAccessible
14640-
count: 1
14641-
path: src/Query/Compatibility.php
14642-
14643-
-
14644-
message: '#^Cannot access offset ''Default'' on mixed\.$#'
14645-
identifier: offsetAccess.nonOffsetAccessible
14646-
count: 1
14647-
path: src/Query/Compatibility.php
14648-
14649-
-
14650-
message: '#^Cannot access offset ''EXTRA'' on mixed\.$#'
14651-
identifier: offsetAccess.nonOffsetAccessible
14652-
count: 1
14653-
path: src/Query/Compatibility.php
14654-
14655-
-
14656-
message: '#^Cannot access offset ''Extra'' on mixed\.$#'
14657-
identifier: offsetAccess.nonOffsetAccessible
14658-
count: 1
14659-
path: src/Query/Compatibility.php
14660-
14661-
-
14662-
message: '#^Cannot access offset ''Field'' on mixed\.$#'
14663-
identifier: offsetAccess.nonOffsetAccessible
14664-
count: 1
14665-
path: src/Query/Compatibility.php
14666-
14667-
-
14668-
message: '#^Cannot access offset ''IS_NULLABLE'' on mixed\.$#'
14669-
identifier: offsetAccess.nonOffsetAccessible
14670-
count: 1
14671-
path: src/Query/Compatibility.php
14672-
14673-
-
14674-
message: '#^Cannot access offset ''Key'' on mixed\.$#'
14675-
identifier: offsetAccess.nonOffsetAccessible
14676-
count: 1
14677-
path: src/Query/Compatibility.php
14678-
14679-
-
14680-
message: '#^Cannot access offset ''NUMERIC_PRECISION'' on mixed\.$#'
14681-
identifier: offsetAccess.nonOffsetAccessible
14682-
count: 1
14683-
path: src/Query/Compatibility.php
14684-
14685-
-
14686-
message: '#^Cannot access offset ''NUMERIC_SCALE'' on mixed\.$#'
14687-
identifier: offsetAccess.nonOffsetAccessible
14688-
count: 1
14689-
path: src/Query/Compatibility.php
14690-
14691-
-
14692-
message: '#^Cannot access offset ''Null'' on mixed\.$#'
14693-
identifier: offsetAccess.nonOffsetAccessible
14694-
count: 1
14695-
path: src/Query/Compatibility.php
14696-
14697-
-
14698-
message: '#^Cannot access offset ''ORDINAL_POSITION'' on mixed\.$#'
14699-
identifier: offsetAccess.nonOffsetAccessible
14700-
count: 1
14701-
path: src/Query/Compatibility.php
14702-
14703-
-
14704-
message: '#^Cannot access offset ''PRIVILEGES'' on mixed\.$#'
14705-
identifier: offsetAccess.nonOffsetAccessible
14706-
count: 1
14707-
path: src/Query/Compatibility.php
14708-
14709-
-
14710-
message: '#^Cannot access offset ''Privileges'' on mixed\.$#'
14711-
identifier: offsetAccess.nonOffsetAccessible
14712-
count: 1
14713-
path: src/Query/Compatibility.php
14714-
14715-
-
14716-
message: '#^Cannot access offset ''TABLE_CATALOG'' on mixed\.$#'
14717-
identifier: offsetAccess.nonOffsetAccessible
14718-
count: 1
14719-
path: src/Query/Compatibility.php
14720-
14721-
-
14722-
message: '#^Cannot access offset ''TABLE_NAME'' on mixed\.$#'
14723-
identifier: offsetAccess.nonOffsetAccessible
14724-
count: 1
14725-
path: src/Query/Compatibility.php
14726-
14727-
-
14728-
message: '#^Cannot access offset ''TABLE_SCHEMA'' on mixed\.$#'
14729-
identifier: offsetAccess.nonOffsetAccessible
14730-
count: 1
14731-
path: src/Query/Compatibility.php
14732-
14733-
-
14734-
message: '#^Cannot access offset ''Type'' on mixed\.$#'
14735-
identifier: offsetAccess.nonOffsetAccessible
14736-
count: 1
14737-
path: src/Query/Compatibility.php
14738-
1473914523
-
1474014524
message: '#^Loose comparison via "\=\=" is not allowed\.$#'
1474114525
identifier: equal.notAllowed
@@ -16701,18 +16485,6 @@ parameters:
1670116485
count: 2
1670216486
path: src/Table/Table.php
1670316487

16704-
-
16705-
message: '#^Cannot access offset ''Field'' on mixed\.$#'
16706-
identifier: offsetAccess.nonOffsetAccessible
16707-
count: 2
16708-
path: src/Table/Table.php
16709-
16710-
-
16711-
message: '#^Cannot access offset ''Type'' on mixed\.$#'
16712-
identifier: offsetAccess.nonOffsetAccessible
16713-
count: 2
16714-
path: src/Table/Table.php
16715-
1671616488
-
1671716489
message: '#^Cannot access offset ''foreign_db'' on mixed\.$#'
1671816490
identifier: offsetAccess.nonOffsetAccessible
@@ -16797,12 +16569,6 @@ parameters:
1679716569
count: 1
1679816570
path: src/Table/Table.php
1679916571

16800-
-
16801-
message: '#^Method PhpMyAdmin\\Table\\Table\:\:getNameAndTypeOfTheColumns\(\) should return array\<string, string\> but returns array\.$#'
16802-
identifier: return.type
16803-
count: 1
16804-
path: src/Table/Table.php
16805-
1680616572
-
1680716573
message: '#^Method PhpMyAdmin\\Table\\Table\:\:getUiPrefsFromDb\(\) should return array\<mixed\> but returns mixed\.$#'
1680816574
identifier: return.type
@@ -16875,12 +16641,6 @@ parameters:
1687516641
count: 1
1687616642
path: src/Table/Table.php
1687716643

16878-
-
16879-
message: '#^Parameter \#2 \$subject of function preg_match expects string, mixed given\.$#'
16880-
identifier: argument.type
16881-
count: 1
16882-
path: src/Table/Table.php
16883-
1688416644
-
1688516645
message: '#^Parameter \#3 \$foreignDb of method PhpMyAdmin\\Table\\Table\:\:getSQLToCreateForeignKey\(\) expects string, string\|null given\.$#'
1688616646
identifier: argument.type

0 commit comments

Comments
 (0)