Add more tests for LintController

MauricioFauth · MauricioFauth · commit 37d269ce88ec · 2022-04-07T16:47:50.000-03:00
Signed-off-by: Maurício Meneghini Fauth &lt;mauricio@fauth.dev&gt;
diff --git a/test/classes/Controllers/LintControllerTest.php b/test/classes/Controllers/LintControllerTest.php
@@ -16,13 +16,33 @@
  */
 class LintControllerTest extends AbstractTestCase
 {
-    public function testInvoke(): void
+    public function testWithoutParams(): void
     {
-        $_POST['sql_query'] = 'SELECT * FROM `actor` WHEREE `actor_id` = 1;';
+        $_POST = [];
+
+        $this->getLintController()();
+
+        $output = $this->getActualOutputForAssertion();
+        $this->assertJson($output);
+        $this->assertJsonStringEqualsJsonString('[]', $output);
+    }
+
+    public function testWithoutSqlErrors(): void
+    {
+        $_POST['sql_query'] = 'SELECT * FROM `actor` WHERE `actor_id` = 1;';
 
-        (new LintController(new ResponseRenderer(), new Template()))();
+        $this->getLintController()();
 
-        $expectedJson = [
+        $output = $this->getActualOutputForAssertion();
+        $this->assertJson($output);
+        $this->assertJsonStringEqualsJsonString('[]', $output);
+    }
+
+    public function testWithSqlErrors(): void
+    {
+        $_POST['sql_query'] = 'SELECT * FROM `actor` WHEREE `actor_id` = 1;';
+
+        $expectedJson = json_encode([
             [
                 'message' => 'An alias was previously found. (near <code>`actor_id`</code>)',
                 'fromLine' => 0,
@@ -55,10 +75,18 @@ public function testInvoke(): void
                 'toColumn' => 43,
                 'severity' => 'error',
             ],
-        ];
+        ]);
+        $this->assertNotFalse($expectedJson);
+
+        $this->getLintController()();
 
         $output = $this->getActualOutputForAssertion();
         $this->assertJson($output);
-        $this->assertJsonStringEqualsJsonString(json_encode($expectedJson), $output);
+        $this->assertJsonStringEqualsJsonString($expectedJson, $output);
+    }
+
+    private function getLintController(): LintController
+    {
+        return new LintController(new ResponseRenderer(), new Template());
     }
 }
