Adding inputmode numeric to integer fields (#17753)

greew · web-flow · commit 23995b3c7384 · 2022-10-09T15:26:32.000-03:00
* Adding inputmode numeric to integer fields To easier use phpMyAdmin on touch devices with virtual keyboards, adding the inputmode ensures that the correct virtual keyboard is shown per default when focusing the field. See https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode for more information. Related to #17745. Signed-off-by: Jesper Skytte <jesper@skytte.it>
diff --git a/libraries/classes/InsertEdit.php b/libraries/classes/InsertEdit.php
@@ -694,7 +694,8 @@ private function getHtmlInput(
         }
 
         $inputMinMax = '';
-        if (in_array($column['True_Type'], $this->dbi->types->getIntegerTypes())) {
+        $isInteger = in_array($column['True_Type'], $this->dbi->types->getIntegerTypes());
+        if ($isInteger) {
             $extractedColumnspec = Util::extractColumnSpec($column['Type']);
             $isUnsigned = $extractedColumnspec['unsigned'];
             $minMaxValues = $this->dbi->types->getIntegerRange($column['True_Type'], ! $isUnsigned);
@@ -716,6 +717,7 @@ private function getHtmlInput(
             . ' data-type="' . $dataType . '"'
             . ' class="' . $theClass . '" ' . $onChangeClause
             . ' tabindex="' . ($tabindex + $tabindexForValue) . '"'
+            . ($isInteger ? ' inputmode="numeric"' : '')
             . ' id="field_' . $idindex . '_3">';
     }
 
diff --git a/test/classes/Controllers/Table/ChangeControllerTest.php b/test/classes/Controllers/Table/ChangeControllerTest.php
@@ -58,7 +58,7 @@ public function testChangeController(): void
             . ' size="4" min="-2147483648" max="2147483647" data-type="INT" class="textfield"'
             . ' onchange="return'
             . ' verificationsAfterFieldChange(\'b80bb7740288fda1f201890375a60c8f\', \'0\',\'int(11)\')"'
-            . ' tabindex="1" id="field_1_3"><input type="hidden"'
+            . ' tabindex="1" inputmode="numeric" id="field_1_3"><input type="hidden"'
             . ' name="auto_increment[multi_edit][0][b80bb7740288fda1f201890375a60c8f]" value="1">',
             $actual
         );
diff --git a/test/classes/InsertEditTest.php b/test/classes/InsertEditTest.php
@@ -1052,6 +1052,33 @@ public function testGetHTMLinput(): void
             . ' class="textfield datetimefield" c tabindex="25" id="field_0_3">',
             $result
         );
+
+        // case 4 int
+        $column['pma_type'] = 'int';
+        $column['True_Type'] = 'int';
+        $column['Type'] = 'int(11)';
+        $result = $this->callFunction(
+            $this->insertEdit,
+            InsertEdit::class,
+            'getHtmlInput',
+            [
+                $column,
+                'a',
+                'b',
+                11,
+                'c',
+                23,
+                2,
+                0,
+                'INT',
+                false,
+            ]
+        );
+        $this->assertEquals(
+            '<input type="text" name="fieldsa" value="b" size="11" min="-2147483648" max="2147483647" data-type="INT"'
+            . ' class="textfield" c tabindex="25" inputmode="numeric" id="field_0_3">',
+            $result
+        );
     }
 
     /**
