Merge pull request #18135 from kamil-tekiela/Remove-generateRowQueryOutput

MauricioFauth · web-flow · commit 193862ca926f · 2023-02-21T12:03:48.000-03:00
Remove generateRowQueryOutput() method
diff --git a/libraries/classes/Html/Generator.php b/libraries/classes/Html/Generator.php
@@ -414,47 +414,6 @@ public static function getStartAndNumberOfRowsFieldsetData(string $sqlQuery): ar
         return ['pos' => $pos, 'unlim_num_rows' => $numberOfLine, 'rows' => $rows, 'sql_query' => $sqlQuery];
     }
 
-    /**
-     * Execute an EXPLAIN query and formats results similar to MySQL command line
-     * utility.
-     *
-     * @param string $sqlQuery EXPLAIN query
-     *
-     * @return string query results
-     */
-    private static function generateRowQueryOutput($sqlQuery): string
-    {
-        $ret = '';
-        $result = $GLOBALS['dbi']->query($sqlQuery);
-        $devider = '+';
-        $columnNames = '|';
-        $fieldsMeta = $GLOBALS['dbi']->getFieldsMeta($result);
-        foreach ($fieldsMeta as $meta) {
-            $devider .= '---+';
-            $columnNames .= ' ' . $meta->name . ' |';
-        }
-
-        $devider .= "\n";
-
-        $ret .= $devider . $columnNames . "\n" . $devider;
-        while ($row = $result->fetchRow()) {
-            $values = '|';
-            foreach ($row as $value) {
-                if ($value === null) {
-                    $value = 'NULL';
-                }
-
-                $values .= ' ' . $value . ' |';
-            }
-
-            $ret .= $values . "\n";
-        }
-
-        $ret .= $devider;
-
-        return $ret;
-    }
-
     /**
      * Prepare the message and the query
      * usually the message is the result of the query executed
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -8871,9 +8871,6 @@
       <code><![CDATA[$_REQUEST['session_max_rows']]]></code>
       <code><![CDATA[$_REQUEST['unlim_num_rows']]]></code>
     </RiskyCast>
-    <UnusedMethod>
-      <code>generateRowQueryOutput</code>
-    </UnusedMethod>
   </file>
   <file src="libraries/classes/Image/ImageWrapper.php">
     <PossiblyUnusedReturnValue>
