Skip to content

Commit 18d91ef

Browse files
Merge pull request #18869 from kamil-tekiela/getStatusInfo-$disableError
Refactoring getStatusInfo() and Cache
2 parents 294b02d + 6e102ed commit 18d91ef

10 files changed

Lines changed: 100 additions & 269 deletions

File tree

phpstan-baseline.neon

Lines changed: 18 additions & 93 deletions
Original file line numberDiff line numberDiff line change
@@ -1585,11 +1585,6 @@ parameters:
15851585
count: 1
15861586
path: src/Controllers/Database/DataDictionaryController.php
15871587

1588-
-
1589-
message: "#^Cannot cast mixed to string\\.$#"
1590-
count: 1
1591-
path: src/Controllers/Database/DataDictionaryController.php
1592-
15931588
-
15941589
message: "#^Cannot access offset 'dbName' on mixed\\.$#"
15951590
count: 2
@@ -3360,11 +3355,6 @@ parameters:
33603355
count: 2
33613356
path: src/Controllers/Operations/DatabaseController.php
33623357

3363-
-
3364-
message: "#^Cannot access offset 'Row_format' on mixed\\.$#"
3365-
count: 1
3366-
path: src/Controllers/Operations/TableController.php
3367-
33683358
-
33693359
message: "#^Cannot access offset 'back' on mixed\\.$#"
33703360
count: 2
@@ -5881,58 +5871,28 @@ parameters:
58815871
path: src/Controllers/Table/Structure/SaveController.php
58825872

58835873
-
5884-
message: "#^Call to function in_array\\(\\) requires parameter \\#3 to be set\\.$#"
5885-
count: 1
5886-
path: src/Controllers/Table/StructureController.php
5887-
5888-
-
5889-
message: "#^Cannot access offset 'Check_time' on mixed\\.$#"
5890-
count: 1
5891-
path: src/Controllers/Table/StructureController.php
5892-
5893-
-
5894-
message: "#^Cannot access offset 'Create_time' on mixed\\.$#"
5895-
count: 1
5896-
path: src/Controllers/Table/StructureController.php
5897-
5898-
-
5899-
message: "#^Cannot access offset 'Data_free' on mixed\\.$#"
5900-
count: 1
5901-
path: src/Controllers/Table/StructureController.php
5902-
5903-
-
5904-
message: "#^Cannot access offset 'Data_length' on mixed\\.$#"
5905-
count: 7
5906-
path: src/Controllers/Table/StructureController.php
5907-
5908-
-
5909-
message: "#^Cannot access offset 'Index_length' on mixed\\.$#"
5910-
count: 2
5911-
path: src/Controllers/Table/StructureController.php
5912-
5913-
-
5914-
message: "#^Cannot access offset 'Name' on mixed\\.$#"
5915-
count: 1
5874+
message: "#^Binary operation \"\\+\" between int\\|non\\-falsy\\-string and int\\|non\\-falsy\\-string results in an error\\.$#"
5875+
count: 4
59165876
path: src/Controllers/Table/StructureController.php
59175877

59185878
-
5919-
message: "#^Cannot access offset 'Rows' on mixed\\.$#"
5879+
message: "#^Binary operation \"\\-\" between mixed and int\\|string results in an error\\.$#"
59205880
count: 1
59215881
path: src/Controllers/Table/StructureController.php
59225882

59235883
-
5924-
message: "#^Cannot access offset 'Type' on mixed\\.$#"
5884+
message: "#^Binary operation \"/\" between mixed and int\\|string\\|null results in an error\\.$#"
59255885
count: 1
59265886
path: src/Controllers/Table/StructureController.php
59275887

59285888
-
5929-
message: "#^Cannot access offset 'Update_time' on mixed\\.$#"
5889+
message: "#^Call to function in_array\\(\\) requires parameter \\#3 to be set\\.$#"
59305890
count: 1
59315891
path: src/Controllers/Table/StructureController.php
59325892

59335893
-
59345894
message: "#^Cannot use array destructuring on array\\<int, string\\>\\|null\\.$#"
5935-
count: 1
5895+
count: 4
59365896
path: src/Controllers/Table/StructureController.php
59375897

59385898
-
@@ -5946,28 +5906,18 @@ parameters:
59465906
path: src/Controllers/Table/StructureController.php
59475907

59485908
-
5949-
message: "#^Parameter \\#1 \\$datetime of function strtotime expects string, mixed given\\.$#"
5909+
message: "#^Parameter \\#1 \\$datetime of function strtotime expects string, int\\|string given\\.$#"
59505910
count: 3
59515911
path: src/Controllers/Table/StructureController.php
59525912

59535913
-
5954-
message: "#^Parameter \\#1 \\$showTableName of method PhpMyAdmin\\\\Table\\\\Table\\:\\:getNumRows\\(\\) expects string, mixed given\\.$#"
5955-
count: 1
5956-
path: src/Controllers/Table/StructureController.php
5957-
5958-
-
5959-
message: "#^Parameter \\#1 \\$timestamp of static method PhpMyAdmin\\\\Util\\:\\:localisedDate\\(\\) expects int, \\(int\\|false\\) given\\.$#"
5914+
message: "#^Parameter \\#1 \\$timestamp of static method PhpMyAdmin\\\\Util\\:\\:localisedDate\\(\\) expects int, int\\|false given\\.$#"
59605915
count: 3
59615916
path: src/Controllers/Table/StructureController.php
59625917

5963-
-
5964-
message: "#^Parameter \\#1 \\$value of static method PhpMyAdmin\\\\Util\\:\\:formatByteDown\\(\\) expects float\\|int\\|string\\|null, \\(array\\|float\\|int\\) given\\.$#"
5965-
count: 2
5966-
path: src/Controllers/Table/StructureController.php
5967-
59685918
-
59695919
message: "#^Parameter \\#1 \\$value of static method PhpMyAdmin\\\\Util\\:\\:formatByteDown\\(\\) expects float\\|int\\|string\\|null, mixed given\\.$#"
5970-
count: 3
5920+
count: 4
59715921
path: src/Controllers/Table/StructureController.php
59725922

59735923
-
@@ -12995,26 +12945,6 @@ parameters:
1299512945
count: 10
1299612946
path: src/Plugins/Schema/Pdf/PdfRelationSchema.php
1299712947

12998-
-
12999-
message: "#^Cannot access offset 'Check_time' on mixed\\.$#"
13000-
count: 1
13001-
path: src/Plugins/Schema/Pdf/PdfRelationSchema.php
13002-
13003-
-
13004-
message: "#^Cannot access offset 'Comment' on mixed\\.$#"
13005-
count: 1
13006-
path: src/Plugins/Schema/Pdf/PdfRelationSchema.php
13007-
13008-
-
13009-
message: "#^Cannot access offset 'Create_time' on mixed\\.$#"
13010-
count: 1
13011-
path: src/Plugins/Schema/Pdf/PdfRelationSchema.php
13012-
13013-
-
13014-
message: "#^Cannot access offset 'Update_time' on mixed\\.$#"
13015-
count: 1
13016-
path: src/Plugins/Schema/Pdf/PdfRelationSchema.php
13017-
1301812948
-
1301912949
message: "#^Cannot access offset 'foreign_field' on mixed\\.$#"
1302012950
count: 1
@@ -13071,7 +13001,7 @@ parameters:
1307113001
path: src/Plugins/Schema/Pdf/PdfRelationSchema.php
1307213002

1307313003
-
13074-
message: "#^Parameter \\#1 \\$datetime of function strtotime expects string, mixed given\\.$#"
13004+
message: "#^Parameter \\#1 \\$datetime of function strtotime expects string, int\\|string given\\.$#"
1307513005
count: 3
1307613006
path: src/Plugins/Schema/Pdf/PdfRelationSchema.php
1307713007

@@ -13081,7 +13011,7 @@ parameters:
1308113011
path: src/Plugins/Schema/Pdf/PdfRelationSchema.php
1308213012

1308313013
-
13084-
message: "#^Parameter \\#1 \\$timestamp of static method PhpMyAdmin\\\\Util\\:\\:localisedDate\\(\\) expects int, \\(int\\|false\\) given\\.$#"
13014+
message: "#^Parameter \\#1 \\$timestamp of static method PhpMyAdmin\\\\Util\\:\\:localisedDate\\(\\) expects int, int\\|false given\\.$#"
1308513015
count: 3
1308613016
path: src/Plugins/Schema/Pdf/PdfRelationSchema.php
1308713017

@@ -15427,31 +15357,31 @@ parameters:
1542715357

1542815358
-
1542915359
message: "#^Cannot cast mixed to int\\.$#"
15430-
count: 4
15360+
count: 1
1543115361
path: src/Table/Table.php
1543215362

1543315363
-
1543415364
message: "#^Cannot cast mixed to string\\.$#"
15435-
count: 3
15365+
count: 2
1543615366
path: src/Table/Table.php
1543715367

1543815368
-
1543915369
message: "#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#"
15440-
count: 20
15370+
count: 18
1544115371
path: src/Table/Table.php
1544215372

1544315373
-
15444-
message: "#^Method PhpMyAdmin\\\\Table\\\\Table\\:\\:getAutoIncrement\\(\\) should return string but returns mixed\\.$#"
15374+
message: "#^Method PhpMyAdmin\\\\Table\\\\Table\\:\\:getAutoIncrement\\(\\) should return string but returns int\\|string\\.$#"
1544515375
count: 1
1544615376
path: src/Table/Table.php
1544715377

1544815378
-
15449-
message: "#^Method PhpMyAdmin\\\\Table\\\\Table\\:\\:getCollation\\(\\) should return string but returns mixed\\.$#"
15379+
message: "#^Method PhpMyAdmin\\\\Table\\\\Table\\:\\:getCollation\\(\\) should return string but returns int\\|string\\.$#"
1545015380
count: 1
1545115381
path: src/Table/Table.php
1545215382

1545315383
-
15454-
message: "#^Method PhpMyAdmin\\\\Table\\\\Table\\:\\:getComment\\(\\) should return string but returns mixed\\.$#"
15384+
message: "#^Method PhpMyAdmin\\\\Table\\\\Table\\:\\:getComment\\(\\) should return string but returns int\\|string\\.$#"
1545515385
count: 1
1545615386
path: src/Table/Table.php
1545715387

@@ -15577,11 +15507,6 @@ parameters:
1557715507

1557815508
-
1557915509
message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, mixed given\\.$#"
15580-
count: 2
15581-
path: src/Table/Table.php
15582-
15583-
-
15584-
message: "#^Parameter \\#2 \\$array of function array_key_exists expects array, mixed given\\.$#"
1558515510
count: 1
1558615511
path: src/Table/Table.php
1558715512

@@ -15607,7 +15532,7 @@ parameters:
1560715532

1560815533
-
1560915534
message: "#^Parameter \\#2 \\$string of function explode expects string, mixed given\\.$#"
15610-
count: 3
15535+
count: 2
1561115536
path: src/Table/Table.php
1561215537

1561315538
-

0 commit comments

Comments
 (0)