Skip to content

Commit 16a0660

Browse files
MauricioFauthMauricioFauth
committed
Add native property types to test classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
1 parent 0bdcaba commit 16a0660

197 files changed

Lines changed: 441 additions & 776 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎phpcs.xml.dist‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@
4141
<rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingTraversableTypeHintSpecification">
4242
<severity>4</severity>
4343
</rule>
44-
<rule ref="SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint">
45-
<severity>4</severity>
46-
</rule>
4744
<rule ref="SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingTraversableTypeHintSpecification">
4845
<severity>4</severity>
4946
</rule>

‎phpstan-baseline.neon‎

Lines changed: 75 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -9580,6 +9580,11 @@ parameters:
95809580
count: 2
95819581
path: test/classes/Command/TwigLintCommandTest.php
95829582

9583+
-
9584+
message: "#^Class PhpMyAdmin\\\\Tests\\\\Command\\\\WriteGitRevisionCommandTest has an uninitialized property \\$command\\. Give it default value or assign it in the constructor\\.$#"
9585+
count: 1
9586+
path: test/classes/Command/WriteGitRevisionCommandTest.php
9587+
95839588
-
95849589
message: "#^Method PhpMyAdmin\\\\Tests\\\\CommonTest\\:\\:providerForTestCleanupPathInfo\\(\\) return type has no value type specified in iterable type array\\.$#"
95859590
count: 1
@@ -9890,6 +9895,16 @@ parameters:
98909895
count: 1
98919896
path: test/classes/Database/CentralColumnsTest.php
98929897

9898+
-
9899+
message: "#^Class PhpMyAdmin\\\\Tests\\\\Database\\\\Designer\\\\CommonTest has an uninitialized property \\$designerCommon\\. Give it default value or assign it in the constructor\\.$#"
9900+
count: 1
9901+
path: test/classes/Database/Designer/CommonTest.php
9902+
9903+
-
9904+
message: "#^Class PhpMyAdmin\\\\Tests\\\\Database\\\\DesignerTest has an uninitialized property \\$designer\\. Give it default value or assign it in the constructor\\.$#"
9905+
count: 1
9906+
path: test/classes/Database/DesignerTest.php
9907+
98939908
-
98949909
message: "#^Method PhpMyAdmin\\\\Tests\\\\Database\\\\EventsTest\\:\\:providerGetDataFromRequest\\(\\) return type has no value type specified in iterable type array\\.$#"
98959910
count: 1
@@ -10235,6 +10250,11 @@ parameters:
1023510250
count: 1
1023610251
path: test/classes/Gis/GisFactoryTest.php
1023710252

10253+
-
10254+
message: "#^Class PhpMyAdmin\\\\Tests\\\\Gis\\\\GisGeomTestCase has an uninitialized property \\$object\\. Give it default value or assign it in the constructor\\.$#"
10255+
count: 1
10256+
path: test/classes/Gis/GisGeomTestCase.php
10257+
1023810258
-
1023910259
message: "#^Method PhpMyAdmin\\\\Tests\\\\Gis\\\\GisGeomTestCase\\:\\:testGenerateParams\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#"
1024010260
count: 1
@@ -10290,11 +10310,6 @@ parameters:
1029010310
count: 1
1029110311
path: test/classes/Gis/GisGeometryCollectionTest.php
1029210312

10293-
-
10294-
message: "#^PHPDoc type PhpMyAdmin\\\\Gis\\\\GisGeometryCollection of property PhpMyAdmin\\\\Tests\\\\Gis\\\\GisGeometryCollectionTest\\:\\:\\$object is not the same as PHPDoc type PhpMyAdmin\\\\Gis\\\\GisGeometry of overridden property PhpMyAdmin\\\\Tests\\\\Gis\\\\GisGeomTestCase\\:\\:\\$object\\.$#"
10295-
count: 1
10296-
path: test/classes/Gis/GisGeometryCollectionTest.php
10297-
1029810313
-
1029910314
message: "#^Method PhpMyAdmin\\\\Tests\\\\Gis\\\\GisGeometryTest\\:\\:providerForTestExtractPoints\\(\\) return type has no value type specified in iterable type array\\.$#"
1030010315
count: 1
@@ -10391,9 +10406,9 @@ parameters:
1039110406
path: test/classes/Gis/GisLineStringTest.php
1039210407

1039310408
-
10394-
message: "#^PHPDoc type PhpMyAdmin\\\\Gis\\\\GisLineString of property PhpMyAdmin\\\\Tests\\\\Gis\\\\GisLineStringTest\\:\\:\\$object is not the same as PHPDoc type PhpMyAdmin\\\\Gis\\\\GisGeometry of overridden property PhpMyAdmin\\\\Tests\\\\Gis\\\\GisGeomTestCase\\:\\:\\$object\\.$#"
10409+
message: "#^Call to an undefined method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getShape\\(\\)\\.$#"
1039510410
count: 1
10396-
path: test/classes/Gis/GisLineStringTest.php
10411+
path: test/classes/Gis/GisMultiLineStringTest.php
1039710412

1039810413
-
1039910414
message: "#^Method PhpMyAdmin\\\\Tests\\\\Gis\\\\GisMultiLineStringTest\\:\\:providerForPrepareRowAsOl\\(\\) return type has no value type specified in iterable type array\\.$#"
@@ -10441,9 +10456,9 @@ parameters:
1044110456
path: test/classes/Gis/GisMultiLineStringTest.php
1044210457

1044310458
-
10444-
message: "#^PHPDoc type PhpMyAdmin\\\\Gis\\\\GisMultiLineString of property PhpMyAdmin\\\\Tests\\\\Gis\\\\GisMultiLineStringTest\\:\\:\\$object is not the same as PHPDoc type PhpMyAdmin\\\\Gis\\\\GisGeometry of overridden property PhpMyAdmin\\\\Tests\\\\Gis\\\\GisGeomTestCase\\:\\:\\$object\\.$#"
10459+
message: "#^Call to an undefined method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getShape\\(\\)\\.$#"
1044510460
count: 1
10446-
path: test/classes/Gis/GisMultiLineStringTest.php
10461+
path: test/classes/Gis/GisMultiPointTest.php
1044710462

1044810463
-
1044910464
message: "#^Method PhpMyAdmin\\\\Tests\\\\Gis\\\\GisMultiPointTest\\:\\:providerForPrepareRowAsOl\\(\\) return type has no value type specified in iterable type array\\.$#"
@@ -10491,9 +10506,9 @@ parameters:
1049110506
path: test/classes/Gis/GisMultiPointTest.php
1049210507

1049310508
-
10494-
message: "#^PHPDoc type PhpMyAdmin\\\\Gis\\\\GisMultiPoint of property PhpMyAdmin\\\\Tests\\\\Gis\\\\GisMultiPointTest\\:\\:\\$object is not the same as PHPDoc type PhpMyAdmin\\\\Gis\\\\GisGeometry of overridden property PhpMyAdmin\\\\Tests\\\\Gis\\\\GisGeomTestCase\\:\\:\\$object\\.$#"
10509+
message: "#^Call to an undefined method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getShape\\(\\)\\.$#"
1049510510
count: 1
10496-
path: test/classes/Gis/GisMultiPointTest.php
10511+
path: test/classes/Gis/GisMultiPolygonTest.php
1049710512

1049810513
-
1049910514
message: "#^Method PhpMyAdmin\\\\Tests\\\\Gis\\\\GisMultiPolygonTest\\:\\:getData\\(\\) return type has no value type specified in iterable type array\\.$#"
@@ -10556,9 +10571,9 @@ parameters:
1055610571
path: test/classes/Gis/GisMultiPolygonTest.php
1055710572

1055810573
-
10559-
message: "#^PHPDoc type PhpMyAdmin\\\\Gis\\\\GisMultiPolygon of property PhpMyAdmin\\\\Tests\\\\Gis\\\\GisMultiPolygonTest\\:\\:\\$object is not the same as PHPDoc type PhpMyAdmin\\\\Gis\\\\GisGeometry of overridden property PhpMyAdmin\\\\Tests\\\\Gis\\\\GisGeomTestCase\\:\\:\\$object\\.$#"
10574+
message: "#^Call to an undefined method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getShape\\(\\)\\.$#"
1056010575
count: 1
10561-
path: test/classes/Gis/GisMultiPolygonTest.php
10576+
path: test/classes/Gis/GisPointTest.php
1056210577

1056310578
-
1056410579
message: "#^Method PhpMyAdmin\\\\Tests\\\\Gis\\\\GisPointTest\\:\\:providerForPrepareRowAsOl\\(\\) return type has no value type specified in iterable type array\\.$#"
@@ -10616,9 +10631,24 @@ parameters:
1061610631
path: test/classes/Gis/GisPointTest.php
1061710632

1061810633
-
10619-
message: "#^PHPDoc type PhpMyAdmin\\\\Gis\\\\GisPoint of property PhpMyAdmin\\\\Tests\\\\Gis\\\\GisPointTest\\:\\:\\$object is not the same as PHPDoc type PhpMyAdmin\\\\Gis\\\\GisGeometry of overridden property PhpMyAdmin\\\\Tests\\\\Gis\\\\GisGeomTestCase\\:\\:\\$object\\.$#"
10634+
message: "#^Call to an undefined method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:area\\(\\)\\.$#"
1062010635
count: 1
10621-
path: test/classes/Gis/GisPointTest.php
10636+
path: test/classes/Gis/GisPolygonTest.php
10637+
10638+
-
10639+
message: "#^Call to an undefined method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getPointOnSurface\\(\\)\\.$#"
10640+
count: 1
10641+
path: test/classes/Gis/GisPolygonTest.php
10642+
10643+
-
10644+
message: "#^Call to an undefined method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:isOuterRing\\(\\)\\.$#"
10645+
count: 1
10646+
path: test/classes/Gis/GisPolygonTest.php
10647+
10648+
-
10649+
message: "#^Call to an undefined method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:isPointInsidePolygon\\(\\)\\.$#"
10650+
count: 2
10651+
path: test/classes/Gis/GisPolygonTest.php
1062210652

1062310653
-
1062410654
message: "#^Method PhpMyAdmin\\\\Tests\\\\Gis\\\\GisPolygonTest\\:\\:getData\\(\\) return type has no value type specified in iterable type array\\.$#"
@@ -10715,11 +10745,6 @@ parameters:
1071510745
count: 1
1071610746
path: test/classes/Gis/GisPolygonTest.php
1071710747

10718-
-
10719-
message: "#^PHPDoc type PhpMyAdmin\\\\Gis\\\\GisPolygon of property PhpMyAdmin\\\\Tests\\\\Gis\\\\GisPolygonTest\\:\\:\\$object is not the same as PHPDoc type PhpMyAdmin\\\\Gis\\\\GisGeometry of overridden property PhpMyAdmin\\\\Tests\\\\Gis\\\\GisGeomTestCase\\:\\:\\$object\\.$#"
10720-
count: 1
10721-
path: test/classes/Gis/GisPolygonTest.php
10722-
1072310748
-
1072410749
message: "#^Casting to string something that's already string\\.$#"
1072510750
count: 2
@@ -11150,6 +11175,16 @@ parameters:
1115011175
count: 1
1115111176
path: test/classes/Plugins/Export/Helpers/TablePropertyTest.php
1115211177

11178+
-
11179+
message: "#^Class PhpMyAdmin\\\\Tests\\\\Plugins\\\\Import\\\\ImportOdsTest has an uninitialized property \\$dbi\\. Give it default value or assign it in the constructor\\.$#"
11180+
count: 1
11181+
path: test/classes/Plugins/Import/ImportOdsTest.php
11182+
11183+
-
11184+
message: "#^Class PhpMyAdmin\\\\Tests\\\\Plugins\\\\Import\\\\ImportOdsTest has an uninitialized property \\$dummyDbi\\. Give it default value or assign it in the constructor\\.$#"
11185+
count: 1
11186+
path: test/classes/Plugins/Import/ImportOdsTest.php
11187+
1115311188
-
1115411189
message: "#^Method PhpMyAdmin\\\\Tests\\\\Plugins\\\\Import\\\\ImportOdsTest\\:\\:dataProviderOdsEmptyRows\\(\\) return type has no value type specified in iterable type array\\.$#"
1115511190
count: 1
@@ -11195,11 +11230,6 @@ parameters:
1119511230
count: 1
1119611231
path: test/classes/Properties/Options/OptionsPropertyGroupTest.php
1119711232

11198-
-
11199-
message: "#^PHPDoc type PhpMyAdmin\\\\Properties\\\\Plugins\\\\ExportPluginProperties of property PhpMyAdmin\\\\Tests\\\\Properties\\\\Plugins\\\\ExportPluginPropertiesTest\\:\\:\\$object is not the same as PHPDoc type PhpMyAdmin\\\\Properties\\\\Plugins\\\\ImportPluginProperties of overridden property PhpMyAdmin\\\\Tests\\\\Properties\\\\Plugins\\\\ImportPluginPropertiesTest\\:\\:\\$object\\.$#"
11200-
count: 1
11201-
path: test/classes/Properties/Plugins/ExportPluginPropertiesTest.php
11202-
1120311233
-
1120411234
message: "#^Call to method PHPUnit\\\\Framework\\\\Assert\\:\\:assertInstanceOf\\(\\) with 'FastRoute\\\\\\\\Dispatcher' and FastRoute\\\\Dispatcher will always evaluate to true\\.$#"
1120511235
count: 4
@@ -11240,6 +11270,11 @@ parameters:
1124011270
count: 1
1124111271
path: test/classes/Server/PluginsTest.php
1124211272

11273+
-
11274+
message: "#^Class PhpMyAdmin\\\\Tests\\\\Server\\\\PluginsTest has an uninitialized property \\$plugins\\. Give it default value or assign it in the constructor\\.$#"
11275+
count: 1
11276+
path: test/classes/Server/PluginsTest.php
11277+
1124311278
-
1124411279
message: "#^Call to method PHPUnit\\\\Framework\\\\Assert\\:\\:assertArrayHasKey\\(\\) with 0 and array\\{string, PhpMyAdmin\\\\Message\\} will always evaluate to true\\.$#"
1124511280
count: 3
@@ -11480,6 +11515,11 @@ parameters:
1148011515
count: 2
1148111516
path: test/classes/TwoFactorTest.php
1148211517

11518+
-
11519+
message: "#^Class PhpMyAdmin\\\\Tests\\\\TypesByDatabaseVersionTest has an uninitialized property \\$object\\. Give it default value or assign it in the constructor\\.$#"
11520+
count: 1
11521+
path: test/classes/TypesByDatabaseVersionTest.php
11522+
1148311523
-
1148411524
message: "#^Method PhpMyAdmin\\\\Tests\\\\TypesTest\\:\\:providerForGetTypeOperators\\(\\) return type has no value type specified in iterable type array\\.$#"
1148511525
count: 1
@@ -11730,6 +11770,16 @@ parameters:
1173011770
count: 2
1173111771
path: test/selenium/TestBase.php
1173211772

11773+
-
11774+
message: "#^Strict comparison using \\!\\=\\= between Facebook\\\\WebDriver\\\\Remote\\\\RemoteWebDriver and null will always evaluate to true\\.$#"
11775+
count: 1
11776+
path: test/selenium/TestBase.php
11777+
11778+
-
11779+
message: "#^Strict comparison using \\=\\=\\= between Facebook\\\\WebDriver\\\\Remote\\\\RemoteWebDriver and null will always evaluate to false\\.$#"
11780+
count: 1
11781+
path: test/selenium/TestBase.php
11782+
1173311783
-
1173411784
message: "#^Variable static method call on Facebook\\\\WebDriver\\\\WebDriverBy\\.$#"
1173511785
count: 4

0 commit comments

Comments
 (0)