Merge pull request #19322 from kamil-tekiela/cache-isAnyTrackingInProgress

MauricioFauth · web-flow · commit 136f1db5a2bf · 2024-10-15T19:29:17.000-03:00
Cache isAnyTrackingInProgress
diff --git a/src/Tracking/Tracker.php b/src/Tracking/Tracker.php
@@ -48,6 +48,13 @@ class Tracker
      */
     protected static array $trackingCache = [];
 
+    /**
+     * Cache of checked databases.
+     *
+     * @var bool[]
+     */
+    private static array $trackedDatabaseCache = [];
+
     /**
      * Actually enables tracking. This needs to be done after all
      * underlaying code is initialized.
@@ -317,6 +324,8 @@ private static function changeTracking(
             return false;
         }
 
+        unset(self::$trackedDatabaseCache[$dbName]); // Clear cache due to the change in tracking status
+
         $sqlQuery = sprintf(
             'UPDATE %s.%s SET `tracking_active` = %d'
                 . ' WHERE `db_name` = %s AND `table_name` = %s AND `version` = %s',
@@ -678,13 +687,20 @@ private static function isAnyTrackingInProgress(
         TrackingFeature $trackingFeature,
         string $dbname,
     ): bool {
+        if (isset(self::$trackedDatabaseCache[$dbname])) {
+            return self::$trackedDatabaseCache[$dbname];
+        }
+
         $sqlQuery = sprintf(
             '/*NOTRACK*/ SELECT 1 FROM %s.%s WHERE tracking_active = 1 AND db_name = %s LIMIT 1',
             Util::backquote($trackingFeature->database),
             Util::backquote($trackingFeature->tracking),
             $dbi->quoteString($dbname, ConnectionType::ControlUser),
         );
 
-        return $dbi->queryAsControlUser($sqlQuery)->fetchValue() !== false;
+        $isTracked = $dbi->queryAsControlUser($sqlQuery)->fetchValue() !== false;
+        self::$trackedDatabaseCache[$dbname] = $isTracked;
+
+        return $isTracked;
     }
 }
