Fix possible invalid argument in PdfRelationSchema

MauricioFauth · MauricioFauth · commit 129d35cf0af1 · 2023-10-11T16:11:32.000-03:00
Signed-off-by: Maurício Meneghini Fauth &lt;mauricio@fauth.dev&gt;
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -15750,11 +15750,6 @@ parameters:
 			count: 1
 			path: src/Plugins/Schema/Pdf/PdfRelationSchema.php
 
-		-
-			message: "#^Parameter \\#2 \\$value of method PhpMyAdmin\\\\Pdf\\:\\:setAlias\\(\\) expects string, int given\\.$#"
-			count: 2
-			path: src/Plugins/Schema/Pdf/PdfRelationSchema.php
-
 		-
 			message: "#^Parameter \\#3 \\$foreignTable of method PhpMyAdmin\\\\Plugins\\\\Schema\\\\Pdf\\\\PdfRelationSchema\\:\\:addRelation\\(\\) expects string, mixed given\\.$#"
 			count: 2
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -10131,10 +10131,6 @@
     <DeprecatedMethod>
       <code>DatabaseInterface::getInstance()</code>
     </DeprecatedMethod>
-    <InvalidArgument>
-      <code><![CDATA[$this->pdf->PageNo()]]></code>
-      <code><![CDATA[$this->pdf->PageNo()]]></code>
-    </InvalidArgument>
     <MixedArgument>
       <code><![CDATA[$mimeMap[$fieldName]['mimetype']]]></code>
       <code>$oneField</code>
diff --git a/src/Plugins/Schema/Pdf/PdfRelationSchema.php b/src/Plugins/Schema/Pdf/PdfRelationSchema.php
@@ -144,7 +144,7 @@ public function __construct(Relation $relation, DatabaseName $db)
         if ($this->withDoc) {
             $this->pdf->setLink($this->pdf->customLinks['RT']['-'], -1);
             $this->pdf->Bookmark(__('Relational schema'));
-            $this->pdf->setAlias('{00}', $this->pdf->PageNo());
+            $this->pdf->setAlias('{00}', (string) $this->pdf->PageNo());
             $this->topMargin = 28;
             $this->bottomMargin = 28;
         }
@@ -522,7 +522,7 @@ public function dataDictionaryDoc(array $alltables): void
             $this->pdf->Bookmark($table);
             $this->pdf->setAlias(
                 '{' . sprintf('%02d', $z) . '}',
-                $this->pdf->PageNo(),
+                (string) $this->pdf->PageNo(),
             );
             $this->pdf->customLinks['RT'][$table]['-'] = $this->pdf->AddLink();
             $this->pdf->setLink($this->pdf->customLinks['doc'][$table]['-'], -1);
