Skip to content

Commit 1210a25

Browse files
committed
Update PHPStan/Psalm baselines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
1 parent 4784606 commit 1210a25

3 files changed

Lines changed: 25 additions & 16 deletions

File tree

composer.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,11 @@
9999
"code-lts/u2f-php-server": "^1.2",
100100
"php-webdriver/webdriver": "^1.13",
101101
"phpmyadmin/coding-standard": "^4.0",
102-
"phpstan/extension-installer": "^1.1",
103-
"phpstan/phpstan": "^1.8",
102+
"phpstan/extension-installer": "^1.2",
103+
"phpstan/phpstan": "^1.10",
104104
"phpstan/phpstan-phpunit": "^1.3",
105-
"phpstan/phpstan-strict-rules": "^1.4",
106-
"phpstan/phpstan-webmozart-assert": "^1.0",
105+
"phpstan/phpstan-strict-rules": "^1.5",
106+
"phpstan/phpstan-webmozart-assert": "^1.2",
107107
"phpunit/phpunit": "^9.6",
108108
"pragmarx/google2fa-qrcode": "^2.1",
109109
"psalm/plugin-phpunit": "^0.18.4",

phpstan-baseline.neon

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4900,6 +4900,11 @@ parameters:
49004900
count: 2
49014901
path: libraries/classes/Html/Generator.php
49024902

4903+
-
4904+
message: "#^Static method PhpMyAdmin\\\\Html\\\\Generator\\:\\:generateRowQueryOutput\\(\\) is unused\\.$#"
4905+
count: 1
4906+
path: libraries/classes/Html/Generator.php
4907+
49034908
-
49044909
message: "#^Method PhpMyAdmin\\\\Http\\\\ServerRequest\\:\\:getAttributes\\(\\) return type has no value type specified in iterable type array\\.$#"
49054910
count: 1
@@ -5635,6 +5640,11 @@ parameters:
56355640
count: 1
56365641
path: libraries/classes/Message.php
56375642

5643+
-
5644+
message: "#^Right side of && is always true\\.$#"
5645+
count: 1
5646+
path: libraries/classes/Message.php
5647+
56385648
-
56395649
message: "#^Method PhpMyAdmin\\\\Navigation\\\\Navigation\\:\\:getHiddenItems\\(\\) return type has no value type specified in iterable type array\\.$#"
56405650
count: 1
@@ -10395,11 +10405,6 @@ parameters:
1039510405
count: 4
1039610406
path: test/classes/Display/ResultsTest.php
1039710407

10398-
-
10399-
message: "#^Strict comparison using \\=\\=\\= between 4 and 4 will always evaluate to true\\.$#"
10400-
count: 1
10401-
path: test/classes/EncodingTest.php
10402-
1040310408
-
1040410409
message: "#^Method PhpMyAdmin\\\\Tests\\\\Engines\\\\PbxtTest\\:\\:providerFortTestResolveTypeSize\\(\\) return type has no value type specified in iterable type array\\.$#"
1040510410
count: 1

psalm-baseline.xml

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<files psalm-version="5.7.1@8e0fd880141f236847ab49a06f94f788d41a4292">
2+
<files psalm-version="5.7.4@c46eccda769925073b8f65d66c4a3a7dc5d440b1">
33
<file src="libraries/classes/Advisory/Advisor.php">
44
<MixedArgument>
55
<code>$matches[1]</code>
@@ -9085,9 +9085,6 @@
90859085
<code><![CDATA[$GLOBALS['read_multiply']]]></code>
90869086
<code><![CDATA[$GLOBALS['timestamp']]]></code>
90879087
</PossiblyNullOperand>
9088-
<RedundantCondition>
9089-
<code><![CDATA[mb_strlen($GLOBALS['sql_query']) > 50000]]></code>
9090-
</RedundantCondition>
90919088
</file>
90929089
<file src="libraries/classes/Import/Ajax.php">
90939090
<MixedArrayAccess>
@@ -10650,6 +10647,9 @@
1065010647
<code><![CDATA[$_REQUEST['pma_servername']]]></code>
1065110648
<code>$tmp_host</code>
1065210649
</PossiblyInvalidCast>
10650+
<PossiblyInvalidPropertyAssignmentValue>
10651+
<code>$password</code>
10652+
</PossiblyInvalidPropertyAssignmentValue>
1065310653
<PossiblyNullReference>
1065410654
<code>removeCookie</code>
1065510655
<code>removeCookie</code>
@@ -12000,9 +12000,6 @@
1200012000
<RedundantCast>
1200112001
<code><![CDATA[(string) $GLOBALS['db']]]></code>
1200212002
</RedundantCast>
12003-
<RedundantCondition>
12004-
<code><![CDATA[$csvNewLine !== 'auto']]></code>
12005-
</RedundantCondition>
1200612003
</file>
1200712004
<file src="libraries/classes/Plugins/Import/ImportLdi.php">
1200812005
<InvalidArrayOffset>
@@ -14371,6 +14368,10 @@
1437114368
<code><![CDATA[$row['argument']]]></code>
1437214369
<code><![CDATA[$row['argument']]]></code>
1437314370
<code><![CDATA[$row['argument']]]></code>
14371+
<code><![CDATA[$row['argument']]]></code>
14372+
<code><![CDATA[$row['argument']]]></code>
14373+
<code><![CDATA[$row['sql_text']]]></code>
14374+
<code><![CDATA[$row['sql_text']]]></code>
1437414375
<code><![CDATA[$row['sql_text']]]></code>
1437514376
<code><![CDATA[$row['sql_text']]]></code>
1437614377
<code><![CDATA[$row['sql_text']]]></code>
@@ -15659,6 +15660,9 @@
1565915660
</PossiblyNullOperand>
1566015661
</file>
1566115662
<file src="libraries/classes/Util.php">
15663+
<ArgumentTypeCoercion>
15664+
<code>$separator</code>
15665+
</ArgumentTypeCoercion>
1566215666
<DeprecatedMethod>
1566315667
<code>escapeString</code>
1566415668
<code>escapeString</code>

0 commit comments

Comments
 (0)