Merge pull request #19483 from kamil-tekiela/Remove-unused-lines-from-psalm.xml

MauricioFauth · web-flow · commit 0df678036e16 · 2025-01-02T11:29:49.000-03:00
Remove unused lines from psalm.xml
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -6463,9 +6463,6 @@
       <code><![CDATA[Config::getInstance()]]></code>
       <code><![CDATA[Config::getInstance()]]></code>
     </DeprecatedMethod>
-    <InvalidArgument>
-      <code><![CDATA[$GLOBALS[$match]]]></code>
-    </InvalidArgument>
     <InvalidReturnStatement>
       <code><![CDATA[$GLOBALS[$name] ?? $name ?? '']]></code>
     </InvalidReturnStatement>
@@ -6490,6 +6487,7 @@
       <code><![CDATA[new $class()]]></code>
     </MixedMethodCall>
     <PossiblyInvalidArgument>
+      <code><![CDATA[$GLOBALS[$match]]]></code>
       <code><![CDATA[$_GET[$opt]]]></code>
       <code><![CDATA[$_REQUEST[$opt]]]></code>
       <code><![CDATA[$val]]></code>
diff --git a/psalm.xml b/psalm.xml
@@ -43,8 +43,6 @@
             buffer_needed: bool,
             cached_affected_rows: int|numeric-string,
             charset: string,
-            charset_connection: string,
-            collation_connection: string,
             complete_query: string,
             compression: 'none'|'zip'|'gzip',
             conn_error: string,
@@ -58,32 +56,21 @@
             error: bool,
             excel_edition: 'win'|'mac_excel2003'|'mac_excel2008',
             file_handle: resource|null,
-            finished: bool,
             from_cookie: bool,
             hostname: string,
-            import_file: string,
-            import_file_name: string,
             import_text: string,
             knjenc: string,
-            lang: string,
-            maximum_time: 0|positive-int,
             maxsize: string,
             memory_limit: int,
-            offset: int,
             old_tz: string,
             onfly_compression: bool,
             output_charset_conversion: bool,
             output_kanji_conversion: bool,
-            plugin_param: array{export_type: string, single_table: bool},
             plugin_scripts: string[],
             pma_auth_server: string,
-            PMA_PHP_SELF: string,
             querytime: float|int,
-            read_limit: int,
             save_on_server: bool,
             SESSION_KEY: string,
-            showtable: array&lt;string, string|null&gt;,
-            tbl_storage_engine: string,
             username: string
         }"/>
     </globals>
diff --git a/tests/unit/Controllers/Database/EventsControllerTest.php b/tests/unit/Controllers/Database/EventsControllerTest.php
@@ -23,7 +23,6 @@ final class EventsControllerTest extends AbstractTestCase
     public function testWithEvents(): void
     {
         Current::$server = 2;
-        $GLOBALS['PMA_PHP_SELF'] = 'index.php';
         Current::$database = 'test_db';
         Config::getInstance()->selectedServer['DisableIS'] = true;
 
@@ -193,7 +192,6 @@ public function testWithEvents(): void
     public function testWithoutEvents(): void
     {
         Current::$server = 2;
-        $GLOBALS['PMA_PHP_SELF'] = 'index.php';
         Current::$database = 'test_db';
         Config::getInstance()->selectedServer['DisableIS'] = true;
 
diff --git a/tests/unit/Controllers/Database/RoutinesControllerTest.php b/tests/unit/Controllers/Database/RoutinesControllerTest.php
@@ -24,7 +24,6 @@ final class RoutinesControllerTest extends AbstractTestCase
     public function testWithRoutines(): void
     {
         Current::$server = 2;
-        $GLOBALS['PMA_PHP_SELF'] = 'index.php';
         Current::$database = 'test_db';
         Config::getInstance()->selectedServer['DisableIS'] = true;
 
@@ -246,7 +245,6 @@ public function testWithRoutines(): void
     public function testWithoutRoutines(): void
     {
         Current::$server = 2;
-        $GLOBALS['PMA_PHP_SELF'] = 'index.php';
         Current::$database = 'test_db';
         Config::getInstance()->selectedServer['DisableIS'] = true;
 
diff --git a/tests/unit/Controllers/GisDataEditorControllerTest.php b/tests/unit/Controllers/GisDataEditorControllerTest.php
@@ -23,7 +23,6 @@ protected function setUp(): void
     {
         parent::setUp();
 
-        $GLOBALS['PMA_PHP_SELF'] = 'index.php';
         Current::$database = 'db';
         Current::$table = 'table';
 
diff --git a/tests/unit/Controllers/Triggers/IndexControllerTest.php b/tests/unit/Controllers/Triggers/IndexControllerTest.php
@@ -26,7 +26,6 @@ final class IndexControllerTest extends AbstractTestCase
     public function testWithTriggers(): void
     {
         Current::$server = 2;
-        $GLOBALS['PMA_PHP_SELF'] = 'index.php';
         Current::$database = 'test_db';
         Config::getInstance()->selectedServer['DisableIS'] = true;
 
@@ -161,7 +160,6 @@ public function testWithTriggers(): void
     public function testWithoutTriggers(): void
     {
         Current::$server = 2;
-        $GLOBALS['PMA_PHP_SELF'] = 'index.php';
         Current::$database = 'test_db';
         Config::getInstance()->selectedServer['DisableIS'] = true;
 

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@ final class EventsControllerTest extends AbstractTestCase`
`23`	`23`	`public function testWithEvents(): void`
`24`	`24`	`{`
`25`	`25`	`Current::$server = 2;`
`26`		`- $GLOBALS['PMA_PHP_SELF'] = 'index.php';`
`27`	`26`	`Current::$database = 'test_db';`
`28`	`27`	`Config::getInstance()->selectedServer['DisableIS'] = true;`
`29`	`28`
`@@ -193,7 +192,6 @@ public function testWithEvents(): void`
`193`	`192`	`public function testWithoutEvents(): void`
`194`	`193`	`{`
`195`	`194`	`Current::$server = 2;`
`196`		`- $GLOBALS['PMA_PHP_SELF'] = 'index.php';`
`197`	`195`	`Current::$database = 'test_db';`
`198`	`196`	`Config::getInstance()->selectedServer['DisableIS'] = true;`
`199`	`197`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@ final class RoutinesControllerTest extends AbstractTestCase`
`24`	`24`	`public function testWithRoutines(): void`
`25`	`25`	`{`
`26`	`26`	`Current::$server = 2;`
`27`		`- $GLOBALS['PMA_PHP_SELF'] = 'index.php';`
`28`	`27`	`Current::$database = 'test_db';`
`29`	`28`	`Config::getInstance()->selectedServer['DisableIS'] = true;`
`30`	`29`
`@@ -246,7 +245,6 @@ public function testWithRoutines(): void`
`246`	`245`	`public function testWithoutRoutines(): void`
`247`	`246`	`{`
`248`	`247`	`Current::$server = 2;`
`249`		`- $GLOBALS['PMA_PHP_SELF'] = 'index.php';`
`250`	`248`	`Current::$database = 'test_db';`
`251`	`249`	`Config::getInstance()->selectedServer['DisableIS'] = true;`
`252`	`250`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@ protected function setUp(): void`
`23`	`23`	`{`
`24`	`24`	`parent::setUp();`
`25`	`25`
`26`		`- $GLOBALS['PMA_PHP_SELF'] = 'index.php';`
`27`	`26`	`Current::$database = 'db';`
`28`	`27`	`Current::$table = 'table';`
`29`	`28`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@ final class IndexControllerTest extends AbstractTestCase`
`26`	`26`	`public function testWithTriggers(): void`
`27`	`27`	`{`
`28`	`28`	`Current::$server = 2;`
`29`		`- $GLOBALS['PMA_PHP_SELF'] = 'index.php';`
`30`	`29`	`Current::$database = 'test_db';`
`31`	`30`	`Config::getInstance()->selectedServer['DisableIS'] = true;`
`32`	`31`
`@@ -161,7 +160,6 @@ public function testWithTriggers(): void`
`161`	`160`	`public function testWithoutTriggers(): void`
`162`	`161`	`{`
`163`	`162`	`Current::$server = 2;`
`164`		`- $GLOBALS['PMA_PHP_SELF'] = 'index.php';`
`165`	`163`	`Current::$database = 'test_db';`
`166`	`164`	`Config::getInstance()->selectedServer['DisableIS'] = true;`
`167`	`165`