Skip to content

Commit b20dd08

Browse files
johnbillionjohnbillion
committed
Editor: Revert a fix for incorrect usage of ID attributes on custom fields.
This reverts [47222] due to compatibility issues with plugins which are using the `#poststuff` selector. See #46964 git-svn-id: https://develop.svn.wordpress.org/trunk@47410 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 0fcbdc1 commit b20dd08

10 files changed

Lines changed: 51 additions & 51 deletions

File tree

‎src/js/_enqueues/admin/postbox.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@
421421
break;
422422
case 0:
423423
case 180:
424-
if ( $( '.poststuff' ).length ) {
424+
if ( $( '#poststuff' ).length ) {
425425
this._pb_edit(1);
426426
} else {
427427
if ( !check.length || !check.is(':checked') )

‎src/wp-admin/css/dashboard.css‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
width: 49.5%;
77
}
88

9-
#wpbody-content #dashboard-widgets.columns-2 .postbox-container-2,
9+
#wpbody-content #dashboard-widgets.columns-2 #postbox-container-2,
1010
#wpbody-content #dashboard-widgets.columns-2 #postbox-container-3,
1111
#wpbody-content #dashboard-widgets.columns-2 #postbox-container-4 {
1212
float: right;
@@ -42,7 +42,7 @@
4242
width: 49.5%;
4343
}
4444

45-
.ie8 #wpbody-content #dashboard-widgets .postbox-container-2,
45+
.ie8 #wpbody-content #dashboard-widgets #postbox-container-2,
4646
.ie8 #wpbody-content #dashboard-widgets #postbox-container-3,
4747
.ie8 #wpbody-content #dashboard-widgets #postbox-container-4 {
4848
float: right;
@@ -1112,7 +1112,7 @@ a.rsswidget {
11121112
width: 49.5%;
11131113
}
11141114

1115-
#wpbody-content #dashboard-widgets .postbox-container-2,
1115+
#wpbody-content #dashboard-widgets #postbox-container-2,
11161116
#wpbody-content #dashboard-widgets #postbox-container-3,
11171117
#wpbody-content #dashboard-widgets #postbox-container-4 {
11181118
float: right;

‎src/wp-admin/css/edit.css‎

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
1-
.poststuff {
1+
#poststuff {
22
padding-top: 10px;
33
min-width: 763px;
44
}
55

6-
.poststuff #post-body {
6+
#poststuff #post-body {
77
padding: 0;
88
}
99

10-
.poststuff .postbox-container {
10+
#poststuff .postbox-container {
1111
width: 100%;
1212
}
1313

14-
.poststuff #post-body.columns-2 {
14+
#poststuff #post-body.columns-2 {
1515
margin-right: 300px;
1616
}
1717

@@ -51,7 +51,7 @@
5151
margin: 0;
5252
}
5353

54-
.poststuff #titlewrap {
54+
#poststuff #titlewrap {
5555
border: 0;
5656
padding: 0;
5757
}
@@ -414,7 +414,7 @@ form#tags-filter {
414414
padding-top: 20px;
415415
}
416416

417-
.poststuff #post-body.columns-2 #side-sortables {
417+
#poststuff #post-body.columns-2 #side-sortables {
418418
width: 280px;
419419
}
420420

@@ -605,38 +605,38 @@ form#tags-filter {
605605
text-indent: 0;
606606
}
607607

608-
.poststuff h3.hndle, /* Back-compat for pre-4.4 */
609-
.poststuff .stuffbox > h3, /* Back-compat for pre-4.4 */
610-
.poststuff h2 {
608+
#poststuff h3.hndle, /* Back-compat for pre-4.4 */
609+
#poststuff .stuffbox > h3, /* Back-compat for pre-4.4 */
610+
#poststuff h2 {
611611
font-size: 14px;
612612
padding: 8px 12px;
613613
margin: 0;
614614
line-height: 1.4;
615615
}
616616

617-
.poststuff .stuffbox h2 {
617+
#poststuff .stuffbox h2 {
618618
padding: 8px 10px;
619619
}
620620

621-
.poststuff .stuffbox > h2 {
621+
#poststuff .stuffbox > h2 {
622622
border-bottom: 1px solid #eee;
623623
}
624624

625-
.poststuff .inside {
625+
#poststuff .inside {
626626
margin: 6px 0 0 0;
627627
}
628628

629-
.poststuff .stuffbox .inside {
629+
#poststuff .stuffbox .inside {
630630
margin: 0;
631631
}
632632

633-
.poststuff .inside #parent_id,
634-
.poststuff .inside #page_template {
633+
#poststuff .inside #parent_id,
634+
#poststuff .inside #page_template {
635635
max-width: 100%;
636636
}
637637

638-
.ie8 .poststuff .inside #parent_id,
639-
.ie8 .poststuff .inside #page_template {
638+
.ie8 #poststuff .inside #parent_id,
639+
.ie8 #poststuff .inside #page_template {
640640
width: 250px;
641641
}
642642

@@ -656,7 +656,7 @@ form#tags-filter {
656656
}
657657

658658
#linksubmitdiv .inside, /* Old Link Manager back-compat. */
659-
.poststuff #submitdiv .inside {
659+
#poststuff #submitdiv .inside {
660660
margin: 0;
661661
padding: 0;
662662
}
@@ -1105,11 +1105,11 @@ p.description code {
11051105
13.0 - Tags
11061106
------------------------------------------------------------------------------*/
11071107

1108-
.poststuff .tagsdiv .ajaxtag {
1108+
#poststuff .tagsdiv .ajaxtag {
11091109
margin-top: 1em;
11101110
}
11111111

1112-
.poststuff .tagsdiv .howto {
1112+
#poststuff .tagsdiv .howto {
11131113
margin: 1em 0 6px 0;
11141114
}
11151115

@@ -1154,7 +1154,7 @@ p.popular-tags a {
11541154
margin: 2px 0 12px;
11551155
}
11561156

1157-
.poststuff .inside .the-tagcloud {
1157+
#poststuff .inside .the-tagcloud {
11581158
margin: 5px 0 10px;
11591159
padding: 8px;
11601160
border: 1px solid #ddd;
@@ -1426,11 +1426,11 @@ table.links-table {
14261426

14271427
/* one column on the post write/edit screen */
14281428
@media only screen and (max-width: 850px) {
1429-
.poststuff {
1429+
#poststuff {
14301430
min-width: 0;
14311431
}
14321432

1433-
#wpbody-content .poststuff #post-body {
1433+
#wpbody-content #poststuff #post-body {
14341434
margin: 0;
14351435
}
14361436

@@ -1439,14 +1439,14 @@ table.links-table {
14391439
width: 100%;
14401440
}
14411441

1442-
.poststuff #postbox-container-1 .empty-container,
1443-
.poststuff #postbox-container-1 #side-sortables:empty {
1442+
#poststuff #postbox-container-1 .empty-container,
1443+
#poststuff #postbox-container-1 #side-sortables:empty {
14441444
border: 0 none;
14451445
height: 0;
14461446
min-height: 0;
14471447
}
14481448

1449-
.poststuff #post-body.columns-2 #side-sortables {
1449+
#poststuff #post-body.columns-2 #side-sortables {
14501450
min-height: 0;
14511451
width: auto;
14521452
}
@@ -1471,13 +1471,13 @@ table.links-table {
14711471
padding: 10px 10px;
14721472
}
14731473

1474-
.poststuff .stuffbox .inside {
1474+
#poststuff .stuffbox .inside {
14751475
padding: 0 2px 4px 0;
14761476
}
14771477

1478-
.poststuff h3.hndle, /* Back-compat for pre-4.4 */
1479-
.poststuff .stuffbox > h3, /* Back-compat for pre-4.4 */
1480-
.poststuff h2 {
1478+
#poststuff h3.hndle, /* Back-compat for pre-4.4 */
1479+
#poststuff .stuffbox > h3, /* Back-compat for pre-4.4 */
1480+
#poststuff h2 {
14811481
padding: 12px;
14821482
}
14831483

‎src/wp-admin/css/ie.css‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
width: 49.5%;
1414
}
1515

16-
#wpbody-content #dashboard-widgets .postbox-container-2,
16+
#wpbody-content #dashboard-widgets #postbox-container-2,
1717
#wpbody-content #dashboard-widgets #postbox-container-3,
1818
#wpbody-content #dashboard-widgets #postbox-container-4 {
1919
float: right;
@@ -367,7 +367,7 @@ a.button.button-small {
367367
#wrap,
368368
#postdivrich,
369369
#postdiv,
370-
.poststuff,
370+
#poststuff,
371371
.metabox-holder,
372372
#titlediv,
373373
#post-body,
@@ -414,12 +414,12 @@ form#template div {
414414
padding: 0 4px;
415415
}
416416

417-
.poststuff h2 {
417+
#poststuff h2 {
418418
font-size: 1.6em;
419419
}
420420

421-
.poststuff .inside #parent_id,
422-
.poststuff .inside #page_template,
421+
#poststuff .inside #parent_id,
422+
#poststuff .inside #page_template,
423423
.inline-edit-row #post_parent,
424424
.inline-edit-row select[name="page_template"] {
425425
width: 250px;
@@ -677,7 +677,7 @@ input[type="password"],
677677
padding: 0;
678678
}
679679

680-
* html .poststuff h2 {
680+
* html #poststuff h2 {
681681
margin-left: 0;
682682
}
683683

‎src/wp-admin/css/media.css‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1033,15 +1033,15 @@ border color while dragging a file over the uploader drop area */
10331033
display: block;
10341034
}
10351035

1036-
.poststuff .imgedit-group-top h2 {
1036+
#poststuff .imgedit-group-top h2 {
10371037
display: inline-block;
10381038
margin: 0;
10391039
padding: 0;
10401040
font-size: 14px;
10411041
line-height: 1.4;
10421042
}
10431043

1044-
.poststuff .imgedit-group-top .button-link {
1044+
#poststuff .imgedit-group-top .button-link {
10451045
text-decoration: none;
10461046
color: #23282d;
10471047
}

‎src/wp-admin/edit-form-advanced.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@
494494
do_action( 'edit_form_top', $post );
495495
?>
496496

497-
<div class="poststuff">
497+
<div id="poststuff">
498498
<div id="post-body" class="metabox-holder columns-<?php echo 1 == get_current_screen()->get_columns() ? '1' : '2'; ?>">
499499
<div id="post-body-content">
500500

@@ -671,7 +671,7 @@
671671

672672
?>
673673
</div>
674-
<div class="postbox-container-2 postbox-container">
674+
<div id="postbox-container-2" class="postbox-container">
675675
<?php
676676

677677
do_meta_boxes( null, 'normal', $post );

‎src/wp-admin/edit-form-comment.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<div class="wrap">
1717
<h1><?php _e( 'Edit Comment' ); ?></h1>
1818

19-
<div class="poststuff">
19+
<div id="poststuff">
2020
<input type="hidden" name="action" value="editedcomment" />
2121
<input type="hidden" name="comment_ID" value="<?php echo esc_attr( $comment->comment_ID ); ?>" />
2222
<input type="hidden" name="comment_post_ID" value="<?php echo esc_attr( $comment->comment_post_ID ); ?>" />
@@ -214,7 +214,7 @@
214214
</div><!-- /submitdiv -->
215215
</div>
216216

217-
<div class="postbox-container-2 postbox-container">
217+
<div id="postbox-container-2" class="postbox-container">
218218
<?php
219219
/** This action is documented in wp-admin/includes/meta-boxes.php */
220220
do_action( 'add_meta_boxes', 'comment', $comment );

‎src/wp-admin/edit-link-form.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@
106106
wp_nonce_field( 'meta-box-order', 'meta-box-order-nonce', false );
107107
?>
108108

109-
<div class="poststuff">
109+
<div id="poststuff">
110110

111111
<div id="post-body" class="metabox-holder columns-<?php echo 1 == get_current_screen()->get_columns() ? '1' : '2'; ?>">
112112
<div id="post-body-content">
@@ -144,7 +144,7 @@
144144

145145
?>
146146
</div>
147-
<div class="postbox-container-2 postbox-container">
147+
<div id="postbox-container-2" class="postbox-container">
148148
<?php
149149

150150
do_meta_boxes( null, 'normal', $link );

‎src/wp-admin/includes/dashboard.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ function wp_dashboard() {
245245
<div id="postbox-container-1" class="postbox-container">
246246
<?php do_meta_boxes( $screen->id, 'normal', '' ); ?>
247247
</div>
248-
<div class="postbox-container-2 postbox-container">
248+
<div id="postbox-container-2" class="postbox-container">
249249
<?php do_meta_boxes( $screen->id, 'side', '' ); ?>
250250
</div>
251251
<div id="postbox-container-3" class="postbox-container">

‎src/wp-admin/includes/post.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2275,8 +2275,8 @@ function the_block_editor_meta_boxes() {
22752275
</form>
22762276
<?php foreach ( $locations as $location ) : ?>
22772277
<form class="metabox-location-<?php echo esc_attr( $location ); ?>" onsubmit="return false;">
2278-
<div class="poststuff" class="sidebar-open">
2279-
<div class="postbox-container-2 postbox-container">
2278+
<div id="poststuff" class="sidebar-open">
2279+
<div id="postbox-container-2" class="postbox-container">
22802280
<?php
22812281
do_meta_boxes(
22822282
$current_screen,

0 commit comments

Comments
 (0)