Multisite: Replace get_blog_details() in add_user_to_blog() with get_site().

jeremyfelt · jeremyfelt · commit 701dbe427127 · 2016-10-25T05:48:22.000Z
Adds tests for `add_user_to_blog()`. Props flixos90. Fixes #38356. git-svn-id: https://develop.svn.wordpress.org/trunk@38903 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/ms-functions.php b/src/wp-includes/ms-functions.php
@@ -161,8 +161,8 @@ function add_user_to_blog( $blog_id, $user_id, $role ) {
 
 	if ( !get_user_meta($user_id, 'primary_blog', true) ) {
 		update_user_meta($user_id, 'primary_blog', $blog_id);
-		$details = get_blog_details($blog_id);
-		update_user_meta($user_id, 'source_domain', $details->domain);
+		$site = get_site( $blog_id );
+		update_user_meta( $user_id, 'source_domain', $site->domain );
 	}
 
 	$user->set_role($role);
diff --git a/tests/phpunit/tests/user/multisite.php b/tests/phpunit/tests/user/multisite.php
@@ -365,6 +365,37 @@ public function test_should_return_false_for_object_user_id() {
 		$this->assertFalse( wpmu_delete_user( $u_obj ) );
 		$this->assertEquals( $u_obj->ID, username_exists( $u_obj->user_login ) );
 	}
+
+	/**
+	 * @ticket 38356
+	 */
+	public function test_add_user_to_blog_subscriber() {
+		$site_id = self::factory()->blog->create();
+		$user_id = self::factory()->user->create();
+
+		add_user_to_blog( $site_id, $user_id, 'subscriber' );
+
+		switch_to_blog( $site_id );
+		$user = get_user_by( 'id', $user_id );
+		restore_current_blog();
+
+		wpmu_delete_blog( $site_id );
+		wpmu_delete_user( $user_id );
+
+		$this->assertContains( 'subscriber', $user->roles );
+	}
+
+	/**
+	 * @ticket 38356
+	 */
+	public function test_add_user_to_blog_invalid_user() {
+		$site_id = self::factory()->blog->create();
+
+		$result = add_user_to_blog( 73622, $site_id, 'subscriber' );
+		wpmu_delete_blog( $site_id );
+
+		$this->assertWPError( $result );
+	}
 }
 
 endif ;

Original file line number	Diff line number	Diff line change
`@@ -161,8 +161,8 @@ function add_user_to_blog( $blog_id, $user_id, $role ) {`
`161`	`161`
`162`	`162`	`if ( !get_user_meta($user_id, 'primary_blog', true) ) {`
`163`	`163`	`update_user_meta($user_id, 'primary_blog', $blog_id);`
`164`		`- $details = get_blog_details($blog_id);`
`165`		`- update_user_meta($user_id, 'source_domain', $details->domain);`
	`164`	`+ $site = get_site( $blog_id );`
	`165`	`+ update_user_meta( $user_id, 'source_domain', $site->domain );`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`$user->set_role($role);`