Introudce historian to CI (#1106)

dantleech · web-flow · commit 5a4716cf6a15 · 2024-09-29T21:27:09.000+01:00
* Introudce historian to CI

* Fix quoting and incidental CS fixing
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -219,12 +219,36 @@ jobs:
               run: php --version
 
             - name: "Run tests with PHPUnit"
-              run: vendor/bin/phpunit
+              run: "vendor/bin/phpunit --log-junit phpunit-${{ matrix.php-version }}-${{ matrix.dependency }}.xml"
               env:
                   SKIP_XDEBUG_TESTS: "${{ matrix.skip_xdebug_tests }}"
+            -
+              name: "Upload to Historian"
+              run: |
+                curl http://${{ secrets.HISTORIAN_HOST }}/api/upload -XPOST \
+                  -H"X-Api-Key: ${{ secrets.HISTORIAN_API_KEY }}" \
+                  -H"X-Build: ${{ github.run_number }}" \
+                  -H"X-Commit-Sh: ${{ github.sha }}" \
+                  -H"X-Commit-Message: ${{ github.event.head_commit.message }}" \
+                  -H"X-Author-Name: ${{ github.event.head_commit.author.name }}" \
+                  -H"X-Author-Email: ${{ github.event.head_commit.author.email }}" \
+                  -H"X-Host: ${{ runner.name }}" \
+                  -F"phpunit=@phpunit-${{ matrix.php-version }}-${{ matrix.dependency }}.xml"
 
             - name: "Run benchmarks with PHPBench"
-              run: bin/phpbench run --report=env --progress=dots
+              run: "bin/phpbench run --report=env --progress=dots --dump-file=phpbench-${{ matrix.php-version }}-${{ matrix.dependency }}.xml"
+            -
+              name: "Upload to Historian"
+              run: |
+                curl http://${{ secrets.HISTORIAN_HOST }}/api/upload -XPOST \
+                  -H"X-Api-Key: ${{ secrets.HISTORIAN_API_KEY }}" \
+                  -H"X-Build: ${{ github.run_number }}" \
+                  -H"X-Commit-Sh: ${{ github.sha }}" \
+                  -H"X-Commit-Message: ${{ github.event.head_commit.message }}" \
+                  -H"X-Author-Name: ${{ github.event.head_commit.author.name }}" \
+                  -H"X-Author-Email: ${{ github.event.head_commit.author.email }}" \
+                  -H"X-Host: ${{ runner.name }}" \
+                  -Fphpbench=@phpbench-${{ matrix.php-version }}-${{ matrix.dependency }}.xml
 
             - if: matrix.with-examples == 'yes'
               run: bin/phpbench run --profile=examples --report=env --progress=dots --iterations=1 --revs=1
diff --git a/lib/Console/CharacterReader.php b/lib/Console/CharacterReader.php
@@ -34,7 +34,6 @@ private static function initialize(): void
     /**
      * Wait for a single character input and return it.
      *
-     * @return ?string
      */
     public function read(): ?string
     {
diff --git a/lib/Storage/HistoryEntry.php b/lib/Storage/HistoryEntry.php
@@ -34,18 +34,18 @@ class HistoryEntry
      * @param int|float $totalTime
      */
     public function __construct(
-        private                   $runId,
+        private $runId,
         private readonly DateTime $date,
-        private                   $tag,
-        private                   $branch,
-        private                   $nbSubjects,
-        private                   $nbIterations,
-        private                   $nbRevolutions,
-        private                   $minTime,
-        private                   $maxTime,
-        private                   $meanTime,
-        private                   $meanRelStDev,
-        private                   $totalTime
+        private $tag,
+        private $branch,
+        private $nbSubjects,
+        private $nbIterations,
+        private $nbRevolutions,
+        private $minTime,
+        private $maxTime,
+        private $meanTime,
+        private $meanRelStDev,
+        private $totalTime
     ) {
     }
 

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,6 @@ private static function initialize(): void`
`34`	`34`	`/**`
`35`	`35`	`* Wait for a single character input and return it.`
`36`	`36`	`*`
`37`		`- * @return ?string`
`38`	`37`	`*/`
`39`	`38`	`public function read(): ?string`
`40`	`39`	`{`