Skip to content

Commit 333aa5f

Browse files
authored
Apply suggestions from code review
1 parent 10a5135 commit 333aa5f

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/Reader.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@ public static function readFromYaml(string $yaml, string $baseType = OpenApi::cl
6262
* If `true`, all [[Reference]] objects will be replaced with their referenced spec objects by calling
6363
* [[SpecObjectInterface::resolveReferences()]].
6464
* Since version 1.5.0 this can be a string indicating the reference resolving mode:
65-
* - TODO inline vs all
65+
* - `inline` only resolve references to external files.
66+
* - `all` resolve all references exceot recursive references.
6667
* @return SpecObjectInterface|OpenApi the OpenApi object instance.
6768
* The type of the returned object depends on the `$baseType` argument.
6869
* @throws TypeErrorException in case invalid spec data is supplied.
@@ -102,7 +103,8 @@ public static function readFromJsonFile(string $fileName, string $baseType = Ope
102103
* If `true`, all [[Reference]] objects will be replaced with their referenced spec objects by calling
103104
* [[SpecObjectInterface::resolveReferences()]].
104105
* Since version 1.5.0 this can be a string indicating the reference resolving mode:
105-
* - TODO inline vs all
106+
* - `inline` only resolve references to external files.
107+
* - `all` resolve all references exceot recursive references.
106108
* @return SpecObjectInterface|OpenApi the OpenApi object instance.
107109
* The type of the returned object depends on the `$baseType` argument.
108110
* @throws TypeErrorException in case invalid spec data is supplied.

0 commit comments

Comments
 (0)