Skip to content

[WIP] Application credentials#336

Closed
smarcet wants to merge 2 commits into
php-opencloud:masterfrom
OpenStackweb:feature/guzzle_7_x
Closed

[WIP] Application credentials#336
smarcet wants to merge 2 commits into
php-opencloud:masterfrom
OpenStackweb:feature/guzzle_7_x

Conversation

@smarcet

@smarcet smarcet commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

this feature branch adds the

application credentials to identity api

depicted here

https://docs.openstack.org/keystone/latest/user/application_credentials.html

smarcet added 2 commits August 5, 2021 11:17
* added application credentials option to identity api v3 ( get token )
* update get metadata method
@smarcet

smarcet commented Aug 5, 2021

Copy link
Copy Markdown
Contributor Author

guys greetings i work for the OSF i do think this feature will be really useful matter of fact we are using this lib to integration openstackid.org with swift object storage using app credentials

regards

@haphan

haphan commented Aug 5, 2021 via email

Copy link
Copy Markdown
Collaborator

@haphan haphan changed the title Feature/guzzle 7 x [WIP] Application credentials Aug 7, 2021
@haphan

haphan commented Aug 7, 2021

Copy link
Copy Markdown
Collaborator

I think it would be very useful for this SDK to support application credentials (added since Openstack 3.10 Queen).

Having said that, we probably want to do it in a systematic way; meaning to cover (1) the Application credential API as well as (2) the login flow.

@smarcet Are you able to work on it?

@smarcet

smarcet commented Aug 11, 2021

Copy link
Copy Markdown
Contributor Author

@haphan as far i understand
PR covers (2) [login flow]
i do think that (1) could be covered on a second PR
regards

@mzur mzur mentioned this pull request Sep 29, 2021
@drzraf

drzraf commented Jan 4, 2022

Copy link
Copy Markdown

Some additional tweaks:
drzraf@b5ead02

  1. application credentials (at least mine) can not request a scope, so the payload sent to /tokens must be modified according to the authentication method
  2. Fix an error message regarding the supported authentication methods.

@drzraf

drzraf commented Jan 13, 2022

Copy link
Copy Markdown

@smarcet

@martijnve

Copy link
Copy Markdown

We have tested this MR in our application and would very much like this to be in the mainline. Is there anything we can do to assist in this feature getting merged?

@smarcet

smarcet commented Dec 19, 2023

Copy link
Copy Markdown
Contributor Author

@martijnve hello!
i will try to make some time before EOY to review the comments

@k0ka

k0ka commented Dec 19, 2023

Copy link
Copy Markdown
Member

Hello,

I haven't checked it yet. I hope I'll have some time this week.
Most probably I won't merge it to the mainline without integration tests. And writing them might be quite tricky.

@k0ka

k0ka commented Jan 7, 2024

Copy link
Copy Markdown
Member

@k0ka k0ka closed this Jan 7, 2024
@drzraf drzraf mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants