Merge pull request #114 from php-java/fix-object-clone

chitoku-k · web-flow · commit af5a923eac85 · 2019-05-07T12:05:26.000+09:00
Fix Object#clone
diff --git a/src/Packages/PHPJava/Extended/_Object.php b/src/Packages/PHPJava/Extended/_Object.php
@@ -3,6 +3,7 @@
 
 use PHPJava\Packages\PHPJava\Kernel\Behavior\System;
 use PHPJava\Packages\java\lang\NoSuchMethodException;
+use PHPJava\Packages\java\lang\CloneNotSupportedException;
 
 trait _Object
 {
@@ -40,12 +41,9 @@ public function __call($name, $arguments)
         throw new NoSuchMethodException($name . ' does not exist on ' . get_class($this));
     }
 
-    /**
-     * @return _Object
-     */
-    public function __default_clone(): _Object
+    public function __default_clone(): void
     {
-        return clone $this;
+        throw new CloneNotSupportedException();
     }
 
     /**
diff --git a/tests/Packages/PHPJava/Extended/_Object.php b/tests/Packages/PHPJava/Extended/_Object.php
@@ -0,0 +1,18 @@
+<?php
+namespace PHPJava\Tests\Packages\PHPJava\Extended\_Object;
+
+use PHPUnit\Framework\TestCase;
+use PHPJava\Packages\java\lang\CloneNotSupportedException;
+
+class _ObjectTest extends Base
+{
+    public function testClone()
+    {
+        $this->expectException(CloneNotSupportedException::class);
+
+        clone new class
+        {
+            use \PHPJava\Packages\PHPJava\Extended\_Object;
+        };
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`
`4`	`4`	`use PHPJava\Packages\PHPJava\Kernel\Behavior\System;`
`5`	`5`	`use PHPJava\Packages\java\lang\NoSuchMethodException;`
	`6`	`+use PHPJava\Packages\java\lang\CloneNotSupportedException;`
`6`	`7`
`7`	`8`	`trait _Object`
`8`	`9`	`{`
`@@ -40,12 +41,9 @@ public function __call($name, $arguments)`
`40`	`41`	`throw new NoSuchMethodException($name . ' does not exist on ' . get_class($this));`
`41`	`42`	`}`
`42`	`43`
`43`		`- /**`
`44`		`- * @return _Object`
`45`		`- */`
`46`		`- public function __default_clone(): _Object`
	`44`	`+ public function __default_clone(): void`
`47`	`45`	`{`
`48`		`- return clone $this;`
	`46`	`+ throw new CloneNotSupportedException();`
`49`	`47`	`}`
`50`	`48`
`51`	`49`	`/**`