Add PHPCS and Fix for rules

m3m0r7 · m3m0r7 · commit a90a5cc58418 · 2019-02-27T14:35:40.000+09:00
diff --git a/.gitignore b/.gitignore
@@ -7,4 +7,3 @@ composer.lock
 .phpunit.result.cache
 tests/caches/
 !tests/caches/.gitkeep
-.php_cs.cache
diff --git a/README.md b/README.md
@@ -294,7 +294,11 @@ public static void main(java.lang.String[])
 ./vendor/bin/phpunit tests
 ```
 
-- PHPCS is below.
+- PHP Coding standards testing is below.
+
+```
+./vendor/bin/phpcs --standard=phpcs.xml src
+```
 
 ## Reference
 - [Java Virtual Machine Specification](https://docs.oracle.com/javase/specs/jvms/se11/html/index.html)
diff --git a/phpcs.xml b/phpcs.xml
@@ -0,0 +1,27 @@
+<ruleset name="PHPJava Standards">
+    <description>The PHPJava Coding Standards</description>
+
+    <exclude-pattern>./tests</exclude-pattern>
+
+    <rule ref="PSR2">
+        <exclude name="Generic.Files.LineLength.TooLong"/>
+    </rule>
+
+    <rule ref="Squiz.Classes.ValidClassName.NotCamelCaps">
+        <exclude-pattern>./src/kernel/types</exclude-pattern>
+        <exclude-pattern>./src/kernel/mnemonics</exclude-pattern>
+        <exclude-pattern>./src/kernel/structures</exclude-pattern>
+        <exclude-pattern>./src/imitation/java/lang/_Object.php</exclude-pattern>
+        <exclude-pattern>./src/imitation/java/lang/_String.php</exclude-pattern>
+        <exclude-pattern>./src/imitation/phpjava/extended/_Object</exclude-pattern>
+    </rule>
+
+    <rule ref="Generic.NamingConventions.UpperCaseConstantName.ClassConstantNotUpperCase">
+        <exclude-pattern>./src/kernel/maps</exclude-pattern>
+    </rule>
+
+    <arg name="colors"/>
+    <arg value="p"/>
+
+    <ini name="memory_limit" value="128M"/>
+</ruleset>
diff --git a/src/imitation/java/io/PrintStream.php b/src/imitation/java/io/PrintStream.php
@@ -13,8 +13,7 @@ public function println($arg)
             echo $arg->getString() . "\n";
             return;
         }
-        if (
-            is_string($arg) ||
+        if (is_string($arg) ||
             is_int($arg) ||
             $arg instanceof Type ||
             $arg instanceof \PHPJava\Imitation\java\lang\_String
@@ -32,8 +31,7 @@ public function print($arg)
             echo $arg->getString();
             return;
         }
-        if (
-            is_string($arg) ||
+        if (is_string($arg) ||
             is_int($arg) ||
             $arg instanceof Type ||
             $arg instanceof \PHPJava\Imitation\java\lang\_String
diff --git a/src/kernel/mnemonics/_getstatic.php b/src/kernel/mnemonics/_getstatic.php
@@ -23,7 +23,6 @@ public function execute(): void
         if ($cp instanceof _Fieldref) {
             foreach ($this->javaClass->getFields() as $field) {
                 if ($cpInfo[$field->getNameIndex()]->getString() === $cpInfo[$cpInfo[$cp->getNameAndTypeIndex()]->getNameIndex()]->getString()) {
-
                     // push stack
                     $fieldName = $cpInfo[$field->getNameIndex()]->getString();
                     $this->pushStack($this->javaClassInvoker->getStaticFields()->get($fieldName));
diff --git a/src/kernel/mnemonics/_lookupswitch.php b/src/kernel/mnemonics/_lookupswitch.php
@@ -29,7 +29,6 @@ public function execute(): void
         }
 
         if (isset($offsets[$key])) {
-
             // goto PC
             $this->setOffset($this->getProgramCounter() + $offsets[$key]);
             return;
diff --git a/src/kernel/mnemonics/_tableswitch.php b/src/kernel/mnemonics/_tableswitch.php
@@ -28,13 +28,11 @@ public function execute(): void
         }
 
         if (isset($offsets[$key])) {
-
             // goto PC
             $this->setOffset($this->getProgramCounter() + $offsets[$key]);
             return;
         }
 
-
         // goto default
         $this->setOffset($this->getProgramCounter() + $offsets['default']);
     }
diff --git a/src/utilities/BinaryTool.php b/src/utilities/BinaryTool.php
@@ -33,7 +33,6 @@ final public static function addOneBit($bits)
         $bitSize = strlen($bits);
 
         for ($index = $bitSize - 1; $index >= 0 && $bits[$index] === '1'; $index--) {
-
             // nop
         }
 
@@ -70,7 +69,6 @@ final public static function negate($value, $bytes)
         $value = base_convert((string) $value, 10, 2);
 
         if (sprintf('%0' . $bytes . 's', $value) === str_repeat('0', $bytes)) {
-
             // zero number was overflow
             return '0';
         }

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,6 @@ public function execute(): void`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`if (isset($offsets[$key])) {`
`32`		`-`
`33`	`32`	`// goto PC`
`34`	`33`	`$this->setOffset($this->getProgramCounter() + $offsets[$key]);`
`35`	`34`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -28,13 +28,11 @@ public function execute(): void`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`if (isset($offsets[$key])) {`
`31`		`-`
`32`	`31`	`// goto PC`
`33`	`32`	`$this->setOffset($this->getProgramCounter() + $offsets[$key]);`
`34`	`33`	`return;`
`35`	`34`	`}`
`36`	`35`
`37`		`-`
`38`	`36`	`// goto default`
`39`	`37`	`$this->setOffset($this->getProgramCounter() + $offsets['default']);`
`40`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,6 @@ final public static function addOneBit($bits)`
`33`	`33`	`$bitSize = strlen($bits);`
`34`	`34`
`35`	`35`	`for ($index = $bitSize - 1; $index >= 0 && $bits[$index] === '1'; $index--) {`
`36`		`-`
`37`	`36`	`// nop`
`38`	`37`	`}`
`39`	`38`
`@@ -70,7 +69,6 @@ final public static function negate($value, $bytes)`
`70`	`69`	`$value = base_convert((string) $value, 10, 2);`
`71`	`70`
`72`	`71`	`if (sprintf('%0' . $bytes . 's', $value) === str_repeat('0', $bytes)) {`
`73`		`-`
`74`	`72`	`// zero number was overflow`
`75`	`73`	`return '0';`
`76`	`74`	`}`