Remove magics

m3m0r7 · m3m0r7 · commit 92f94c9ab747 · 2019-04-05T17:11:58.000+09:00
diff --git a/src/Core/JVM/Invoker/Invokable.php b/src/Core/JVM/Invoker/Invokable.php
@@ -21,6 +21,7 @@
 use PHPJava\Utilities\Formatter;
 use PHPJava\Utilities\SuperClassResolver;
 use PHPJava\Utilities\TypeResolver;
+use PHPJava\Core\JVM\Parameters\Settings;
 
 trait Invokable
 {
@@ -111,7 +112,7 @@ function ($argument) {
             )['arguments'];
 
             // does not strict mode can be PHP types
-            if (!($this->options['strict'] ?? true)) {
+            if (!($this->options['strict'] ?? Settings::STRICT)) {
                 $formattedArguments = Formatter::signatureConvertToAmbiguousForPHP($formattedArguments);
             }
 
@@ -120,13 +121,13 @@ function ($argument) {
              */
             $methodSignature = Formatter::buildArgumentsSignature($formattedArguments);
 
-            if (!($this->options['validation']['method']['arguments_count_only'] ?? false)) {
+            if (!($this->options['validation']['method']['arguments_count_only'] ?? Settings::VALIDATION_METHOD_ARGUMENTS_COUNT_ONLY)) {
                 if ($methodSignature === $convertedPassedArguments) {
                     $method = $methodReference;
                     break;
                 }
             }
-            if (($this->options['validation']['method']['arguments_count_only'] ?? false) === true) {
+            if (($this->options['validation']['method']['arguments_count_only'] ?? Settings::VALIDATION_METHOD_ARGUMENTS_COUNT_ONLY) === true) {
                 $size = count($formattedArguments);
                 $passedArgumentsSize = count(
                     $arguments
@@ -180,7 +181,7 @@ function ($argument) {
         $mnemonicMap = new OpCode();
         $executedCounter = 0;
         while ($reader->getOffset() < $codeAttribute->getOpCodeLength()) {
-            if (++$executedCounter > ($this->options['max_stack_exceeded'] ?? \PHPJava\Core\JVM\Parameters\Invoker::MAX_STACK_EXCEEDED)) {
+            if (++$executedCounter > ($this->options['max_stack_exceeded'] ?? Settings::MAX_STACK_EXCEEDED)) {
                 throw new RuntimeException(
                     'Max stack exceeded. PHPJava has been stopped by safety guard.' .
                     ' Maybe Java class has illegal program counter, stacks, or OpCode.'
diff --git a/src/Core/JVM/Parameters/Invoker.php b/src/Core/JVM/Parameters/Invoker.php
diff --git a/src/Core/JVM/Parameters/Settings.php b/src/Core/JVM/Parameters/Settings.php
@@ -0,0 +1,10 @@
+<?php
+namespace PHPJava\Core\JVM\Parameters;
+
+final class Settings
+{
+    const MAX_STACK_EXCEEDED = 9999;
+    const STRICT = true;
+
+    const VALIDATION_METHOD_ARGUMENTS_COUNT_ONLY = false;
+}
