Fix Object#clone

himanoa · himanoa · commit 7ec1e8085618 · 2019-04-29T23:38:49.000+09:00
Throw CloneNotSupportedException
diff --git a/src/Packages/PHPJava/Extended/_Object.php b/src/Packages/PHPJava/Extended/_Object.php
@@ -3,10 +3,10 @@
 
 use PHPJava\Packages\PHPJava\Kernel\Behavior\System;
 use PHPJava\Packages\java\lang\NoSuchMethodException;
+use PHPJava\Packages\java\lang\CloneNotSupportedException;
 
 trait _Object
 {
-
     private $parameters;
 
     /**
@@ -41,12 +41,9 @@ public function __call($name, $arguments)
         throw new NoSuchMethodException($name . ' does not exist on ' . get_class($this));
     }
 
-    /**
-     * @return _Object
-     */
-    public function __default_clone(): _Object
+    public function __default_clone(): void
     {
-        return clone $this;
+        throw new CloneNotSupportedException();
     }
 
     /**
diff --git a/tests/Packages/PHPJava/Extended/_Object.php b/tests/Packages/PHPJava/Extended/_Object.php
@@ -0,0 +1,22 @@
+<?php
+namespace PHPJava\Tests\Packages\PHPJava\Extended\_Object;
+
+use PHPUnit\Framework\TestCase;
+use PHPJava\Packages\java\lang\CloneNotSupportedException;
+
+class DummyObject
+{
+    use \PHPJava\Packages\PHPJava\Extended\_Object;
+}
+
+class _ObjectTest extends Base
+{
+    public function testClone()
+    {
+        $this->expectException(CloneNotSupportedException);
+        $target = new DummyObject();
+        $method = new \ReflectionMethod(get_class($target), '__clone');
+        $method->setAccessible(true);
+        $method->invoke($target);
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -3,10 +3,10 @@`
`3`	`3`
`4`	`4`	`use PHPJava\Packages\PHPJava\Kernel\Behavior\System;`
`5`	`5`	`use PHPJava\Packages\java\lang\NoSuchMethodException;`
	`6`	`+use PHPJava\Packages\java\lang\CloneNotSupportedException;`
`6`	`7`
`7`	`8`	`trait _Object`
`8`	`9`	`{`
`9`		`-`
`10`	`10`	`private $parameters;`
`11`	`11`
`12`	`12`	`/**`
`@@ -41,12 +41,9 @@ public function __call($name, $arguments)`
`41`	`41`	`throw new NoSuchMethodException($name . ' does not exist on ' . get_class($this));`
`42`	`42`	`}`
`43`	`43`
`44`		`- /**`
`45`		`- * @return _Object`
`46`		`- */`
`47`		`- public function __default_clone(): _Object`
	`44`	`+ public function __default_clone(): void`
`48`	`45`	`{`
`49`		`- return clone $this;`
	`46`	`+ throw new CloneNotSupportedException();`
`50`	`47`	`}`
`51`	`48`
`52`	`49`	`/**`