Merge pull request #265 from php-java/add-operand-validation

m3m0r7 · web-flow · commit 6c9dfdc58180 · 2020-01-11T22:53:13.000+09:00
Add operand validation
diff --git a/src/Compiler/Builder/Generator/Operation/Operand.php b/src/Compiler/Builder/Generator/Operation/Operand.php
@@ -2,13 +2,45 @@
 declare(strict_types=1);
 namespace PHPJava\Compiler\Builder\Generator\Operation;
 
+use PHPJava\Compiler\Builder\Finder\Result\ConstantPoolFinderResult;
+use PHPJava\Compiler\Builder\Types\Int16;
+use PHPJava\Compiler\Builder\Types\Int32;
+use PHPJava\Compiler\Builder\Types\Int8;
+use PHPJava\Compiler\Builder\Types\Uint16;
+use PHPJava\Compiler\Builder\Types\Uint32;
+use PHPJava\Compiler\Builder\Types\Uint8;
+use PHPJava\Exceptions\AssembleStructureException;
+
 class Operand
 {
     protected $type;
     protected $value;
 
     public static function factory(string $type, $value): self
     {
+        if (!in_array(
+            $type,
+            [
+                Uint8::class,
+                Uint16::class,
+                Uint32::class,
+                Int8::class,
+                Int16::class,
+                Int32::class,
+            ],
+            true
+        )) {
+            throw new AssembleStructureException(
+                'Invalid class type: ' . $type
+            );
+        }
+        if (!($value instanceof ConstantPoolFinderResult)
+            && !is_int($value)
+        ) {
+            throw new AssembleStructureException(
+                'Passed parameter is not initiated a ConstantPoolFinderResult'
+            );
+        }
         $scopedValue = $value;
         return new static($type, $scopedValue);
     }
