Skip to content

ext/uri: Reorganises legacy tests - #23286

Draft
NickSdot wants to merge 7 commits into
php:masterfrom
NickSdot:hardening/ext-uri-reorg
Draft

ext/uri: Reorganises legacy tests#23286
NickSdot wants to merge 7 commits into
php:masterfrom
NickSdot:hardening/ext-uri-reorg

Conversation

@NickSdot

@NickSdot NickSdot commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Ref: #23271 (review) @kocsismate
Depends on: #23271 (ready here, but marked as draft until 23271 is merged)

Coverage

Coverage: ext/uri

Base: 5332ab0c291361abe3d12db21dd55e5dc7baa829 upstream/master
Tree: 74844f28e7689f58de3002d41021328750ed0310 working tree

+--------+-------+---------+--------------------+------------------+--------+---------+
|        | Tests | Sources |              Lines |         Branches |   Time |  Memory |
+--------+-------+---------+--------------------+------------------+--------+---------+
| Base   |   374 |       7 | 1697/1934 (87.75%) | 589/968 (60.85%) |  6.49s | 28.0 MB |
| Tree   |   393 |       7 | 1697/1934 (87.75%) | 589/968 (60.85%) |  8.17s | 27.7 MB |
| Change |   +19 |       0 |   +0 / -0 (+0.00%) | +0 / -0 (+0.00%) | +1.69s | -0.2 MB |
+--------+-------+---------+--------------------+------------------+--------+---------+

@NickSdot NickSdot mentioned this pull request Aug 14, 2026
Open
NickSdot
NickSdot commented Aug 15, 2026
View reviewed changes
Comment thread ext/uri/tests/rfc3986/parsing/port_error_overflow.phpt
}
} catch (Throwable $e) {
echo $e::class, ": ", $e->getMessage(), PHP_EOL;
echo $e::class, ': ', $e->getMessage(), "\n";

@NickSdot NickSdot Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the file now is in git history anyway (move), I unified the style. Cool?

NickSdot
NickSdot commented Aug 15, 2026
View reviewed changes
Comment thread ext/uri/tests/whatwg/parsing/errors_reference_error.phpt
Uri\WhatWg\Url::parse(" https://example.org ", errors: $f->x);
} catch (Throwable $e) {
echo $e::class, ": ", $e->getMessage(), PHP_EOL;
echo $e::class, ': ', $e->getMessage(), "\n";

@NickSdot NickSdot Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

NickSdot
NickSdot commented Aug 15, 2026
View reviewed changes
Comment thread ext/uri/tests/rfc3986/parsing/zend_test_parse_url.phpt

@NickSdot NickSdot Aug 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two options for these: keep grouped in eg parsing with zend_ prefix or give dedicated zend dir. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate will be requested when the pull request is marked ready for review kocsismate is a code owner
@TimWolla TimWolla Awaiting requested review from TimWolla TimWolla will be requested when the pull request is marked ready for review TimWolla is a code owner

Assignees

No one assigned

Labels

Extension: uri

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NickSdot