You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When dirname is bigger than 0, there is no automatic cleanup of old sessions. I think it's oversight and shouldn't work like this. If the performance is the issue then lower GC probability should be set instead ignoring cleanup.
This is not security issue, because documentation clearly state the current behavior, but still should work differently from the first place.
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand why we need to loops that are basically identical? Also I'd prefer if those new GC tests are in a subfolder (maybe even a mod_files subfolder)
I don't really understand why we need to loops that are basically identical?
First loop is for checking and removing the session when remaining_depth == 0, because this is the only level where session files are stored.
Second loop is for getting directories based on the value of dirname, becaue this is the level of nesting for the directories where session files are stored.
But of course, we can merge both of them and check inside what the value of remaining_depth is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Girgias
left a comment
When
dirnameis bigger than 0, there is no automatic cleanup of old sessions. I think it's oversight and shouldn't work like this. If the performance is the issue then lower GC probability should be set instead ignoring cleanup.This is not security issue, because documentation clearly state the current behavior, but still should work differently from the first place.