Add tests for Django clean and get_or_create functions and fix related issues (#31)

keithhackbarth · keithhackbarth · commit 050e980913b3 · 2023-09-24T16:15:30.000-07:00
diff --git a/pgvector/utils/__init__.py b/pgvector/utils/__init__.py
@@ -7,7 +7,13 @@ def from_db(value):
     if value is None or isinstance(value, np.ndarray):
         return value
 
-    return np.array(value[1:-1].split(','), dtype=np.float32)
+    # could be a string or a list if already cast by lower-level driver
+    if isinstance(value, str):
+        db_list = value[1:-1].split(',')
+    else:
+        db_list = value
+
+    return np.array(db_list, dtype=np.float32)
 
 
 def from_db_binary(value):
diff --git a/tests/test_django.py b/tests/test_django.py
@@ -178,3 +178,10 @@ def test_form_save(self):
         assert form.is_valid()
         assert form.save()
         assert [4, 5, 6] == Item.objects.get(pk=1).embedding.tolist()
+
+    def test_clean(self):
+        item = Item(id=1, embedding=[1, 2, 3])
+        item.full_clean()
+
+    def test_get_or_create(self):
+        Item.objects.get_or_create(embedding=[1, 2, 3])
