Updated SparseVector constructor to support zero dimensions like other constructors [skip ci]

ankane · ankane · commit 7c946e14e48b · 2026-03-06T21:29:49.000-08:00
diff --git a/include/pgvector/sparsevec.hpp b/include/pgvector/sparsevec.hpp
@@ -39,8 +39,8 @@ class SparseVector {
 
     /// Creates a sparse vector from a map of non-zero elements.
     SparseVector(const std::unordered_map<int, float>& map, int dimensions) {
-        if (dimensions < 1) {
-            throw std::invalid_argument{"sparsevec must have at least 1 dimension"};
+        if (dimensions < 0) {
+            throw std::invalid_argument{"sparsevec dimensions cannot be negative"};
         }
         dimensions_ = dimensions;
 
diff --git a/test/pqxx_test.cpp b/test/pqxx_test.cpp
@@ -246,7 +246,7 @@ void test_sparsevec_from_string() {
 
     assert_exception<pqxx::conversion_error>([] {
         auto _ = pqxx::from_string<pgvector::SparseVector>("{}/-1");
-    }, "sparsevec must have at least 1 dimension");
+    }, "sparsevec dimensions cannot be negative");
 
     assert_exception<pqxx::conversion_error>([] {
         auto _ = pqxx::from_string<pgvector::SparseVector>("{:}/1");
diff --git a/test/sparsevec_test.cpp b/test/sparsevec_test.cpp
@@ -27,8 +27,8 @@ static void test_constructor_map() {
     assert_equal(vec.values() == std::vector<float>{1, 2, 3}, true);
 
     assert_exception<std::invalid_argument>([&]{
-        SparseVector(map, 0);
-    }, "sparsevec must have at least 1 dimension");
+        SparseVector(map, -1);
+    }, "sparsevec dimensions cannot be negative");
 
     assert_exception<std::invalid_argument>([&]{
         SparseVector(map, 4);

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,8 @@ class SparseVector {`
`39`	`39`
`40`	`40`	`/// Creates a sparse vector from a map of non-zero elements.`
`41`	`41`	`SparseVector(const std::unordered_map<int, float>& map, int dimensions) {`
`42`		`- if (dimensions < 1) {`
`43`		`- throw std::invalid_argument{"sparsevec must have at least 1 dimension"};`
	`42`	`+ if (dimensions < 0) {`
	`43`	`+ throw std::invalid_argument{"sparsevec dimensions cannot be negative"};`
`44`	`44`	`}`
`45`	`45`	`dimensions_ = dimensions;`
`46`	`46`