Improved index check for from_string [skip ci]

ankane · ankane · commit 5cdf935d955e · 2026-03-06T17:08:25.000-08:00
diff --git a/include/pgvector/pqxx.hpp b/include/pgvector/pqxx.hpp
@@ -200,7 +200,7 @@ template<> struct string_traits<pgvector::SparseVector> {
                 int index = pqxx::from_string<int>(substr.substr(0, ne), c);
                 float value = pqxx::from_string<float>(substr.substr(ne + 1), c);
 
-                if (index < 1) {
+                if (index < 1 || index > dimensions) {
                     throw conversion_error{"Index out of bounds"};
                 }
 
diff --git a/test/pqxx_test.cpp b/test/pqxx_test.cpp
@@ -264,6 +264,10 @@ void test_sparsevec_from_string() {
         auto _ = pqxx::from_string<pgvector::SparseVector>("{-2147483648:1}/1");
     }, "Index out of bounds");
 
+    assert_exception<pqxx::conversion_error>([] {
+        auto _ = pqxx::from_string<pgvector::SparseVector>("{2:1}/1");
+    }, "Index out of bounds");
+
     assert_exception<pqxx::conversion_error>([] {
         auto _ = pqxx::from_string<pgvector::SparseVector>("{1:4e38}/1");
     }, float_error("Could not convert '4e38' to float: Value out of range."));

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ template<> struct string_traits<pgvector::SparseVector> {`
`200`	`200`	`int index = pqxx::from_string<int>(substr.substr(0, ne), c);`
`201`	`201`	`float value = pqxx::from_string<float>(substr.substr(ne + 1), c);`
`202`	`202`
`203`		`- if (index < 1) {`
	`203`	`+ if (index < 1 \|\| index > dimensions) {`
`204`	`204`	`throw conversion_error{"Index out of bounds"};`
`205`	`205`	`}`
`206`	`206`