Added static casts [skip ci]

ankane · ankane · commit 4b3c87a207f0 · 2026-03-06T12:46:20.000-08:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -32,7 +32,7 @@ if(CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
         add_executable(test test/halfvec_test.cpp test/main.cpp test/pqxx_test.cpp test/sparsevec_test.cpp test/vector_test.cpp)
         target_link_libraries(test PRIVATE libpqxx::pqxx pgvector::pgvector)
         if(NOT MSVC)
-            target_compile_options(test PRIVATE -Wall -Wextra -Wpedantic -Werror)
+            target_compile_options(test PRIVATE -Wall -Wextra -Wpedantic -Wconversion -Werror)
         endif()
     endif()
 endif()
diff --git a/include/pgvector/sparsevec.hpp b/include/pgvector/sparsevec.hpp
@@ -33,11 +33,12 @@ class SparseVector {
 
     /// Creates a sparse vector from a span.
     explicit SparseVector(std::span<const float> value) {
-        dimensions_ = value.size();
+        // TODO throw exception
+        dimensions_ = static_cast<int>(value.size());
         for (size_t i = 0; i < value.size(); i++) {
             float v = value[i];
             if (v != 0) {
-                indices_.push_back(i);
+                indices_.push_back(static_cast<int>(i));
                 values_.push_back(v);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -33,11 +33,12 @@ class SparseVector {`
`33`	`33`
`34`	`34`	`/// Creates a sparse vector from a span.`
`35`	`35`	`explicit SparseVector(std::span<const float> value) {`
`36`		`- dimensions_ = value.size();`
	`36`	`+ // TODO throw exception`
	`37`	`+ dimensions_ = static_cast<int>(value.size());`
`37`	`38`	`for (size_t i = 0; i < value.size(); i++) {`
`38`	`39`	`float v = value[i];`
`39`	`40`	`if (v != 0) {`
`40`		`- indices_.push_back(i);`
	`41`	`+ indices_.push_back(static_cast<int>(i));`
`41`	`42`	`values_.push_back(v);`
`42`	`43`	`}`
`43`	`44`	`}`