Disable non_native_boolean_check_constraint (databricks#120)

bkyryliuk · Jesse Whitehouse · web-flow · commit ec581447ab3f · 2023-07-12T16:38:02.000-05:00
---------
Signed-off-by: Bogdan Kyryliuk &lt;b.kyryliuk@gmail.com&gt;
Signed-off-by: Jesse Whitehouse &lt;jesse.whitehouse@databricks.com&gt;
Co-authored-by: Jesse Whitehouse &lt;jesse.whitehouse@databricks.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 - Add support for Cloud Fetch (#146, #151, #154)
 - SQLAlchemy has_table function now honours schema= argument and adds catalog= argument (#174)
+- SQLAlchemy set non_native_boolean_check_constraint False as it's not supported by Databricks (#120)
 - Fix: Revised SQLAlchemy dialect and examples for compatibility with SQLAlchemy==1.3.x (#173)
 - Fix: oauth would fail if expired credentials appeared in ~/.netrc (#122)
 - Fix: Python HTTP proxies were broken after switch to urllib3 (#158)
diff --git a/examples/sqlalchemy.py b/examples/sqlalchemy.py
@@ -89,7 +89,7 @@ class SampleObject(base):
 
     name = Column(String(255), primary_key=True)
     episodes = Column(Integer)
-    some_bool = Column(BOOLEAN(create_constraint=False))
+    some_bool = Column(BOOLEAN)
 
 
 base.metadata.create_all()
diff --git a/src/databricks/sqlalchemy/dialect/__init__.py b/src/databricks/sqlalchemy/dialect/__init__.py
@@ -81,6 +81,7 @@ class DatabricksDialect(default.DefaultDialect):
     supports_multivalues_insert: bool = True
     supports_native_decimal: bool = True
     supports_sane_rowcount: bool = False
+    non_native_boolean_check_constraint: bool = False
 
     @classmethod
     def dbapi(cls):
diff --git a/tests/e2e/sqlalchemy/test_basic.py b/tests/e2e/sqlalchemy/test_basic.py
@@ -148,7 +148,7 @@ def test_create_table_not_null(db_engine, metadata_obj: MetaData):
         metadata_obj,
         Column("name", String(255)),
         Column("episodes", Integer),
-        Column("some_bool", BOOLEAN(create_constraint=False), nullable=False),
+        Column("some_bool", BOOLEAN, nullable=False),
     )
 
     metadata_obj.create_all()
@@ -201,7 +201,7 @@ def test_create_insert_drop_table_core(base, db_engine, metadata_obj: MetaData):
         metadata_obj,
         Column("name", String(255)),
         Column("episodes", Integer),
-        Column("some_bool", BOOLEAN(create_constraint=False)),
+        Column("some_bool", BOOLEAN),
         Column("dollars", DECIMAL(10, 2)),
     )
 
@@ -240,7 +240,7 @@ class SampleObject(base):
 
         name = Column(String(255), primary_key=True)
         episodes = Column(Integer)
-        some_bool = Column(BOOLEAN(create_constraint=False))
+        some_bool = Column(BOOLEAN)
 
     base.metadata.create_all()
 
@@ -272,7 +272,7 @@ def test_dialect_type_mappings(base, db_engine, metadata_obj: MetaData):
         metadata_obj,
         Column("string_example", String(255)),
         Column("integer_example", Integer),
-        Column("boolean_example", BOOLEAN(create_constraint=False)),
+        Column("boolean_example", BOOLEAN),
         Column("decimal_example", DECIMAL(10, 2)),
         Column("date_example", Date),
     )
