Skip to content

Commit 5a9535a

Browse files
cvvergaracvvergara
committed
[SQL] Not using wildcard on SELECT statements
1 parent 839b887 commit 5a9535a

70 files changed

Lines changed: 226 additions & 214 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎sql/allpairs/floydWarshall.sql‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ CREATE FUNCTION pgr_floydWarshall(
3939
RETURNS SETOF RECORD AS
4040
$BODY$
4141

42-
SELECT *
42+
SELECT start_vid, end_vid, agg_cost
4343
FROM _pgr_floydWarshall(_pgr_get_statement($1), $2);
4444

4545
$BODY$

‎sql/allpairs/johnson.sql‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ CREATE FUNCTION pgr_johnson(
3939
RETURNS SETOF RECORD AS
4040
$BODY$
4141

42-
SELECT *
42+
SELECT start_vid, end_vid, agg_cost
4343
FROM _pgr_johnson(_pgr_get_statement($1), $2);
4444

4545
$BODY$

‎sql/astar/astar.sql‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,8 @@ CREATE FUNCTION pgr_aStar(
140140

141141
RETURNS SETOF RECORD AS
142142
$BODY$
143-
SELECT *
144-
FROM _pgr_aStar(_pgr_get_statement($1), $2::BIGINT[], $3::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT) AS a;
143+
SELECT seq, path_seq, start_vid, end_vid, node, edge, cost, agg_cost
144+
FROM _pgr_aStar(_pgr_get_statement($1), $2::BIGINT[], $3::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT);
145145
$BODY$
146146
LANGUAGE sql VOLATILE STRICT
147147
COST 100
@@ -169,8 +169,8 @@ CREATE FUNCTION pgr_aStar(
169169

170170
RETURNS SETOF RECORD AS
171171
$BODY$
172-
SELECT *
173-
FROM _pgr_aStar(_pgr_get_statement($1), _pgr_get_statement($2), $3, $4, $5::FLOAT, $6::FLOAT) AS a;
172+
SELECT seq, path_seq, start_vid, end_vid, node, edge, cost, agg_cost
173+
FROM _pgr_aStar(_pgr_get_statement($1), _pgr_get_statement($2), $3, $4, $5::FLOAT, $6::FLOAT);
174174
$BODY$
175175
LANGUAGE sql VOLATILE STRICT
176176
COST 100

‎sql/bdAstar/bdAstar.sql‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ CREATE FUNCTION pgr_bdAstar(
4848
OUT agg_cost FLOAT)
4949
RETURNS SETOF RECORD AS
5050
$BODY$
51-
SELECT a.seq, a.path_seq, a.node, a.edge, a.cost, a.agg_cost
52-
FROM _pgr_bdAstar(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], ARRAY[$3]::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT, false) AS a;
51+
SELECT seq, path_seq, node, edge, cost, agg_cost
52+
FROM _pgr_bdAstar(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], ARRAY[$3]::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT, false);
5353
$BODY$
5454
LANGUAGE sql VOLATILE STRICT
5555
COST 100
@@ -76,8 +76,8 @@ CREATE FUNCTION pgr_bdAstar(
7676
OUT agg_cost FLOAT)
7777
RETURNS SETOF RECORD AS
7878
$BODY$
79-
SELECT a.seq, a.path_seq, a.end_vid, a.node, a.edge, a.cost, a.agg_cost
80-
FROM _pgr_bdAstar(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], $3::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT, false) AS a;
79+
SELECT seq, path_seq, end_vid, node, edge, cost, agg_cost
80+
FROM _pgr_bdAstar(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], $3::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT, false);
8181
$BODY$
8282
LANGUAGE sql VOLATILE STRICT
8383
COST 100
@@ -104,8 +104,8 @@ CREATE FUNCTION pgr_bdAstar(
104104
OUT agg_cost FLOAT)
105105
RETURNS SETOF RECORD AS
106106
$BODY$
107-
SELECT a.seq, a.path_seq, a.start_vid, a.node, a.edge, a.cost, a.agg_cost
108-
FROM _pgr_bdAstar(_pgr_get_statement($1), $2::BIGINT[], ARRAY[$3]::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT, false) AS a;
107+
SELECT seq, path_seq, start_vid, node, edge, cost, agg_cost
108+
FROM _pgr_bdAstar(_pgr_get_statement($1), $2::BIGINT[], ARRAY[$3]::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT, false);
109109
$BODY$
110110
LANGUAGE sql VOLATILE STRICT
111111
COST 100
@@ -133,7 +133,7 @@ CREATE FUNCTION pgr_bdAstar(
133133
OUT agg_cost FLOAT)
134134
RETURNS SETOF RECORD AS
135135
$BODY$
136-
SELECT *
136+
SELECT seq, path_seq, start_vid, end_vid, node, edge, cost, agg_cost
137137
FROM _pgr_bdAstar(_pgr_get_statement($1), $2::BIGINT[], $3::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT, false);
138138
$BODY$
139139
LANGUAGE sql VOLATILE STRICT
@@ -161,7 +161,7 @@ CREATE FUNCTION pgr_bdAstar(
161161
OUT agg_cost FLOAT)
162162
RETURNS SETOF RECORD AS
163163
$BODY$
164-
SELECT *
164+
SELECT seq, path_seq, start_vid, end_vid, node, edge, cost, agg_cost
165165
FROM _pgr_bdAstar(_pgr_get_statement($1), _pgr_get_statement($2), $3, $4, $5::FLOAT, $6::FLOAT, false);
166166
$BODY$
167167
LANGUAGE sql VOLATILE STRICT

‎sql/bdDijkstra/bdDijkstra.sql‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ CREATE FUNCTION pgr_bdDijkstra(
4747
OUT agg_cost FLOAT)
4848
RETURNS SETOF RECORD AS
4949
$BODY$
50-
SELECT a.seq, a.path_seq, a.node, a.edge, a.cost, a.agg_cost
51-
FROM _pgr_bdDijkstra(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], ARRAY[$3]::BIGINT[], $4, false) AS a;
50+
SELECT seq, path_seq, node, edge, cost, agg_cost
51+
FROM _pgr_bdDijkstra(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], ARRAY[$3]::BIGINT[], $4, false);
5252
$BODY$
5353
LANGUAGE sql VOLATILE STRICT
5454
COST 100
@@ -73,8 +73,8 @@ CREATE FUNCTION pgr_bdDijkstra(
7373
OUT agg_cost FLOAT)
7474
RETURNS SETOF RECORD AS
7575
$BODY$
76-
SELECT a.seq, a.path_seq, a.end_vid, a.node, a.edge, a.cost, a.agg_cost
77-
FROM _pgr_bdDijkstra(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], $3::BIGINT[], $4, false) as a;
76+
SELECT seq, path_seq, end_vid, node, edge, cost, agg_cost
77+
FROM _pgr_bdDijkstra(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], $3::BIGINT[], $4, false);
7878
$BODY$
7979
LANGUAGE sql VOLATILE STRICT
8080
COST 100
@@ -99,8 +99,8 @@ CREATE FUNCTION pgr_bdDijkstra(
9999
OUT agg_cost FLOAT)
100100
RETURNS SETOF RECORD AS
101101
$BODY$
102-
SELECT a.seq, a.path_seq, a.start_vid, a.node, a.edge, a.cost, a.agg_cost
103-
FROM _pgr_bdDijkstra(_pgr_get_statement($1), $2::BIGINT[], ARRAY[$3]::BIGINT[], $4, false) as a;
102+
SELECT seq, path_seq, start_vid, node, edge, cost, agg_cost
103+
FROM _pgr_bdDijkstra(_pgr_get_statement($1), $2::BIGINT[], ARRAY[$3]::BIGINT[], $4, false);
104104
$BODY$
105105
LANGUAGE sql VOLATILE STRICT
106106
COST 100
@@ -127,8 +127,8 @@ CREATE FUNCTION pgr_bdDijkstra(
127127
OUT agg_cost FLOAT)
128128
RETURNS SETOF RECORD AS
129129
$BODY$
130-
SELECT *
131-
FROM _pgr_bdDijkstra(_pgr_get_statement($1), $2::BIGINT[], $3::BIGINT[], directed, false) as a;
130+
SELECT seq, path_seq, start_vid, end_vid, node, edge, cost, agg_cost
131+
FROM _pgr_bdDijkstra(_pgr_get_statement($1), $2::BIGINT[], $3::BIGINT[], directed, false);
132132
$BODY$
133133
LANGUAGE SQL VOLATILE STRICT
134134
COST 100
@@ -153,8 +153,8 @@ CREATE FUNCTION pgr_bdDijkstra(
153153
OUT agg_cost FLOAT)
154154
RETURNS SETOF RECORD AS
155155
$BODY$
156-
SELECT *
157-
FROM _pgr_bdDijkstra(_pgr_get_statement($1), _pgr_get_statement($2), directed, false) as a;
156+
SELECT seq, path_seq, start_vid, end_vid, node, edge, cost, agg_cost
157+
FROM _pgr_bdDijkstra(_pgr_get_statement($1), _pgr_get_statement($2), directed, false);
158158
$BODY$
159159
LANGUAGE SQL VOLATILE STRICT
160160
COST 100

‎sql/breadthFirstSearch/breadthFirstSearch.sql‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ BEGIN
5858

5959

6060
RETURN QUERY
61-
SELECT *
61+
SELECT a.seq, a.depth, a.start_vid, a.node, a.edge, a.cost, a.agg_cost
6262
FROM _pgr_breadthFirstSearch(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], max_depth, directed) AS a;
6363
END;
6464
$BODY$
@@ -92,7 +92,7 @@ BEGIN
9292

9393

9494
RETURN QUERY
95-
SELECT *
95+
SELECT a.seq, a.depth, a.start_vid, a.node, a.edge, a.cost, a.agg_cost
9696
FROM _pgr_breadthFirstSearch(_pgr_get_statement($1), $2::BIGINT[], max_depth, directed) AS a;
9797
END;
9898
$BODY$
@@ -107,7 +107,7 @@ IS 'pgr_breadthFirstSearch(One to Depth)
107107
- Parameters:
108108
- edges SQL with columns: id, source, target, cost [,reverse_cost]
109109
- From vertex identifier
110-
- Optional Parameters:
110+
- Optional Parameters:
111111
- Maximum Depth := 9223372036854775807
112112
- directed := true
113113
- Documentation:
@@ -125,4 +125,4 @@ IS 'pgr_breadthFirstSearch(Many to Depth)
125125
- directed := true
126126
- Documentation:
127127
- ${PROJECT_DOC_LINK}/pgr_breadthFirstSearch.html
128-
';
128+
';

‎sql/chinese/pgr_chinesePostman.sql‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ CREATE FUNCTION pgr_chinesePostman(
4646

4747
RETURNS SETOF RECORD AS
4848
$BODY$
49-
SELECT *
49+
SELECT seq, node, edge, cost, agg_cost
5050
FROM _pgr_chinesePostman(_pgr_get_statement($1), only_cost := false);
5151
$BODY$
5252
LANGUAGE SQL VOLATILE STRICT;

‎sql/circuits/hawickCircuits.sql‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ RETURNS SETOF RECORD AS
4848
$BODY$
4949
BEGIN
5050
RETURN QUERY
51-
SELECT *
52-
FROM _pgr_hawickCircuits(_pgr_get_statement($1));
51+
SELECT a.seq, a.path_id, a.path_seq, a.start_vid, a.end_vid, a.node, a.edge, a.cost, a.agg_cost
52+
FROM _pgr_hawickCircuits(_pgr_get_statement($1)) AS a;
5353
END;
5454
$BODY$
5555
LANGUAGE plpgsql VOLATILE STRICT;

‎sql/coloring/bipartite.sql‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ RETURNS SETOF RECORD AS
4040
$BODY$
4141
BEGIN
4242
RETURN QUERY
43-
SELECT *
43+
SELECT node, color
4444
FROM _pgr_bipartite(_pgr_get_statement($1));
4545
END;
4646
$BODY$

‎sql/coloring/edgeColoring.sql‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ RETURNS SETOF RECORD AS
4040
$BODY$
4141
BEGIN
4242
RETURN QUERY
43-
SELECT *
44-
FROM _pgr_edgeColoring(_pgr_get_statement($1));
43+
SELECT a.edge_id, a.color_id
44+
FROM _pgr_edgeColoring(_pgr_get_statement($1)) AS a;
4545
END;
4646
$BODY$
4747
LANGUAGE plpgsql VOLATILE STRICT;

0 commit comments

Comments
 (0)