- added instanceof method

inolen · inolen · commit e267c70b400a · 2013-11-10T19:48:49.000-08:00
diff --git a/src/java.cpp b/src/java.cpp
@@ -57,6 +57,7 @@ long my_getThreadId() {
   NODE_SET_PROTOTYPE_METHOD(s_ct, "newFloat", newFloat);
   NODE_SET_PROTOTYPE_METHOD(s_ct, "getStaticFieldValue", getStaticFieldValue);
   NODE_SET_PROTOTYPE_METHOD(s_ct, "setStaticFieldValue", setStaticFieldValue);
+  NODE_SET_PROTOTYPE_METHOD(s_ct, "instanceof", instanceof);
 
   target->Set(v8::String::NewSymbol("Java"), s_ct->GetFunction());
 }
@@ -793,6 +794,37 @@ void Java::destroyJVM(JavaVM** jvm, JNIEnv** env) {
   return v8::Undefined();
 }
 
+/*static*/ v8::Handle<v8::Value> Java::instanceof(const v8::Arguments& args) {
+  v8::HandleScope scope;
+  Java* self = node::ObjectWrap::Unwrap<Java>(args.This());
+  v8::Handle<v8::Value> ensureJvmResults = self->ensureJvm();
+  if(!ensureJvmResults->IsUndefined()) {
+    return ensureJvmResults;
+  }
+  JNIEnv* env = self->getJavaEnv();
+  JavaScope javaScope(env);
+
+  int argsStart = 0;
+  ARGS_FRONT_OBJECT(obj);
+  ARGS_FRONT_STRING(className);
+
+  jobject instance = v8ToJava(env, obj);
+  if (!instance) {
+    // not even a Java object
+    return v8::False();
+  }
+
+  jclass clazz = javaFindClass(env, className);
+  if(!clazz) {
+    std::ostringstream errStr;
+    errStr << "Could not find class " << className.c_str();
+    return ThrowException(javaExceptionToV8(self, env, errStr.str()));
+  }
+
+  jboolean res = env->IsInstanceOf(instance, clazz);
+  return v8::Boolean::New(res);
+}
+
 void EIO_CallJs(uv_work_t* req) {
 }
 
diff --git a/src/java.h b/src/java.h
@@ -35,6 +35,7 @@ class Java : public node::ObjectWrap {
   static v8::Handle<v8::Value> newFloat(const v8::Arguments& args);
   static v8::Handle<v8::Value> getStaticFieldValue(const v8::Arguments& args);
   static v8::Handle<v8::Value> setStaticFieldValue(const v8::Arguments& args);
+  static v8::Handle<v8::Value> instanceof(const v8::Arguments& args);
   static v8::Handle<v8::Value> AccessorProhibitsOverwritingGetter(v8::Local<v8::String> name, const v8::AccessorInfo &info);
   static void AccessorProhibitsOverwritingSetter(v8::Local<v8::String> property, v8::Local<v8::Value> value, const v8::AccessorInfo &info);
   v8::Handle<v8::Value> ensureJvm();
diff --git a/src/utils.cpp b/src/utils.cpp
@@ -288,8 +288,8 @@ jobject v8ToJava(JNIEnv* env, v8::Local<v8::Value> arg) {
   }
 
   // TODO: handle other arg types
-  v8::String::AsciiValue typeStr(arg);
-  printf("v8ToJava: Unhandled type: %s\n", *typeStr);
+  // v8::String::AsciiValue typeStr(arg);
+  // printf("v8ToJava: Unhandled type: %s\n", *typeStr);
   return NULL;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -288,8 +288,8 @@ jobject v8ToJava(JNIEnv* env, v8::Local<v8::Value> arg) {`
`288`	`288`	`}`
`289`	`289`
`290`	`290`	`// TODO: handle other arg types`
`291`		`- v8::String::AsciiValue typeStr(arg);`
`292`		`- printf("v8ToJava: Unhandled type: %s\n", *typeStr);`
	`291`	`+ // v8::String::AsciiValue typeStr(arg);`
	`292`	`+ // printf("v8ToJava: Unhandled type: %s\n", *typeStr);`
`293`	`293`	`return NULL;`
`294`	`294`	`}`
`295`	`295`