speed up method calls by caching method invoke method id

joeferner · joeferner · commit 70d84f9d74d2 · 2014-07-25T18:22:44.000-04:00
diff --git a/src/methodCallBaton.cpp b/src/methodCallBaton.cpp
@@ -12,7 +12,8 @@ NanCallback* toNanCallback(v8::Handle<v8::Value>& callback) {
 }
 
 MethodCallBaton::MethodCallBaton(Java* java, jobject method, jarray args, v8::Handle<v8::Value>& callback) :
-  NanAsyncWorker(toNanCallback(callback)) {
+  NanAsyncWorker(toNanCallback(callback)),
+  m_methodInvokeMethodId(0) {
   JNIEnv *env = java->getJavaEnv();
   m_java = java;
   m_args = (jarray)env->NewGlobalRef(args);
@@ -34,6 +35,14 @@ MethodCallBaton::~MethodCallBaton() {
   env->DeleteGlobalRef(m_method);
 }
 
+jmethodID MethodCallBaton::getMethodInvokeMethodId() {
+  if(m_methodInvokeMethodId == 0) {
+    jclass methodClazz = m_env->FindClass("java/lang/reflect/Method");
+    m_methodInvokeMethodId = m_env->GetMethodID(methodClazz, "invoke", "(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object;");
+  }
+  return m_methodInvokeMethodId;
+}
+
 void MethodCallBaton::run() {
   NanAsyncQueueWorker(this);
 }
@@ -112,8 +121,7 @@ void NewInstanceBaton::ExecuteInternal() {
 }
 
 void StaticMethodCallBaton::ExecuteInternal() {
-  jclass methodClazz = m_env->FindClass("java/lang/reflect/Method");
-  jmethodID method_invoke = m_env->GetMethodID(methodClazz, "invoke", "(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object;");
+  jmethodID method_invoke = getMethodInvokeMethodId();
 
   /*
   printf("calling %s\n", javaObjectToString(m_env, m_method).c_str());
@@ -137,8 +145,7 @@ void StaticMethodCallBaton::ExecuteInternal() {
 }
 
 void InstanceMethodCallBaton::ExecuteInternal() {
-  jclass methodClazz = m_env->FindClass("java/lang/reflect/Method");
-  jmethodID method_invoke = m_env->GetMethodID(methodClazz, "invoke", "(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object;");
+  jmethodID method_invoke = getMethodInvokeMethodId();
 
   /*
   printf("calling %s\n", javaObjectToString(m_env, m_method).c_str());
diff --git a/src/methodCallBaton.h b/src/methodCallBaton.h
@@ -25,6 +25,7 @@ class MethodCallBaton : public NanAsyncWorker {
   virtual void Execute();
   virtual void WorkComplete();
   virtual void ExecuteInternal() = 0;
+  jmethodID getMethodInvokeMethodId();
 
   JNIEnv *m_env;
   Java* m_java;
@@ -33,6 +34,9 @@ class MethodCallBaton : public NanAsyncWorker {
   jarray m_args;
   jobject m_result;
   jobject m_method;
+
+private:
+  jmethodID m_methodInvokeMethodId;
 };
 
 class InstanceMethodCallBaton : public MethodCallBaton {
