Add missing new methods + Fix broken compilation after Godo's API changes

perbone · perbone · commit eb60135b19a9 · 2023-10-13T16:51:49.000-03:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## 0.0.92 - 2023-10-13
+
+### Added
+
+- Add missing new methods
+
+### Fixed
+
+- Fix broken compilation after Godo's API changes
+
 ## 0.0.91 - 2023-07-10
 
 ### Changed
diff --git a/lua_script.cpp b/lua_script.cpp
@@ -166,6 +166,16 @@ Vector<DocData::ClassDoc> LuaScript::get_documentation() const {
 
 	return this->docs;
 } // TODO
+
+String LuaScript::get_class_icon_path() const {
+	print_debug("LuaScript::get_class_icon_path");
+	return String();
+} // TODO
+
+PropertyInfo LuaScript::get_class_category() const {
+	print_debug("LuaScript::get_class_category");
+	return PropertyInfo();
+} // TODO
 #endif
 
 bool LuaScript::has_method(const StringName &p_method) const { // TODO
@@ -192,6 +202,12 @@ bool LuaScript::is_valid() const { // TODO
 	return this->valid;
 }
 
+bool LuaScript::is_abstract() const {
+	print_debug("LuaScript::is_abstract");
+
+	return false;
+}
+
 ScriptLanguage *LuaScript::get_language() const { // TODO
 	print_debug("LuaScript::get_language");
 
diff --git a/lua_script.h b/lua_script.h
@@ -54,13 +54,16 @@ class LuaScript : public Script {
 
 #ifdef TOOLS_ENABLED
 	Vector<DocData::ClassDoc> get_documentation() const override;
+	String get_class_icon_path() const override;
+	PropertyInfo get_class_category() const override;
 #endif
 
 	bool has_method(const StringName &p_method) const override;
 	MethodInfo get_method_info(const StringName &p_method) const override;
 
 	bool is_tool() const override;
 	bool is_valid() const override;
+	bool is_abstract() const override;
 
 	ScriptLanguage *get_language() const override;
 
diff --git a/lua_script_instance.cpp b/lua_script_instance.cpp
@@ -61,6 +61,10 @@ Variant::Type LuaScriptInstance::get_property_type(const StringName &p_name, boo
 	return Variant::Type();
 }
 
+void LuaScriptInstance::validate_property(PropertyInfo &p_property) const {
+	print_debug("LuaScriptInstance::validate_property");
+}
+
 bool LuaScriptInstance::property_can_revert(const StringName &p_name) const {
 	print_debug("LuaScriptInstance::property_can_revert( p_name = %s )", String(p_name).ascii().get_data());
 
@@ -107,10 +111,9 @@ Variant LuaScriptInstance::callp(const StringName &p_method, const Variant **p_a
 	return Variant();
 } // TODO
 
-void LuaScriptInstance::notification(int p_notification) {
+void LuaScriptInstance::notification(int p_notification, bool p_reversed) {
 	print_debug("LuaScriptInstance::notification( p_notification = %d:%s ) %s",
 			p_notification, get_notification_name(p_notification).c_str(), baseClassName.ascii().get_data());
-
 } // TODO
 
 String LuaScriptInstance::to_string(bool *r_valid) {
diff --git a/lua_script_instance.h b/lua_script_instance.h
@@ -31,6 +31,7 @@ class LuaScriptInstance : public ScriptInstance {
 	bool get(const StringName &p_name, Variant &r_ret) const override;
 	void get_property_list(List<PropertyInfo> *p_properties) const override;
 	Variant::Type get_property_type(const StringName &p_name, bool *r_is_valid = nullptr) const override;
+	void validate_property(PropertyInfo &p_property) const override;
 
 	bool property_can_revert(const StringName &p_name) const override;
 	bool property_get_revert(const StringName &p_name, Variant &r_ret) const override;
@@ -43,7 +44,7 @@ class LuaScriptInstance : public ScriptInstance {
 
 	Variant callp(const StringName &p_method, const Variant **p_args, int p_argcount, Callable::CallError &r_error) override;
 
-	void notification(int p_notification) override;
+	void notification(int p_notification, bool p_reversed = false) override;
 	String to_string(bool *r_valid) override;
 
 	void refcount_incremented() override;
diff --git a/lua_script_language.cpp b/lua_script_language.cpp
@@ -138,6 +138,10 @@ void LuaScriptLanguage::get_comment_delimiters(List<String> *p_delimiters) const
 	p_delimiters->push_back("--"); // Single-line comment starts with a double hyphens
 }
 
+void LuaScriptLanguage::get_doc_comment_delimiters(List<String> *p_delimiters) const {
+	print_debug("LuaScriptLanguage::get_doc_comment_delimiters");
+}
+
 void LuaScriptLanguage::get_string_delimiters(List<String> *p_delimiters) const {
 	print_debug("LuaScriptLanguage::get_string_delimiters");
 
diff --git a/lua_script_language.h b/lua_script_language.h
@@ -50,6 +50,7 @@ class LuaScriptLanguage : public ScriptLanguage {
 	void get_reserved_words(List<String> *p_words) const override;
 	bool is_control_flow_keyword(String p_keyword) const override;
 	void get_comment_delimiters(List<String> *p_delimiters) const override;
+	void get_doc_comment_delimiters(List<String> *p_delimiters) const override;
 	void get_string_delimiters(List<String> *p_delimiters) const override;
 	Ref<Script> make_template(const String &p_template, const String &p_class_name, const String &p_base_class_name) const override;
 	Vector<ScriptTemplate> get_built_in_templates(StringName p_object) override;

Original file line number	Diff line number	Diff line change
`@@ -138,6 +138,10 @@ void LuaScriptLanguage::get_comment_delimiters(List<String> *p_delimiters) const`
`138`	`138`	`p_delimiters->push_back("--"); // Single-line comment starts with a double hyphens`
`139`	`139`	`}`
`140`	`140`
	`141`	`+void LuaScriptLanguage::get_doc_comment_delimiters(List<String> *p_delimiters) const {`
	`142`	`+ print_debug("LuaScriptLanguage::get_doc_comment_delimiters");`
	`143`	`+}`
	`144`	`+`
`141`	`145`	`void LuaScriptLanguage::get_string_delimiters(List<String> *p_delimiters) const {`
`142`	`146`	`print_debug("LuaScriptLanguage::get_string_delimiters");`
`143`	`147`